Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8682

Should not remove decommissioned node,while calculating the number of live/dead decommissioned node.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.4
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      True is passed as argument for removing decommissioned node from live/dead node list ,while calculating the number of live/dead decommissioned node.

      public void fetchDatanodes(final List<DatanodeDescriptor> live,
      final List<DatanodeDescriptor> dead, final boolean removeDecommissionNode )

      In FSNamesystem#getNumDecomLiveDataNodes and FSNamesystem#getNumDecomDeadDataNodes , calculation is done as below.
      getBlockManager().getDatanodeManager().fetchDatanodes(null, dead, true);

        Issue Links

          Activity

          Hide
          andreina J.Andreina added a comment -

          Attached an initial patch.
          Please review.

          Show
          andreina J.Andreina added a comment - Attached an initial patch. Please review.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 26s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 44s There were no new javac warning messages.
          +1 javadoc 9m 45s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 26s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 23s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 3s Pre-build of native portion
          -1 hdfs tests 174m 35s Tests failed in hadoop-hdfs.
              218m 54s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyIsHot
          Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12742767/HDFS-8682.1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / d66302e
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11659/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11659/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11659/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 26s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 9m 45s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 26s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 23s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 32s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 3s Pre-build of native portion -1 hdfs tests 174m 35s Tests failed in hadoop-hdfs.     218m 54s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestStandbyIsHot Timed out tests org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742767/HDFS-8682.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d66302e hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11659/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11659/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11659/console This message was automatically generated.
          Hide
          andreina J.Andreina added a comment -

          Testcase failures are not related to this issue.

          As removing decommissioned node from node list has issue (HDFS-8780) , testcase related to FSNamesystem#getNumDecomLiveDataNodes and FSNamesystem#getNumDecomDeadDataNodes are validated properly.So no need for updating or adding new testcase.

          Please review the patch.

          Show
          andreina J.Andreina added a comment - Testcase failures are not related to this issue. As removing decommissioned node from node list has issue ( HDFS-8780 ) , testcase related to FSNamesystem#getNumDecomLiveDataNodes and FSNamesystem#getNumDecomDeadDataNodes are validated properly.So no need for updating or adding new testcase. Please review the patch.
          Hide
          vinayrpet Vinayakumar B added a comment -

          +1,
          Will commit soon.

          Show
          vinayrpet Vinayakumar B added a comment - +1, Will commit soon.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Committed to trunk and branch-2.
          Thanks J.Andreina

          Show
          vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks J.Andreina
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8353 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8353/)
          HDFS-8682. Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8353 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8353/ ) HDFS-8682 . Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1042 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1042/)
          HDFS-8682. Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1042 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1042/ ) HDFS-8682 . Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #314 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/314/)
          HDFS-8682. Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #314 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/314/ ) HDFS-8682 . Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #309 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/309/)
          HDFS-8682. Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #309 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/309/ ) HDFS-8682 . Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2258 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2258/)
          HDFS-8682. Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2258 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2258/ ) HDFS-8682 . Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2239 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2239/)
          HDFS-8682. Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2239 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2239/ ) HDFS-8682 . Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #301 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/301/)
          HDFS-8682. Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #301 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/301/ ) HDFS-8682 . Should not remove decommissioned node,while calculating the number of live/dead decommissioned node. (Contributed by J. Andreina) (vinayakumarb: rev fdb56f74f38cabb0f94e0781fcedb1594904c026) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          shv Konstantin Shvachko added a comment -

          Committed to branch-2.7.

          Show
          shv Konstantin Shvachko added a comment - Committed to branch-2.7.

            People

            • Assignee:
              andreina J.Andreina
              Reporter:
              andreina J.Andreina
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development