Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8645

Resolve inconsistent code in TestReplicationPolicy between trunk and branch-2

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0
    • Component/s: namenode
    • Labels:
      None
    • Target Version/s:

      Description

        Activity

        Hide
        zhz Zhe Zhang added a comment -

        Thanks Andrew!

        Show
        zhz Zhe Zhang added a comment - Thanks Andrew!
        Hide
        andrew.wang Andrew Wang added a comment -

        Committed to branch-2, thanks for wrapping this up Zhe!

        Show
        andrew.wang Andrew Wang added a comment - Committed to branch-2, thanks for wrapping this up Zhe!
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 8m 22s Pre-patch branch-2 compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 5m 48s There were no new javac warning messages.
        +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 21s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 17s mvn install still works.
        +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
        +1 findbugs 3m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 15s Pre-build of native portion
        +1 hdfs tests 157m 3s Tests passed in hadoop-hdfs.
            180m 16s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741651/HDFS-8645-branch-2.00.patch
        Optional Tests javac unit findbugs checkstyle
        git revision branch-2 / 15b1800
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11466/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11466/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11466/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 8m 22s Pre-patch branch-2 compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 5m 48s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 21s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 17s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 3m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 15s Pre-build of native portion +1 hdfs tests 157m 3s Tests passed in hadoop-hdfs.     180m 16s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741651/HDFS-8645-branch-2.00.patch Optional Tests javac unit findbugs checkstyle git revision branch-2 / 15b1800 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11466/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11466/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11466/console This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        The 2 reported failures are not related (the patch is test-only), and they pass locally.

        Show
        zhz Zhe Zhang added a comment - The 2 reported failures are not related (the patch is test-only), and they pass locally.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 10m 27s Pre-patch branch-2 compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 59s There were no new javac warning messages.
        +1 release audit 0m 27s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 53s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 5m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 1m 37s Pre-build of native portion
        -1 hdfs tests 103m 22s Tests failed in hadoop-hdfs.
            134m 1s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure
        Timed out tests org.apache.hadoop.hdfs.TestEncryptedTransfer



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741651/HDFS-8645-branch-2.00.patch
        Optional Tests javac unit findbugs checkstyle
        git revision branch-2 / 15b1800
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11467/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11467/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11467/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 10m 27s Pre-patch branch-2 compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 59s There were no new javac warning messages. +1 release audit 0m 27s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 53s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 5m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 37s Pre-build of native portion -1 hdfs tests 103m 22s Tests failed in hadoop-hdfs.     134m 1s   Reason Tests Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure Timed out tests org.apache.hadoop.hdfs.TestEncryptedTransfer Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741651/HDFS-8645-branch-2.00.patch Optional Tests javac unit findbugs checkstyle git revision branch-2 / 15b1800 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11467/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11467/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11467/console This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Looking at the diffs between trunk and branch-2, all are refactors except for the following line:

        when(mbc.isUnderConstruction()).thenReturn(true);
        

        It should also be added since mbc is UC in this test case.

        So the patch simply copies over the trunk file into branch-2.

        Show
        zhz Zhe Zhang added a comment - Looking at the diffs between trunk and branch-2, all are refactors except for the following line: when(mbc.isUnderConstruction()).thenReturn( true ); It should also be added since mbc is UC in this test case. So the patch simply copies over the trunk file into branch-2.

          People

          • Assignee:
            zhz Zhe Zhang
            Reporter:
            zhz Zhe Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development