Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8595

TestCommitBlockSynchronization fails in branch-2.7

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 2.7.1, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Mock-based TestCommitBlockSynchronization fails in branch-2.7 with NPE due to a log statement dereferencing a null object.

      1. HDFS-8595.01.patch
        1.0 kB
        Arpit Agarwal

        Issue Links

          Activity

          Hide
          arpitagarwal Arpit Agarwal added a comment -

          The logging change that exposed it is not there in trunk.

          We can fix the test in trunk however, it is harmless.

          Show
          arpitagarwal Arpit Agarwal added a comment - The logging change that exposed it is not there in trunk. We can fix the test in trunk however, it is harmless.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Patch to make the mock object return a non-null when getBlocks() is invoked.

          Show
          arpitagarwal Arpit Agarwal added a comment - Patch to make the mock object return a non-null when getBlocks() is invoked.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 8m 20s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 43s There were no new javac warning messages.
          +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 14s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 38s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 3m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 1m 19s Pre-build of native portion
          -1 hdfs tests 77m 46s Tests failed in hadoop-hdfs.
              103m 12s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure
          Timed out tests org.apache.hadoop.hdfs.TestSetrepIncreasing
            org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12739465/HDFS-8595.01.patch
          Optional Tests javac unit findbugs checkstyle
          git revision trunk / b8341f1
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11341/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11341/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11341/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 8m 20s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 43s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 14s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 1m 19s Pre-build of native portion -1 hdfs tests 77m 46s Tests failed in hadoop-hdfs.     103m 12s   Reason Tests Failed unit tests hadoop.hdfs.TestReplaceDatanodeOnFailure Timed out tests org.apache.hadoop.hdfs.TestSetrepIncreasing   org.apache.hadoop.hdfs.server.namenode.ha.TestEditLogsDuringFailover Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739465/HDFS-8595.01.patch Optional Tests javac unit findbugs checkstyle git revision trunk / b8341f1 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11341/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11341/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11341/console This message was automatically generated.
          Hide
          jnp Jitendra Nath Pandey added a comment -

          +1

          Show
          jnp Jitendra Nath Pandey added a comment - +1
          Hide
          arpitagarwal Arpit Agarwal added a comment - - edited

          Thanks Jitendra Nath Pandey, committed for 2.7.1.

          [Jenkins test failures were unrelated]

          Show
          arpitagarwal Arpit Agarwal added a comment - - edited Thanks Jitendra Nath Pandey , committed for 2.7.1. [Jenkins test failures were unrelated]
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8016 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8016/)
          HDFS-8595. TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8016 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8016/ ) HDFS-8595 . TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #229 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/229/)
          HDFS-8595. TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #229 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/229/ ) HDFS-8595 . TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #959 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/959/)
          HDFS-8595. TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #959 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/959/ ) HDFS-8595 . TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #218 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/218/)
          HDFS-8595. TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #218 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/218/ ) HDFS-8595 . TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2157 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2157/)
          HDFS-8595. TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2157 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2157/ ) HDFS-8595 . TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #227 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/227/)
          HDFS-8595. TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #227 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/227/ ) HDFS-8595 . TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2175 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2175/)
          HDFS-8595. TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2175 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2175/ ) HDFS-8595 . TestCommitBlockSynchronization fails in branch-2.7. (Patch applies to all branches). (Contributed by Arpit Agarwal) (arp: rev 4c5da9bd94baca4adc7200272bc2de534c39135c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCommitBlockSynchronization.java
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks for the contribution Arpit Agarwal and Jitendra Nath Pandey. I'm adding a link to HDFS-8522 which caused this test failure.

          Show
          xiaochen Xiao Chen added a comment - Thanks for the contribution Arpit Agarwal and Jitendra Nath Pandey . I'm adding a link to HDFS-8522 which caused this test failure.

            People

            • Assignee:
              arpitagarwal Arpit Agarwal
              Reporter:
              arpitagarwal Arpit Agarwal
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development