Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8582

Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings

    Details

    • Target Version/s:
    • Release Note:
      Add a new option "properties" to the "dfsadmin -reconfig" command to get a list of reconfigurable properties.

      Description

      When running a DN reconfig to hotswap some drives, it spits out this output:

      $ hdfs dfsadmin -reconfig datanode localhost:9023 status
      15/06/09 14:58:10 WARN util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
      Reconfiguring status for DataNode[localhost:9023]: started at Tue Jun 09 14:57:37 PDT 2015 and finished at Tue Jun 09 14:57:56 PDT 2015.
      FAILED: Change property rpc.engine.org.apache.hadoop.hdfs.protocolPB.ClientDatanodeProtocolPB
              From: "org.apache.hadoop.ipc.ProtobufRpcEngine"
              To: ""
              Error: Property rpc.engine.org.apache.hadoop.hdfs.protocolPB.ClientDatanodeProtocolPB is not reconfigurable.
      FAILED: Change property mapreduce.client.genericoptionsparser.used
              From: "true"
              To: ""
              Error: Property mapreduce.client.genericoptionsparser.used is not reconfigurable.
      FAILED: Change property rpc.engine.org.apache.hadoop.ipc.ProtocolMetaInfoPB
              From: "org.apache.hadoop.ipc.ProtobufRpcEngine"
              To: ""
              Error: Property rpc.engine.org.apache.hadoop.ipc.ProtocolMetaInfoPB is not reconfigurable.
      SUCCESS: Change property dfs.datanode.data.dir
              From: "file:///data/1/user/dfs"
              To: "file:///data/1/user/dfs,file:///data/2/user/dfs"
      FAILED: Change property dfs.datanode.startup
              From: "REGULAR"
              To: ""
              Error: Property dfs.datanode.startup is not reconfigurable.
      FAILED: Change property rpc.engine.org.apache.hadoop.hdfs.protocolPB.InterDatanodeProtocolPB
              From: "org.apache.hadoop.ipc.ProtobufRpcEngine"
              To: ""
              Error: Property rpc.engine.org.apache.hadoop.hdfs.protocolPB.InterDatanodeProtocolPB is not reconfigurable.
      FAILED: Change property rpc.engine.org.apache.hadoop.hdfs.protocolPB.DatanodeProtocolPB
              From: "org.apache.hadoop.ipc.ProtobufRpcEngine"
              To: ""
              Error: Property rpc.engine.org.apache.hadoop.hdfs.protocolPB.DatanodeProtocolPB is not reconfigurable.
      FAILED: Change property rpc.engine.org.apache.hadoop.tracing.TraceAdminProtocolPB
              From: "org.apache.hadoop.ipc.ProtobufRpcEngine"
              To: ""
              Error: Property rpc.engine.org.apache.hadoop.tracing.TraceAdminProtocolPB is not reconfigurable.
      

      These failed messages are spurious and should not be shown.

      1. HDFS-8582.000.patch
        7 kB
        Lei (Eddy) Xu
      2. HDFS-8582.001.patch
        21 kB
        Lei (Eddy) Xu
      3. HDFS-8582.002.patch
        22 kB
        Lei (Eddy) Xu
      4. HDFS-8582.003.patch
        24 kB
        Lei (Eddy) Xu
      5. HDFS-8582.004.patch
        25 kB
        Lei (Eddy) Xu

        Activity

        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        DFSAdmin does not show a reconfigure failure if it is a "not reconfigurable" property.

        Show
        eddyxu Lei (Eddy) Xu added a comment - DFSAdmin does not show a reconfigure failure if it is a "not reconfigurable" property.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 9s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 41s There were no new javac warning messages.
        +1 javadoc 9m 47s There were no new javadoc warning messages.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 17s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 18s Pre-build of native portion
        +1 hdfs tests 161m 15s Tests passed in hadoop-hdfs.
            208m 15s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12739130/HDFS-8582.000.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 587309b
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11314/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11314/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11314/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 9s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 9m 47s There were no new javadoc warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 17s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 18s Pre-build of native portion +1 hdfs tests 161m 15s Tests passed in hadoop-hdfs.     208m 15s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739130/HDFS-8582.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 587309b hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11314/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11314/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11314/console This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Parsing the error message is a little gross. Any alternative available? Also, any reason we quash on the client-side instead of the server-side?

        The other thing I don't understand is why these few unset keys spit out errors, while all the other unset keys do not.

        Show
        andrew.wang Andrew Wang added a comment - Parsing the error message is a little gross. Any alternative available? Also, any reason we quash on the client-side instead of the server-side? The other thing I don't understand is why these few unset keys spit out errors, while all the other unset keys do not.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks a lot for the great suggestions, Andrew Wang.

        Also, any reason we quash on the client-side instead of the server-side?

        The original thoughts were that if user intent to use this command for other purpose, other than hot swapping today, which is the only property that is supported to reconfig, we'd like let user know. In the updated patch, these "not reconfigurable" errors are ignored from ReconfigreBase.

        Also, I added a dfsadmin -reconfig listAllowed command to get a whitelist of properties that are supported.

        The other thing I don't understand is why these few unset keys spit out errors, while all the other unset keys do not.

        DataNode's Configuration object is actually HdfsConfiguration, which sets a few default values for certain keys. But the reconfiguration framework used here just set the missing keys with empty / None values. Thus there are differences.

        Would you mind give another review? Thanks much.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks a lot for the great suggestions, Andrew Wang . Also, any reason we quash on the client-side instead of the server-side? The original thoughts were that if user intent to use this command for other purpose, other than hot swapping today, which is the only property that is supported to reconfig, we'd like let user know. In the updated patch, these "not reconfigurable" errors are ignored from ReconfigreBase . Also, I added a dfsadmin -reconfig listAllowed command to get a whitelist of properties that are supported. The other thing I don't understand is why these few unset keys spit out errors, while all the other unset keys do not. DataNode's Configuration object is actually HdfsConfiguration , which sets a few default values for certain keys. But the reconfiguration framework used here just set the missing keys with empty / None values. Thus there are differences. Would you mind give another review? Thanks much.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 19m 16s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        -1 javac 7m 28s The applied patch generated 1 additional warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 3m 19s The applied patch generated 10 new checkstyle issues (total was 392, now 397).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 5m 9s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 common tests 22m 2s Tests failed in hadoop-common.
        -1 hdfs tests 161m 45s Tests failed in hadoop-hdfs.
            231m 8s  



        Reason Tests
        Failed unit tests hadoop.conf.TestReconfiguration
          hadoop.hdfs.tools.TestDFSAdmin



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12739425/HDFS-8582.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / eef7b50
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/11339/artifact/patchprocess/diffJavacWarnings.txt
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11339/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11339/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11339/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11339/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11339/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 16s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. -1 javac 7m 28s The applied patch generated 1 additional warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 3m 19s The applied patch generated 10 new checkstyle issues (total was 392, now 397). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 5m 9s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 22m 2s Tests failed in hadoop-common. -1 hdfs tests 161m 45s Tests failed in hadoop-hdfs.     231m 8s   Reason Tests Failed unit tests hadoop.conf.TestReconfiguration   hadoop.hdfs.tools.TestDFSAdmin Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739425/HDFS-8582.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / eef7b50 javac https://builds.apache.org/job/PreCommit-HDFS-Build/11339/artifact/patchprocess/diffJavacWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11339/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11339/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11339/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11339/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11339/console This message was automatically generated.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Updated the patch to address failure tests and checkstyle warnings.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Updated the patch to address failure tests and checkstyle warnings.
        Hide
        cmccabe Colin P. McCabe added a comment -

        I think it's a good idea to have a list of reconfigurable properties available... the new listAllowed command is nice. Rather than calling it "listAllowed" (which suggests a permission issue), why not just call it "properties"? The first part of the command is dfs dfsadmin -reconfig <datanode|...> <host:ipc_port> so it will be obvious that the properties pertain to reconfiguration.

        GetReconfigurationAllowedPropertiesResponse: should be GetReconfigurablePropertiesResponse. Similar with Request, etc. etc.

        DataNode's Configuration object is actually HdfsConfiguration, which sets a few default values for certain keys. But the reconfiguration framework used here just set the missing keys with empty / None values. Thus there are differences.

        When I type dfs dfsadmin -reconfig <datanode|...> <host:ipc_port> the reconfiguration framework knows that I am reconfiguring a datanode. So it should use the correct defaults for the datanode. This seems like a much cleaner solution than hacking around this by suppressing certain valid messages at the client.

        Show
        cmccabe Colin P. McCabe added a comment - I think it's a good idea to have a list of reconfigurable properties available... the new listAllowed command is nice. Rather than calling it "listAllowed" (which suggests a permission issue), why not just call it "properties"? The first part of the command is dfs dfsadmin -reconfig <datanode|...> <host:ipc_port> so it will be obvious that the properties pertain to reconfiguration. GetReconfigurationAllowedPropertiesResponse : should be GetReconfigurablePropertiesResponse . Similar with Request, etc. etc. DataNode's Configuration object is actually HdfsConfiguration, which sets a few default values for certain keys. But the reconfiguration framework used here just set the missing keys with empty / None values. Thus there are differences. When I type dfs dfsadmin -reconfig <datanode|...> <host:ipc_port> the reconfiguration framework knows that I am reconfiguring a datanode. So it should use the correct defaults for the datanode. This seems like a much cleaner solution than hacking around this by suppressing certain valid messages at the client.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 19m 25s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 27s There were no new javac warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 3m 21s The applied patch generated 8 new checkstyle issues (total was 392, now 395).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 5m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 23m 2s Tests passed in hadoop-common.
        +1 hdfs tests 161m 31s Tests passed in hadoop-hdfs.
            232m 0s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12739661/HDFS-8582.002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 32ffda1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11360/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11360/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11360/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11360/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11360/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 25s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 27s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 3m 21s The applied patch generated 8 new checkstyle issues (total was 392, now 395). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 5m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 2s Tests passed in hadoop-common. +1 hdfs tests 161m 31s Tests passed in hadoop-hdfs.     232m 0s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739661/HDFS-8582.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 32ffda1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11360/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11360/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11360/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11360/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11360/console This message was automatically generated.
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks a lot for the reviews, Colin P. McCabe. I made the following changes based on your comments:

        • listAllowed to properties subcommand.
        • GetReconfigurationAllowedPropertiesResponse to ListReconfigurablePropertiesResponse. The reason that I did not change it to GetReconfigurablePropertiesResponse is that ReconfiguableBase has a #getReconfigurableProperties() function, thus I could not use the same name in ClientProtocol. Naming the protobuf to List... makes it consistent with ClientDatanodeProtocol.

        So it should use the correct defaults for the datanode.

        Currently, the following properties that are different

        rpc.engine.org.apache.hadoop.hdfs.protocolPB.DatanodeProtocolPB
        rpc.engine.org.apache.hadoop.hdfs.protocolPB.InterDatanodeProtocolPB
        rpc.engine.org.apache.hadoop.ipc.ProtocolMetaInfoPB
        rpc.engine.org.apache.hadoop.hdfs.protocolPB.ClientDatanodeProtocolPB
        rpc.engine.org.apache.hadoop.tracing.TraceAdminProtocolPB
        mapreduce.client.genericoptionsparser.used
        dfs.datanode.startup
        

        rpc.engine.* are set in DataNode#initIpcServer, dfs.datanode.setup is set in DataNode#parseArguments() which is in main(), and mapreduce.client.genericoptionsparser.used is set in GenericOptionsParser. It might not clean to simply set default values of these properties in DataNode#getNewConf(), because the further code changes might break the consistency between them. So for now, I let ReconfigureBase ignore non-reconfigurable properties and put them in log. User should use -reconfig properties to check whether a property is supported first.

        Colin P. McCabe What would you think?

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks a lot for the reviews, Colin P. McCabe . I made the following changes based on your comments: listAllowed to properties subcommand. GetReconfigurationAllowedPropertiesResponse to ListReconfigurablePropertiesResponse . The reason that I did not change it to GetReconfigurablePropertiesResponse is that ReconfiguableBase has a #getReconfigurableProperties() function, thus I could not use the same name in ClientProtocol . Naming the protobuf to List... makes it consistent with ClientDatanodeProtocol . So it should use the correct defaults for the datanode. Currently, the following properties that are different rpc.engine.org.apache.hadoop.hdfs.protocolPB.DatanodeProtocolPB rpc.engine.org.apache.hadoop.hdfs.protocolPB.InterDatanodeProtocolPB rpc.engine.org.apache.hadoop.ipc.ProtocolMetaInfoPB rpc.engine.org.apache.hadoop.hdfs.protocolPB.ClientDatanodeProtocolPB rpc.engine.org.apache.hadoop.tracing.TraceAdminProtocolPB mapreduce.client.genericoptionsparser.used dfs.datanode.startup rpc.engine.* are set in DataNode#initIpcServer , dfs.datanode.setup is set in DataNode#parseArguments() which is in main() , and mapreduce.client.genericoptionsparser.used is set in GenericOptionsParser . It might not clean to simply set default values of these properties in DataNode#getNewConf() , because the further code changes might break the consistency between them. So for now, I let ReconfigureBase ignore non-reconfigurable properties and put them in log. User should use -reconfig properties to check whether a property is supported first. Colin P. McCabe What would you think?
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 19m 28s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 30s There were no new javac warning messages.
        +1 javadoc 9m 35s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 32s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 37s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 5m 8s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 45s Tests passed in hadoop-common.
        +1 hdfs tests 163m 40s Tests passed in hadoop-hdfs.
            233m 14s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12739983/HDFS-8582.003.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / fbf55dc
        hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11377/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11377/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11377/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11377/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 28s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 32s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 5m 8s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 45s Tests passed in hadoop-common. +1 hdfs tests 163m 40s Tests passed in hadoop-hdfs.     233m 14s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739983/HDFS-8582.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fbf55dc hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11377/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11377/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11377/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11377/console This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Thanks, Eddy. Looks good.

          public Configuration getNewConf() {
        

        Should this be protected rather than public? Also, it would make sense for this to be abstract in the base class.

          private static final List<String> reconfigurableProperties = ...
        

        Should be ALL_CAPS with underscores to indicate a constant that can't be changed

                "\tStarts reconfiguration or gets the status of an ongoing reconfiguration.\n" +
                "\tIt also displays the properties that are supported for reconfiguration.\n" +
        

        This seems a bit confusing. How about "Starts or stops a reconfiguration operation, or gets a list of reconfigurable properties."

        +                "SUCCESS: Change property %s%n\tFrom: \"%s\"%n\tTo: \"%s\"%n",
        

        Changed, not change

        +1 pending those changes

        Show
        cmccabe Colin P. McCabe added a comment - Thanks, Eddy. Looks good. public Configuration getNewConf() { Should this be protected rather than public? Also, it would make sense for this to be abstract in the base class. private static final List< String > reconfigurableProperties = ... Should be ALL_CAPS with underscores to indicate a constant that can't be changed "\tStarts reconfiguration or gets the status of an ongoing reconfiguration.\n" + "\tIt also displays the properties that are supported for reconfiguration.\n" + This seems a bit confusing. How about "Starts or stops a reconfiguration operation, or gets a list of reconfigurable properties." + "SUCCESS: Change property %s%n\tFrom: \" %s\ "%n\tTo: \" %s\ "%n" , Changed, not change +1 pending those changes
        Hide
        eddyxu Lei (Eddy) Xu added a comment -

        Thanks for these suggestions, Colin P. McCabe. Here is the updated patch.

        Show
        eddyxu Lei (Eddy) Xu added a comment - Thanks for these suggestions, Colin P. McCabe . Here is the updated patch.
        Hide
        cmccabe Colin P. McCabe added a comment -

        +1. Thanks, Eddy.

        Show
        cmccabe Colin P. McCabe added a comment - +1. Thanks, Eddy.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 19m 55s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 42s There were no new javac warning messages.
        +1 javadoc 9m 54s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 35s There were no new checkstyle issues.
        -1 whitespace 0m 2s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 39s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 5m 11s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 25s Tests passed in hadoop-common.
        -1 hdfs tests 77m 40s Tests failed in hadoop-hdfs.
            148m 2s  



        Reason Tests
        Failed unit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache
        Timed out tests org.apache.hadoop.hdfs.TestDatanodeDeath
          org.apache.hadoop.hdfs.TestRenameWhileOpen
          org.apache.hadoop.hdfs.TestRollingUpgrade
          org.apache.hadoop.hdfs.TestFileCreationClient
          org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12740567/HDFS-8582.004.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 55278c0
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11418/artifact/patchprocess/whitespace.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11418/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11418/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11418/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11418/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 55s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 42s There were no new javac warning messages. +1 javadoc 9m 54s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 35s There were no new checkstyle issues. -1 whitespace 0m 2s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 39s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 5m 11s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 25s Tests passed in hadoop-common. -1 hdfs tests 77m 40s Tests failed in hadoop-hdfs.     148m 2s   Reason Tests Failed unit tests hadoop.hdfs.shortcircuit.TestShortCircuitCache Timed out tests org.apache.hadoop.hdfs.TestDatanodeDeath   org.apache.hadoop.hdfs.TestRenameWhileOpen   org.apache.hadoop.hdfs.TestRollingUpgrade   org.apache.hadoop.hdfs.TestFileCreationClient   org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12740567/HDFS-8582.004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 55278c0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11418/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11418/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11418/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11418/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11418/console This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8040 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8040/)
        HDFS-8582. Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8040 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8040/ ) HDFS-8582 . Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #964 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/964/)
        HDFS-8582. Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #964 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/964/ ) HDFS-8582 . Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #234 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/234/)
        HDFS-8582. Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #234 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/234/ ) HDFS-8582 . Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2162 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2162/)
        HDFS-8582. Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2162 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2162/ ) HDFS-8582 . Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #223 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/223/)
        HDFS-8582. Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #223 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/223/ ) HDFS-8582 . Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #232 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/232/)
        HDFS-8582. Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #232 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/232/ ) HDFS-8582 . Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45) hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2180 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2180/)
        HDFS-8582. Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2180 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2180/ ) HDFS-8582 . Support getting a list of reconfigurable config properties and do not generate spurious reconfig warnings (Lei (Eddy) Xu via Colin P. McCabe) (cmccabe: rev d112d183242f447d4b742139f3a4ea531a997f45) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestReconfiguration.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/proto/ClientDatanodeProtocol.proto hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ReconfigurableBase.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolServerSideTranslatorPB.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientDatanodeProtocol.java

          People

          • Assignee:
            eddyxu Lei (Eddy) Xu
            Reporter:
            eddyxu Lei (Eddy) Xu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development