Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Update hdfs usage with missing options (fetchdt and debug)

       ./hdfs debug
      Usage: hdfs debug <command> [arguments]
      
      verify [-meta <metadata-file>] [-block <block-file>]
      recoverLease [-path <path>] [-retries <num-retries>]
      
      1. HDFS-8579.2.patch
        0.8 kB
        J.Andreina
      2. HDFS-8579.3.patch
        0.8 kB
        J.Andreina
      3. HDFS-8579-branch-2.7-1.patch
        1 kB
        J.Andreina
      4. HDFS-8579-branch-2-3.patch
        2 kB
        Vinayakumar B
      5. HDFS-8579-trunk-1.patch
        0.8 kB
        J.Andreina

        Activity

        Hide
        andreina J.Andreina added a comment -

        Please review the patch.

        Show
        andreina J.Andreina added a comment - Please review the patch.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 15m 3s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 40s There were no new javac warning messages.
        +1 javadoc 9m 46s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 shellcheck 0m 6s There were no new shellcheck (v0.3.3) issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 native 3m 17s Pre-build of native portion
        +1 hdfs tests 159m 26s Tests passed in hadoop-hdfs.
            197m 47s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742113/HDFS-8579-trunk-1.patch
        Optional Tests javadoc javac unit shellcheck
        git revision trunk / 8ef07f7
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11498/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11498/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11498/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 3s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 40s There were no new javac warning messages. +1 javadoc 9m 46s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 shellcheck 0m 6s There were no new shellcheck (v0.3.3) issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 native 3m 17s Pre-build of native portion +1 hdfs tests 159m 26s Tests passed in hadoop-hdfs.     197m 47s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742113/HDFS-8579-trunk-1.patch Optional Tests javadoc javac unit shellcheck git revision trunk / 8ef07f7 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11498/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11498/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11498/console This message was automatically generated.
        Hide
        andreina J.Andreina added a comment -

        Testcase is not required as it is HDFS command usage updation

        Show
        andreina J.Andreina added a comment - Testcase is not required as it is HDFS command usage updation
        Hide
        vinayrpet Vinayakumar B added a comment -
        echo "  debug                validate blocks and invoke recover lease."

        'hdfs' commands are in alphabetical order. Need to insert this in correct place.

        Show
        vinayrpet Vinayakumar B added a comment - echo " debug validate blocks and invoke recover lease." 'hdfs' commands are in alphabetical order. Need to insert this in correct place.
        Hide
        andreina J.Andreina added a comment -

        Thanks Vinayakumar B for reviewing the patch.
        Updated the patch as per your comments
        Please review.

        Show
        andreina J.Andreina added a comment - Thanks Vinayakumar B for reviewing the patch. Updated the patch as per your comments Please review.
        Hide
        vinayrpet Vinayakumar B added a comment - - edited

        Just before committing, thought it would be better if generic usage is mentioned. Like below.
        "Run a Debug Admin to execute HDFS debug commands"

        Even if some more commands are added in future, this message need not be changed.

        J.Andreina, Can you update the patch as mentioned?

        Show
        vinayrpet Vinayakumar B added a comment - - edited Just before committing, thought it would be better if generic usage is mentioned. Like below. "Run a Debug Admin to execute HDFS debug commands" Even if some more commands are added in future, this message need not be changed. J.Andreina , Can you update the patch as mentioned?
        Hide
        andreina J.Andreina added a comment -

        Vinayakumar B , updated the patch as per your comments .
        Please review.

        Show
        andreina J.Andreina added a comment - Vinayakumar B , updated the patch as per your comments . Please review.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk and branch-2.

        Resolved a little conflict in branch-2, as everything is not in sorted order in branch-2.

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2. Resolved a little conflict in branch-2, as everything is not in sorted order in branch-2.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Attaching the branch-2 committed patch for reference.

        Show
        vinayrpet Vinayakumar B added a comment - Attaching the branch-2 committed patch for reference.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Thanks J.Andreina for the contribution.

        Show
        vinayrpet Vinayakumar B added a comment - Thanks J.Andreina for the contribution.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8091 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8091/)
        HDFS-8579. Update HDFS usage with missing options (Contributed by J.Andreina) (vinayakumarb: rev 77588e1d32cc465e6b0699bb3564a4c7c6df16fa)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8091 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8091/ ) HDFS-8579 . Update HDFS usage with missing options (Contributed by J.Andreina) (vinayakumarb: rev 77588e1d32cc465e6b0699bb3564a4c7c6df16fa) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 42s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 34s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 shellcheck 0m 5s There were no new shellcheck (v0.3.3) issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 native 3m 14s Pre-build of native portion
        -1 hdfs tests 163m 48s Tests failed in hadoop-hdfs.
            201m 33s  



        Reason Tests
        Failed unit tests hadoop.hdfs.web.TestWebHdfsFileSystemContract
          hadoop.hdfs.TestHDFSFileSystemContract



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742727/HDFS-8579.2.patch
        Optional Tests javadoc javac unit shellcheck
        git revision trunk / d3797f9
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11546/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11546/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11546/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 42s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 shellcheck 0m 5s There were no new shellcheck (v0.3.3) issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 163m 48s Tests failed in hadoop-hdfs.     201m 33s   Reason Tests Failed unit tests hadoop.hdfs.web.TestWebHdfsFileSystemContract   hadoop.hdfs.TestHDFSFileSystemContract Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742727/HDFS-8579.2.patch Optional Tests javadoc javac unit shellcheck git revision trunk / d3797f9 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11546/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11546/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11546/console This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/242/)
        HDFS-8579. Update HDFS usage with missing options (Contributed by J.Andreina) (vinayakumarb: rev 77588e1d32cc465e6b0699bb3564a4c7c6df16fa)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/242/ ) HDFS-8579 . Update HDFS usage with missing options (Contributed by J.Andreina) (vinayakumarb: rev 77588e1d32cc465e6b0699bb3564a4c7c6df16fa) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/)
        HDFS-8579. Update HDFS usage with missing options (Contributed by J.Andreina) (vinayakumarb: rev 77588e1d32cc465e6b0699bb3564a4c7c6df16fa)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/ ) HDFS-8579 . Update HDFS usage with missing options (Contributed by J.Andreina) (vinayakumarb: rev 77588e1d32cc465e6b0699bb3564a4c7c6df16fa) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2172/)
        HDFS-8579. Update HDFS usage with missing options (Contributed by J.Andreina) (vinayakumarb: rev 77588e1d32cc465e6b0699bb3564a4c7c6df16fa)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2172/ ) HDFS-8579 . Update HDFS usage with missing options (Contributed by J.Andreina) (vinayakumarb: rev 77588e1d32cc465e6b0699bb3564a4c7c6df16fa) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/233/)
        HDFS-8579. Update HDFS usage with missing options (Contributed by J.Andreina) (vinayakumarb: rev 77588e1d32cc465e6b0699bb3564a4c7c6df16fa)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/233/ ) HDFS-8579 . Update HDFS usage with missing options (Contributed by J.Andreina) (vinayakumarb: rev 77588e1d32cc465e6b0699bb3564a4c7c6df16fa) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            andreina J.Andreina
            Reporter:
            andreina J.Andreina
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development