Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-856

Hardcoded replication level for new files in fuse-dfs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: fuse-dfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      fuse-dfs hdfsOpenFile replicas

      Description

      In fuse-dfs, the number of replicas is always hardcoded to 3 in the arguments to hdfsOpenFile. We should use the setting in the hadoop configuration instead.

      1. HADOOP-856.patch
        1 kB
        Brian Bockelman

        Activity

        Brian Bockelman created issue -
        Hide
        Brian Bockelman added a comment -

        This patch changes the # of replicas argument in hdfsOpenFile to 0, which the libhdfs documentation says should be whatever the default is for the Hadoop configuration.

        Show
        Brian Bockelman added a comment - This patch changes the # of replicas argument in hdfsOpenFile to 0, which the libhdfs documentation says should be whatever the default is for the Hadoop configuration.
        Brian Bockelman made changes -
        Field Original Value New Value
        Attachment HADOOP-856.patch [ 12429027 ]
        Hide
        Brian Bockelman added a comment -

        Submitting patch to Hudson. I do not believe a test case is needed because of how straightforward the fix is and the fact that fuse-dfs is in contrib/

        Show
        Brian Bockelman added a comment - Submitting patch to Hudson. I do not believe a test case is needed because of how straightforward the fix is and the fact that fuse-dfs is in contrib/
        Brian Bockelman made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12429027/HADOOP-856.patch
        against trunk revision 894233.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/163/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/163/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/163/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/163/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12429027/HADOOP-856.patch against trunk revision 894233. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/163/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/163/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/163/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/163/console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        +1 Patch looks good.

        Show
        Eli Collins added a comment - +1 Patch looks good.
        Hide
        Eli Collins added a comment -

        Forgot to mention that I ran ant test-c++-libhdfs with your patch and it passed.

        Show
        Eli Collins added a comment - Forgot to mention that I ran ant test-c++-libhdfs with your patch and it passed.
        Hide
        Eli Collins added a comment -

        test-c++-libhdfs doesn't cover fuse so actually it shouldn't fail, TestFuseDFS would cover this though it's not currently running (HDFS-780). I tried this patch locally and it worked.

        Show
        Eli Collins added a comment - test-c++-libhdfs doesn't cover fuse so actually it shouldn't fail, TestFuseDFS would cover this though it's not currently running ( HDFS-780 ). I tried this patch locally and it worked.
        Hide
        Tom White added a comment -

        I've just committed this. Thanks Brian!

        Show
        Tom White added a comment - I've just committed this. Thanks Brian!
        Tom White made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Assignee Brian Bockelman [ bockelman ]
        Fix Version/s 0.22.0 [ 12314241 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #210 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/210/)
        . Hardcoded replication level for new files in fuse-dfs. Contributed by Brian Bockelman.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #210 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/210/ ) . Hardcoded replication level for new files in fuse-dfs. Contributed by Brian Bockelman.
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #146 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/146/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #146 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/146/ )
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #302 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/302/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #302 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/302/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #275 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/275/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #275 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/275/ )
        Tom White made changes -
        Fix Version/s 0.21.0 [ 12314046 ]
        Fix Version/s 0.22.0 [ 12314241 ]
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Brian Bockelman
            Reporter:
            Brian Bockelman
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development