[HDFS-8550] Erasure Coding: Fix FindBugs Multithreaded correctness Warning

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: HDFS-7285
• Target Version/s: HDFS-7285
• Hadoop Flags: Reviewed
• Assignee: Rakesh Radhakrishnan Assign to me
• Reporter: Rakesh Radhakrishnan
• Created: 06/Jun/15 04:45
• Updated: 30/Sep/15 19:38
• Resolved: 18/Sep/15 18:06

Description

Please find the findbug warnings report

1)

Bug type IS2_INCONSISTENT_SYNC (click for details) 
In class org.apache.hadoop.hdfs.DFSStripedInputStream
Field org.apache.hadoop.hdfs.DFSStripedInputStream.curStripeBuf
Synchronized 90% of the time
Unsynchronized access at DFSStripedInputStream.java:[line 829]
Synchronized access at DFSStripedInputStream.java:[line 183]
Synchronized access at DFSStripedInputStream.java:[line 186]
Synchronized access at DFSStripedInputStream.java:[line 184]
Synchronized access at DFSStripedInputStream.java:[line 382]
Synchronized access at DFSStripedInputStream.java:[line 460]
Synchronized access at DFSStripedInputStream.java:[line 461]
Synchronized access at DFSStripedInputStream.java:[line 461]
Synchronized access at DFSStripedInputStream.java:[line 285]
Synchronized access at DFSStripedInputStream.java:[line 297]
Synchronized access at DFSStripedInputStream.java:[line 298]

2)

Unread field: org.apache.hadoop.hdfs.DFSStripedInputStream$BlockReaderInfo.targetBlock
Bug type URF_UNREAD_FIELD (click for details) 
In class org.apache.hadoop.hdfs.DFSStripedInputStream$BlockReaderInfo
Field org.apache.hadoop.hdfs.DFSStripedInputStream$BlockReaderInfo.targetBlock
At DFSStripedInputStream.java:[line 126]

3)

Unchecked/unconfirmed cast from org.apache.hadoop.hdfs.protocol.LocatedBlock to org.apache.hadoop.hdfs.protocol.LocatedStripedBlock in org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.setBlockToken(LocatedBlock, BlockTokenIdentifier$AccessMode)
Bug type BC_UNCONFIRMED_CAST (click for details) 
In class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager
In method org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.setBlockToken(LocatedBlock, BlockTokenIdentifier$AccessMode)
Actual type org.apache.hadoop.hdfs.protocol.LocatedBlock
Expected org.apache.hadoop.hdfs.protocol.LocatedStripedBlock
Value loaded from b
At BlockManager.java:[line 974]

4)

Result of integer multiplication cast to long in org.apache.hadoop.hdfs.util.StripedBlockUtil.divideOneStripe(ErasureCodingPolicy, int, LocatedStripedBlock, long, long, ByteBuffer)
Bug type ICAST_INTEGER_MULTIPLY_CAST_TO_LONG (click for details) 
In class org.apache.hadoop.hdfs.util.StripedBlockUtil
In method org.apache.hadoop.hdfs.util.StripedBlockUtil.divideOneStripe(ErasureCodingPolicy, int, LocatedStripedBlock, long, long, ByteBuffer)
At StripedBlockUtil.java:[line 375]