[HDFS-8546] Use try with resources in DataStorage and Storage

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7.0
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: datanode
• Target Version/s: 2.8.0
• Assignee: Andrew Wang
• Reporter: Andrew Wang
• Created: 05/Jun/15 21:05
• Updated: 30/Aug/16 01:33
• Resolved: 26/Jun/15 00:54

Description

We have some old-style try/finally to close files in DataStorage and Storage, let's update them.

Also a few small cleanups:

• Actually check that tryLock returns a FileLock in isPreUpgradableLayout
• Remove unused parameter from writeProperties
• Add braces for one-line if statements per coding style