Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8521

Add @VisibleForTesting annotation to {{BlockPoolSlice#selectReplicaToDelete}}

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 2.7.1, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Add @VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete

      1. HDFS-8521.001.patch
        1 kB
        Colin P. McCabe

        Issue Links

          Activity

          Hide
          andrew.wang Andrew Wang added a comment -

          +1 pending

          Show
          andrew.wang Andrew Wang added a comment - +1 pending
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 43s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 31s There were no new javac warning messages.
          +1 javadoc 9m 36s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 2m 15s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 14s Pre-build of native portion
          +1 hdfs tests 163m 28s Tests passed in hadoop-hdfs.
              209m 35s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12736982/HDFS-8521.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 03fb5c6
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11211/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11211/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11211/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 43s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 31s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 15s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion +1 hdfs tests 163m 28s Tests passed in hadoop-hdfs.     209m 35s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736982/HDFS-8521.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 03fb5c6 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11211/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11211/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11211/console This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          committed to 2.7.1. Thanks, Andrew Wang.

          Show
          cmccabe Colin P. McCabe added a comment - committed to 2.7.1. Thanks, Andrew Wang .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7946 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7946/)
          HDFS-8521. Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7946 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7946/ ) HDFS-8521 . Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #217 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/217/)
          HDFS-8521. Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #217 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/217/ ) HDFS-8521 . Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #947 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/947/)
          HDFS-8521. Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #947 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/947/ ) HDFS-8521 . Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2163 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2163/)
          HDFS-8521. Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2163 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2163/ ) HDFS-8521 . Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/215/)
          HDFS-8521. Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/215/ ) HDFS-8521 . Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2145 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2145/)
          HDFS-8521. Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2145 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2145/ ) HDFS-8521 . Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #206 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/206/)
          HDFS-8521. Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #206 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/206/ ) HDFS-8521 . Add VisibleForTesting annotation to BlockPoolSlice#selectReplicaToDelete. (cmccabe) (cmccabe: rev 806e407ac8896c4e669dba1fcf86fa5d6fee7c6d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java

            People

            • Assignee:
              cmccabe Colin P. McCabe
              Reporter:
              cmccabe Colin P. McCabe
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development