Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This jira proposes to consolidate truncate() related methods into a single class.

      1. HDFS-8493-001.patch
        33 kB
        Rakesh R
      2. HDFS-8493-002.patch
        33 kB
        Rakesh R
      3. HDFS-8493-003.patch
        33 kB
        Rakesh R
      4. HDFS-8493-004.patch
        33 kB
        Rakesh R
      5. HDFS-8493-005.patch
        34 kB
        Rakesh R
      6. HDFS-8493-006.patch
        34 kB
        Rakesh R
      7. HDFS-8493-007.patch
        33 kB
        Rakesh R
      8. HDFS-8493-007.patch
        33 kB
        Rakesh R
      9. HDFS-8493-009.patch
        35 kB
        Rakesh R
      10. HDFS-8493-010.patch
        34 kB
        Rakesh R
      11. HDFS-8493-011.patch
        34 kB
        Rakesh R

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/233/)
        HDFS-8493. Consolidate truncate() related implementation in a single class. Contributed by Rakesh R. (wheat9: rev d3797f9f3cf502b7bfee3b64c641807b276c6faf)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/233/ ) HDFS-8493 . Consolidate truncate() related implementation in a single class. Contributed by Rakesh R. (wheat9: rev d3797f9f3cf502b7bfee3b64c641807b276c6faf) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2172/)
        HDFS-8493. Consolidate truncate() related implementation in a single class. Contributed by Rakesh R. (wheat9: rev d3797f9f3cf502b7bfee3b64c641807b276c6faf)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2172/ ) HDFS-8493 . Consolidate truncate() related implementation in a single class. Contributed by Rakesh R. (wheat9: rev d3797f9f3cf502b7bfee3b64c641807b276c6faf) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/)
        HDFS-8493. Consolidate truncate() related implementation in a single class. Contributed by Rakesh R. (wheat9: rev d3797f9f3cf502b7bfee3b64c641807b276c6faf)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/ ) HDFS-8493 . Consolidate truncate() related implementation in a single class. Contributed by Rakesh R. (wheat9: rev d3797f9f3cf502b7bfee3b64c641807b276c6faf) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/242/)
        HDFS-8493. Consolidate truncate() related implementation in a single class. Contributed by Rakesh R. (wheat9: rev d3797f9f3cf502b7bfee3b64c641807b276c6faf)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/242/ ) HDFS-8493 . Consolidate truncate() related implementation in a single class. Contributed by Rakesh R. (wheat9: rev d3797f9f3cf502b7bfee3b64c641807b276c6faf) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Haohui Mai for the great help in reviewing and committing the patch.
        Thanks Vinayakumar B for the great help in reviews.

        Show
        rakeshr Rakesh R added a comment - Thanks Haohui Mai for the great help in reviewing and committing the patch. Thanks Vinayakumar B for the great help in reviews.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8090 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8090/)
        HDFS-8493. Consolidate truncate() related implementation in a single class. Contributed by Rakesh R. (wheat9: rev d3797f9f3cf502b7bfee3b64c641807b276c6faf)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8090 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8090/ ) HDFS-8493 . Consolidate truncate() related implementation in a single class. Contributed by Rakesh R. (wheat9: rev d3797f9f3cf502b7bfee3b64c641807b276c6faf) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirTruncateOp.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        wheat9 Haohui Mai added a comment -

        I've committed the patch to trunk and branch-2. Thanks Rakesh R for the contribution.

        Show
        wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Rakesh R for the contribution.
        Hide
        wheat9 Haohui Mai added a comment -

        +1. I'll commit it shortly.

        Show
        wheat9 Haohui Mai added a comment - +1. I'll commit it shortly.
        Hide
        rakeshr Rakesh R added a comment -

        It looks like the test case failure is unrelated to the patch.

        java.net.SocketTimeoutException: Read timed out
        	at java.net.SocketInputStream.socketRead0(Native Method)
        	at java.net.SocketInputStream.read(SocketInputStream.java:152)
        	at java.net.SocketInputStream.read(SocketInputStream.java:122)
        	at java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
        	at java.io.BufferedInputStream.read1(BufferedInputStream.java:275)
        	at java.io.BufferedInputStream.read(BufferedInputStream.java:334)
        	at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:687)
        	at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:633)
        	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1323)
        	at org.apache.hadoop.hdfs.tools.DFSck.doWork(DFSck.java:344)
        	at org.apache.hadoop.hdfs.tools.DFSck.access$000(DFSck.java:73)
        	at org.apache.hadoop.hdfs.tools.DFSck$1.run(DFSck.java:155)
        	at org.apache.hadoop.hdfs.tools.DFSck$1.run(DFSck.java:152)
        	at java.security.AccessController.doPrivileged(Native Method)
        	at javax.security.auth.Subject.doAs(Subject.java:415)
        	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1666)
        	at org.apache.hadoop.hdfs.tools.DFSck.run(DFSck.java:151)
        	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
        	at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
        	at org.apache.hadoop.hdfs.server.namenode.TestFsck.runFsck(TestFsck.java:139)
        	at org.apache.hadoop.hdfs.server.namenode.TestFsck.testFsckSymlink(TestFsck.java:1239)
        
        Show
        rakeshr Rakesh R added a comment - It looks like the test case failure is unrelated to the patch. java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.read(SocketInputStream.java:152) at java.net.SocketInputStream.read(SocketInputStream.java:122) at java.io.BufferedInputStream.fill(BufferedInputStream.java:235) at java.io.BufferedInputStream.read1(BufferedInputStream.java:275) at java.io.BufferedInputStream.read(BufferedInputStream.java:334) at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:687) at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:633) at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1323) at org.apache.hadoop.hdfs.tools.DFSck.doWork(DFSck.java:344) at org.apache.hadoop.hdfs.tools.DFSck.access$000(DFSck.java:73) at org.apache.hadoop.hdfs.tools.DFSck$1.run(DFSck.java:155) at org.apache.hadoop.hdfs.tools.DFSck$1.run(DFSck.java:152) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:415) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1666) at org.apache.hadoop.hdfs.tools.DFSck.run(DFSck.java:151) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84) at org.apache.hadoop.hdfs.server.namenode.TestFsck.runFsck(TestFsck.java:139) at org.apache.hadoop.hdfs.server.namenode.TestFsck.testFsckSymlink(TestFsck.java:1239)
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 17m 38s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 30s There were no new javac warning messages.
        +1 javadoc 9m 42s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 16s The applied patch generated 2 new checkstyle issues (total was 398, now 394).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 15s Pre-build of native portion
        -1 hdfs tests 162m 47s Tests failed in hadoop-hdfs.
            208m 57s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestFsck



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742340/HDFS-8493-011.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 79ed0f9
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11517/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11517/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11517/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11517/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11517/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 38s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 16s The applied patch generated 2 new checkstyle issues (total was 398, now 394). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 15s Pre-build of native portion -1 hdfs tests 162m 47s Tests failed in hadoop-hdfs.     208m 57s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestFsck Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742340/HDFS-8493-011.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 79ed0f9 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/11517/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11517/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11517/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11517/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11517/console This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -
        • I think the test case failures are not related to the patch. I have raised one task HDFS-8642 to fix below failure case.
          The directory /test cannot be deleted since /test is snapshottable and already has snapshots
          
        • It seems HDFS-8656 has modified FSNamesystem.java file. I've re-based the previous patch in latest trunk and attached again.
        Show
        rakeshr Rakesh R added a comment - I think the test case failures are not related to the patch. I have raised one task HDFS-8642 to fix below failure case. The directory /test cannot be deleted since /test is snapshottable and already has snapshots It seems HDFS-8656 has modified FSNamesystem.java file. I've re-based the previous patch in latest trunk and attached again.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741770/HDFS-8493-010.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / fe6c1bd
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11513/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741770/HDFS-8493-010.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fe6c1bd Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11513/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 47s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 30s There were no new javac warning messages.
        +1 javadoc 9m 38s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 12s The applied patch generated 2 new checkstyle issues (total was 399, now 394).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 13s Pre-build of native portion
        -1 hdfs tests 162m 8s Tests failed in hadoop-hdfs.
            208m 20s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestClientReportBadBlock
          hadoop.hdfs.server.namenode.TestFileTruncate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741770/HDFS-8493-010.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 1403b84
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11493/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11493/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11493/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11493/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 47s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 12s The applied patch generated 2 new checkstyle issues (total was 399, now 394). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion -1 hdfs tests 162m 8s Tests failed in hadoop-hdfs.     208m 20s   Reason Tests Failed unit tests hadoop.hdfs.TestClientReportBadBlock   hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741770/HDFS-8493-010.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1403b84 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11493/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11493/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11493/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11493/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 37s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 30s There were no new javac warning messages.
        +1 javadoc 9m 32s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 10s The applied patch generated 2 new checkstyle issues (total was 399, now 394).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 13s Pre-build of native portion
        -1 hdfs tests 159m 41s Tests failed in hadoop-hdfs.
            205m 32s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes
          hadoop.hdfs.TestAppendSnapshotTruncate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741770/HDFS-8493-010.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / a815cc1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11481/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11481/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11481/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11481/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 37s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 32s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 10s The applied patch generated 2 new checkstyle issues (total was 399, now 394). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion -1 hdfs tests 159m 41s Tests failed in hadoop-hdfs.     205m 32s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes   hadoop.hdfs.TestAppendSnapshotTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741770/HDFS-8493-010.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a815cc1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11481/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11481/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11481/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11481/console This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        It seems there were conflicts. Re-based the previous patch in latest trunk code.

        Show
        rakeshr Rakesh R added a comment - It seems there were conflicts. Re-based the previous patch in latest trunk code.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 20s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        -1 javac 1m 36s The patch appears to cause the build to fail.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741672/HDFS-8493-009.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 2df00d5
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11469/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 20s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. -1 javac 1m 36s The patch appears to cause the build to fail. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741672/HDFS-8493-009.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2df00d5 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11469/console This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Haohui Mai. Attached patch addressing the comments.

        Show
        rakeshr Rakesh R added a comment - Thanks Haohui Mai . Attached patch addressing the comments.
        Hide
        wheat9 Haohui Mai added a comment -
        +        res = FSDirTruncateOp.truncate(this, src, newLength, clientName,
        +            clientMachine, mtime, toRemoveBlocks, pc);
        +        stat = dir.getAuditFileInfo(dir.getINodesInPath4Write(src, false));
        

        dir.getINodesInPath4Write() needs to be in the fsd lock. The easiest way to change is to make FSDirTruncateOp.truncate() returns a object that contains both the results and the audit file info. For example,

        static class TruncateResult {
          final boolean result;
          final HdfsStatus stat;
          ...
        }
        
        Show
        wheat9 Haohui Mai added a comment - + res = FSDirTruncateOp.truncate( this , src, newLength, clientName, + clientMachine, mtime, toRemoveBlocks, pc); + stat = dir.getAuditFileInfo(dir.getINodesInPath4Write(src, false )); dir.getINodesInPath4Write() needs to be in the fsd lock. The easiest way to change is to make FSDirTruncateOp.truncate() returns a object that contains both the results and the audit file info. For example, static class TruncateResult { final boolean result; final HdfsStatus stat; ... }
        Hide
        rakeshr Rakesh R added a comment -

        BTW, in the latest patch I have modified the resolution logic by keeping it under the fsd lock. It would be great to see the feedback about this. Thanks!

        Show
        rakeshr Rakesh R added a comment - BTW, in the latest patch I have modified the resolution logic by keeping it under the fsd lock. It would be great to see the feedback about this. Thanks!
        Hide
        rakeshr Rakesh R added a comment -

        Yeah, I have raised HDFS-8648 sub-task to revisit these cases and do proper corrections.

        Show
        rakeshr Rakesh R added a comment - Yeah, I have raised HDFS-8648 sub-task to revisit these cases and do proper corrections.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Though most of the time the fsd lock is acquired within the fsn lock. BlockManager and LeaseManager only requires the fsn lock but not the fsd lock. We're in the process of cleaning up the locks of both fsn and fsd locks. At the end of the day the NN should be able to process block reports w/o blocking requests to the namespace.

        Okay.

        Following are the functions where it has done the resolution fsd.resolvePath(pc, src, pathComponents); by acquiring only fsn lock and not fsd lock. Could you please take a look at it.

        Thanks Rakesh R for listing out those methods. Can you file a follow-up jira to handle those?

        Show
        vinayrpet Vinayakumar B added a comment - Though most of the time the fsd lock is acquired within the fsn lock. BlockManager and LeaseManager only requires the fsn lock but not the fsd lock. We're in the process of cleaning up the locks of both fsn and fsd locks. At the end of the day the NN should be able to process block reports w/o blocking requests to the namespace. Okay. Following are the functions where it has done the resolution fsd.resolvePath(pc, src, pathComponents); by acquiring only fsn lock and not fsd lock. Could you please take a look at it. Thanks Rakesh R for listing out those methods. Can you file a follow-up jira to handle those?
        Hide
        rakeshr Rakesh R added a comment -

        Following are the functions where it has done the resolution fsd.resolvePath(pc, src, pathComponents); by acquiring only fsn lock and not fsd lock. Could you please take a look at it.

        1. FsDirAclOp.java
          -> getAclStatus()
          -> modifyAclEntries()
          -> removeAcl()
          -> removeDefaultAcl()
          -> setAcl()
          -> getAclStatus()
        2. FsDirDeleteOp.java
          -> delete(fsn, src, recursive, logRetryCache)
        3. FsDirRenameOp.java
          -> renameToInt(fsd, srcArg, dstArg, logRetryCache)
          -> renameToInt(fsd, srcArg, dstArg, logRetryCache, options)
        4. FsDirStatAndListingOp.java
          -> getContentSummary(fsd, src)
          -> getFileInfo(fsd, srcArg, resolveLink)
          -> isFileClosed(fsd, src)
          -> getListingInt(fsd, srcArg, startAfter, needLocation)
        5. FsDirWriteFileOp.java
          -> abandonBlock()
          -> completeFile(fsn, pc, srcArg, holder, last, fileId)
          -> getEncryptionKeyInfo(fsn, pc, src, supportedVersions)
          -> startFile()
          -> validateAddBlock()
        6. FsDirXAttrOp.java
          -> getXAttrs(fsd, srcArg, xAttrs)
          -> listXAttrs(fsd, src)
          -> setXAttr(fsd, src, xAttr, flag, logRetryCache)
        7. FSNamesystem.java
          -> createEncryptionZoneInt()
          -> getEZForPath()
        Show
        rakeshr Rakesh R added a comment - Following are the functions where it has done the resolution fsd.resolvePath(pc, src, pathComponents); by acquiring only fsn lock and not fsd lock. Could you please take a look at it. FsDirAclOp.java -> getAclStatus() -> modifyAclEntries() -> removeAcl() -> removeDefaultAcl() -> setAcl() -> getAclStatus() FsDirDeleteOp.java -> delete(fsn, src, recursive, logRetryCache) FsDirRenameOp.java -> renameToInt(fsd, srcArg, dstArg, logRetryCache) -> renameToInt(fsd, srcArg, dstArg, logRetryCache, options) FsDirStatAndListingOp.java -> getContentSummary(fsd, src) -> getFileInfo(fsd, srcArg, resolveLink) -> isFileClosed(fsd, src) -> getListingInt(fsd, srcArg, startAfter, needLocation) FsDirWriteFileOp.java -> abandonBlock() -> completeFile(fsn, pc, srcArg, holder, last, fileId) -> getEncryptionKeyInfo(fsn, pc, src, supportedVersions) -> startFile() -> validateAddBlock() FsDirXAttrOp.java -> getXAttrs(fsd, srcArg, xAttrs) -> listXAttrs(fsd, src) -> setXAttr(fsd, src, xAttr, flag, logRetryCache) FSNamesystem.java -> createEncryptionZoneInt() -> getEZForPath()
        Hide
        wheat9 Haohui Mai added a comment -

        IMO, I think this is okay, especially for write ops, provided fsn writelock is held. And I can see many places where this resolution is done under fsn lock held, but not fsd lock.

        Can you list these places and file jiras? They are critical bugs and should be fixed.

        This triggered thoughts, Why two separate locks, fsdir lock and fsnamesystem locks.? Almost all ops are go through fsn with lock (read/write) held, and then go on-to get fsdir locks.

        Though most of the time the fsd lock is acquired within the fsn lock. BlockManager and LeaseManager only requires the fsn lock but not the fsd lock. We're in the process of cleaning up the locks of both fsn and fsd locks. At the end of the day the NN should be able to process block reports w/o blocking requests to the namespace.

        Show
        wheat9 Haohui Mai added a comment - IMO, I think this is okay, especially for write ops, provided fsn writelock is held. And I can see many places where this resolution is done under fsn lock held, but not fsd lock. Can you list these places and file jiras? They are critical bugs and should be fixed. This triggered thoughts, Why two separate locks, fsdir lock and fsnamesystem locks.? Almost all ops are go through fsn with lock (read/write) held, and then go on-to get fsdir locks. Though most of the time the fsd lock is acquired within the fsn lock. BlockManager and LeaseManager only requires the fsn lock but not the fsd lock. We're in the process of cleaning up the locks of both fsn and fsd locks. At the end of the day the NN should be able to process block reports w/o blocking requests to the namespace.
        Hide
        vinayrpet Vinayakumar B added a comment -

        The resolution should be in the lock of FSDirectory.

        IMO, I think this is okay, especially for write ops, provided fsn writelock is held. And I can see many places where this resolution is done under fsn lock held, but not fsd lock.

        This triggered thoughts, Why two separate locks, fsdir lock and fsnamesystem locks.? Almost all ops are go through fsn with lock (read/write) held, and then go on-to get fsdir locks.

        Any thoughts?

        Show
        vinayrpet Vinayakumar B added a comment - The resolution should be in the lock of FSDirectory. IMO, I think this is okay, especially for write ops, provided fsn writelock is held. And I can see many places where this resolution is done under fsn lock held, but not fsd lock. This triggered thoughts, Why two separate locks, fsdir lock and fsnamesystem locks.? Almost all ops are go through fsn with lock (read/write) held, and then go on-to get fsdir locks. Any thoughts?
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 48s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 32s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 12s The applied patch generated 2 new checkstyle issues (total was 399, now 394).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 3m 20s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 17s Pre-build of native portion
        +1 hdfs tests 157m 52s Tests passed in hadoop-hdfs.
            204m 12s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12740913/HDFS-8493-007.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / c7d022b
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11430/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11430/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11430/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11430/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 48s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 12s The applied patch generated 2 new checkstyle issues (total was 399, now 394). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 20s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 17s Pre-build of native portion +1 hdfs tests 157m 52s Tests passed in hadoop-hdfs.     204m 12s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12740913/HDFS-8493-007.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c7d022b checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11430/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11430/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11430/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11430/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 35s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 42s There were no new javac warning messages.
        +1 javadoc 9m 52s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 20s The applied patch generated 3 new checkstyle issues (total was 399, now 395).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 40s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 23s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 17s Pre-build of native portion
        -1 hdfs tests 159m 22s Tests failed in hadoop-hdfs.
            207m 13s  



        Reason Tests
        Failed unit tests hadoop.hdfs.web.TestWebHDFSAcl



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12740706/HDFS-8493-007.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 63d40d5
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11427/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11427/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11427/testReport/
        Java 1.7.0_55
        uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11427/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 42s There were no new javac warning messages. +1 javadoc 9m 52s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 20s The applied patch generated 3 new checkstyle issues (total was 399, now 395). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 40s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 23s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 17s Pre-build of native portion -1 hdfs tests 159m 22s Tests failed in hadoop-hdfs.     207m 13s   Reason Tests Failed unit tests hadoop.hdfs.web.TestWebHDFSAcl Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12740706/HDFS-8493-007.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 63d40d5 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11427/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11427/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11427/testReport/ Java 1.7.0_55 uname Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11427/console This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        The resolution should be in the lock of FSDirectory.

        I've tried an attempt by moving fsd.writeLock before resolving the path fsd.resolvePath. With this patch it would increase locking time as it will hold the lock more time than previously. IIUC this is required as it needs to cover the path resolution under lock. Attached patch to this jira. Kindly review the changes again, Thanks!

        Show
        rakeshr Rakesh R added a comment - The resolution should be in the lock of FSDirectory. I've tried an attempt by moving fsd.writeLock before resolving the path fsd.resolvePath . With this patch it would increase locking time as it will hold the lock more time than previously. IIUC this is required as it needs to cover the path resolution under lock. Attached patch to this jira. Kindly review the changes again, Thanks!
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Vinayakumar B for the reply. I will update this on the next patch.

        Show
        rakeshr Rakesh R added a comment - Thanks Vinayakumar B for the reply. I will update this on the next patch.
        Hide
        rakeshr Rakesh R added a comment -

        Thanks Haohui Mai for the reviews. Could you please give few clarifications on the below comment.

        String src = fsd.resolvePath(pc, srcArg, pathComponents);
        The resolution should be in the lock of FSDirectory.

        Will it be OK to acquire fsd#readLock like below ?

            final String src;
            final INodesInPath iip;
            fsd.readLock();
            try {
              src = fsd.resolvePath(pc, srcArg, pathComponents);
              iip = fsd.getINodesInPath4Write(src, true);
            } finally {
              fsd.readUnlock();
            }
        
        Show
        rakeshr Rakesh R added a comment - Thanks Haohui Mai for the reviews. Could you please give few clarifications on the below comment. String src = fsd.resolvePath(pc, srcArg, pathComponents); The resolution should be in the lock of FSDirectory. Will it be OK to acquire fsd#readLock like below ? final String src; final INodesInPath iip; fsd.readLock(); try { src = fsd.resolvePath(pc, srcArg, pathComponents); iip = fsd.getINodesInPath4Write(src, true ); } finally { fsd.readUnlock(); }
        Hide
        wheat9 Haohui Mai added a comment -

        Thanks for the work. The patch looks good to me. Some minor comments:

        +    String src = fsd.resolvePath(pc, srcArg, pathComponents);
        

        The resolution should be in the lock of FSDirectory.

        +    FSPermissionChecker pc = fsd.getPermissionChecker();
        

        getPermissionChecker() is a blocking call. It should be done outside of the lock of FSNameSystem.

        +      String srcArg = src;
        +      NameNode.stateChangeLog.debug(
        +          "DIR* NameSystem.truncate: src={} newLength={}", srcArg, newLength);
        +      if (newLength < 0) {
        +        throw new HadoopIllegalArgumentException(
        +            "Cannot truncate to a negative file size: " + newLength + ".");
        +      }
        +      HdfsFileStatus stat = null;
        

        The code can be moved out of the first try block.

        Show
        wheat9 Haohui Mai added a comment - Thanks for the work. The patch looks good to me. Some minor comments: + String src = fsd.resolvePath(pc, srcArg, pathComponents); The resolution should be in the lock of FSDirectory . + FSPermissionChecker pc = fsd.getPermissionChecker(); getPermissionChecker() is a blocking call. It should be done outside of the lock of FSNameSystem . + String srcArg = src; + NameNode.stateChangeLog.debug( + "DIR* NameSystem.truncate: src={} newLength={}" , srcArg, newLength); + if (newLength < 0) { + throw new HadoopIllegalArgumentException( + "Cannot truncate to a negative file size: " + newLength + "." ); + } + HdfsFileStatus stat = null ; The code can be moved out of the first try block.
        Hide
        vinayrpet Vinayakumar B added a comment -

        I will update the comment like blow, hope that would be OK.

        Fine.

        Many tests in this class failed due to the same reason.

        I noticed that jenkins run on last patch given +1. So we are good to go.

        +1, once the javadoc is fixed.

        Show
        vinayrpet Vinayakumar B added a comment - I will update the comment like blow, hope that would be OK. Fine. Many tests in this class failed due to the same reason. I noticed that jenkins run on last patch given +1. So we are good to go. +1, once the javadoc is fixed.
        Hide
        rakeshr Rakesh R added a comment -

        Thank you Vinayakumar B for reviews.

        Since all truncate() impls are moved to this class, you might need to update the comment. It would be better if you give the link to referring method.

        I will update the comment like blow, hope that would be OK.

           * Unprotected truncate implementation. Unlike
           * {@link FSDirTruncateOp#truncate}, this will not schedule block recovery.
           *
        

        Can you also verify the test failure?

        IIUC following is the failure reason when running the tests previously. This is passing in my env, also the latest build shows the test is passing. It looks like this failure is not related to my patch. One more observation in this test class is, TestFileTruncate#setup will not be able to work well if the testcase with snapshot fails. I meant, fs.delete(parent, true); will throw exception saying The directory /test cannot be deleted since /test is snapshottable and already has snapshots. Many tests in this class failed due to the same reason.

        2015-06-15 15:16:07,291 WARN  blockmanagement.BlockPlacementPolicy (BlockPlacementPolicyDefault.java:chooseTarget(349)) - Failed to place enough replicas, still in need of 1 to reach 3 (unavailableStorages=[], storagePolicy=BlockStoragePolicy{HOT:7, storageTypes=[DISK], creationFallbacks=[], replicationFallbacks=[ARCHIVE]}, newBlock=false) For more information, please enable DEBUG log level on org.apache.hadoop.hdfs.server.blockmanagement.BlockPlacementPolicy
        2015-06-15 15:16:07,292 WARN  blockmanagement.BlockPlacementPolicy (BlockPlacementPolicyDefault.java:chooseTarget(349)) - Failed to place enough replicas, still in need of 1 to reach 3 (unavailableStorages=[DISK], storagePolicy=BlockStoragePolicy{HOT:7, storageTypes=[DISK], creationFallbacks=[], replicationFallbacks=[ARCHIVE]}, newBlock=false) For more information, please enable DEBUG log level on org.apache.hadoop.hdfs.server.blockmanagement.BlockPlacementPolicy
        2015-06-15 15:16:07,292 WARN  protocol.BlockStoragePolicy (BlockStoragePolicy.java:chooseStorageTypes(161)) - Failed to place enough replicas: expected size is 1 but only 0 storage types can be selected (replication=3, selected=[], unavailable=[DISK, ARCHIVE], removed=[DISK], policy=BlockStoragePolicy{HOT:7, storageTypes=[DISK], creationFallbacks=[], replicationFallbacks=[ARCHIVE]})
        2015-06-15 15:16:07,292 WARN  blockmanagement.BlockPlacementPolicy (BlockPlacementPolicyDefault.java:chooseTarget(349)) - Failed to place enough replicas, still in need of 1 to reach 3 (unavailableStorages=[DISK, ARCHIVE], storagePolicy=BlockStoragePolicy{HOT:7, storageTypes=[DISK], creationFallbacks=[], replicationFallbacks=[ARCHIVE]}, newBlock=false) All required storage types are unavailable:  unavailableStorages=[DISK, ARCHIVE], storagePolicy=BlockStoragePolicy{HOT:7, storageTypes=[DISK], creationFallbacks=[], replicationFallbacks=[ARCHIVE]}
        2015-06-15 15:16:07,293 WARN  hdfs.DataStreamer (DataStreamer.java:run(695)) - DataStreamer Exception
        java.io.IOException: Failed to replace a bad datanode on the existing pipeline due to no more good datanodes being available to try. (Nodes: current=[DatanodeInfoWithStorage[127.0.0.1:47991,DS-0f451b86-376d-4589-9d49-df1387e1dd72,DISK], DatanodeInfoWithStorage[127.0.0.1:44802,DS-31bf3b2f-cfba-46b6-9e90-868dc0a9d444,DISK]], original=[DatanodeInfoWithStorage[127.0.0.1:44802,DS-31bf3b2f-cfba-46b6-9e90-868dc0a9d444,DISK], DatanodeInfoWithStorage[127.0.0.1:47991,DS-0f451b86-376d-4589-9d49-df1387e1dd72,DISK]]). The current failed datanode replacement policy is DEFAULT, and a client may configure this via 'dfs.client.block.write.replace-datanode-on-failure.policy' in its configuration.
        	at org.apache.hadoop.hdfs.DataStreamer.findNewDatanode(DataStreamer.java:1145)
        	at org.apache.hadoop.hdfs.DataStreamer.addDatanode2ExistingPipeline(DataStreamer.java:1211)
        	at org.apache.hadoop.hdfs.DataStreamer.handleDatanodeReplacement(DataStreamer.java:1375)
        	at org.apache.hadoop.hdfs.DataStreamer.setupPipelineForAppendOrRecovery(DataStreamer.java:1289)
        	at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:586)
        
        Show
        rakeshr Rakesh R added a comment - Thank you Vinayakumar B for reviews. Since all truncate() impls are moved to this class, you might need to update the comment. It would be better if you give the link to referring method. I will update the comment like blow, hope that would be OK. * Unprotected truncate implementation. Unlike * {@link FSDirTruncateOp#truncate}, this will not schedule block recovery. * Can you also verify the test failure? IIUC following is the failure reason when running the tests previously. This is passing in my env, also the latest build shows the test is passing. It looks like this failure is not related to my patch. One more observation in this test class is, TestFileTruncate#setup will not be able to work well if the testcase with snapshot fails. I meant, fs.delete(parent, true); will throw exception saying The directory /test cannot be deleted since /test is snapshottable and already has snapshots . Many tests in this class failed due to the same reason. 2015-06-15 15:16:07,291 WARN blockmanagement.BlockPlacementPolicy (BlockPlacementPolicyDefault.java:chooseTarget(349)) - Failed to place enough replicas, still in need of 1 to reach 3 (unavailableStorages=[], storagePolicy=BlockStoragePolicy{HOT:7, storageTypes=[DISK], creationFallbacks=[], replicationFallbacks=[ARCHIVE]}, newBlock= false ) For more information, please enable DEBUG log level on org.apache.hadoop.hdfs.server.blockmanagement.BlockPlacementPolicy 2015-06-15 15:16:07,292 WARN blockmanagement.BlockPlacementPolicy (BlockPlacementPolicyDefault.java:chooseTarget(349)) - Failed to place enough replicas, still in need of 1 to reach 3 (unavailableStorages=[DISK], storagePolicy=BlockStoragePolicy{HOT:7, storageTypes=[DISK], creationFallbacks=[], replicationFallbacks=[ARCHIVE]}, newBlock= false ) For more information, please enable DEBUG log level on org.apache.hadoop.hdfs.server.blockmanagement.BlockPlacementPolicy 2015-06-15 15:16:07,292 WARN protocol.BlockStoragePolicy (BlockStoragePolicy.java:chooseStorageTypes(161)) - Failed to place enough replicas: expected size is 1 but only 0 storage types can be selected (replication=3, selected=[], unavailable=[DISK, ARCHIVE], removed=[DISK], policy=BlockStoragePolicy{HOT:7, storageTypes=[DISK], creationFallbacks=[], replicationFallbacks=[ARCHIVE]}) 2015-06-15 15:16:07,292 WARN blockmanagement.BlockPlacementPolicy (BlockPlacementPolicyDefault.java:chooseTarget(349)) - Failed to place enough replicas, still in need of 1 to reach 3 (unavailableStorages=[DISK, ARCHIVE], storagePolicy=BlockStoragePolicy{HOT:7, storageTypes=[DISK], creationFallbacks=[], replicationFallbacks=[ARCHIVE]}, newBlock= false ) All required storage types are unavailable: unavailableStorages=[DISK, ARCHIVE], storagePolicy=BlockStoragePolicy{HOT:7, storageTypes=[DISK], creationFallbacks=[], replicationFallbacks=[ARCHIVE]} 2015-06-15 15:16:07,293 WARN hdfs.DataStreamer (DataStreamer.java:run(695)) - DataStreamer Exception java.io.IOException: Failed to replace a bad datanode on the existing pipeline due to no more good datanodes being available to try . (Nodes: current=[DatanodeInfoWithStorage[127.0.0.1:47991,DS-0f451b86-376d-4589-9d49-df1387e1dd72,DISK], DatanodeInfoWithStorage[127.0.0.1:44802,DS-31bf3b2f-cfba-46b6-9e90-868dc0a9d444,DISK]], original=[DatanodeInfoWithStorage[127.0.0.1:44802,DS-31bf3b2f-cfba-46b6-9e90-868dc0a9d444,DISK], DatanodeInfoWithStorage[127.0.0.1:47991,DS-0f451b86-376d-4589-9d49-df1387e1dd72,DISK]]). The current failed datanode replacement policy is DEFAULT, and a client may configure this via 'dfs.client.block.write.replace-datanode-on-failure.policy' in its configuration. at org.apache.hadoop.hdfs.DataStreamer.findNewDatanode(DataStreamer.java:1145) at org.apache.hadoop.hdfs.DataStreamer.addDatanode2ExistingPipeline(DataStreamer.java:1211) at org.apache.hadoop.hdfs.DataStreamer.handleDatanodeReplacement(DataStreamer.java:1375) at org.apache.hadoop.hdfs.DataStreamer.setupPipelineForAppendOrRecovery(DataStreamer.java:1289) at org.apache.hadoop.hdfs.DataStreamer.run(DataStreamer.java:586)
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 15m 12s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 38s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 56s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 14s Pre-build of native portion
        +1 hdfs tests 161m 36s Tests passed in hadoop-hdfs.
            203m 56s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12739784/HDFS-8493-006.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 32e39d8
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11368/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11368/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11368/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 12s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 56s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion +1 hdfs tests 161m 36s Tests passed in hadoop-hdfs.     203m 56s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739784/HDFS-8493-006.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 32e39d8 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11368/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11368/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11368/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        nit got on first look.

        FSEditLogLoader implementation. Unlike FSNamesystem.truncate, this will
        not schedule block recovery.

        Since all truncate() impls are moved to this class, you might need to update the comment. It would be better if you give the link to referring method.

        Can you also verify the test failure?

        Show
        vinayrpet Vinayakumar B added a comment - nit got on first look. FSEditLogLoader implementation. Unlike FSNamesystem.truncate, this will not schedule block recovery. Since all truncate() impls are moved to this class, you might need to update the comment. It would be better if you give the link to referring method. Can you also verify the test failure?
        Hide
        rakeshr Rakesh R added a comment -

        Attached patch fixing few checkstyle comments.
        Note: Following checkstyle comments are not related to the patch.

        ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java:325:3: Method length is 598 lines (max allowed is 150).
        ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:1: File length is 7,520 lines (max allowed is 2,000).
        
        Show
        rakeshr Rakesh R added a comment - Attached patch fixing few checkstyle comments. Note: Following checkstyle comments are not related to the patch. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java:325:3: Method length is 598 lines (max allowed is 150). ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:1: File length is 7,520 lines (max allowed is 2,000).
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 52s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 36s There were no new javac warning messages.
        +1 javadoc 9m 39s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 12s The applied patch generated 4 new checkstyle issues (total was 403, now 400).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 15s Pre-build of native portion
        -1 hdfs tests 166m 11s Tests failed in hadoop-hdfs.
            212m 34s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12739614/HDFS-8493-005.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 4c5da9b
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11359/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11359/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11359/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11359/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 52s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 12s The applied patch generated 4 new checkstyle issues (total was 403, now 400). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 15s Pre-build of native portion -1 hdfs tests 166m 11s Tests failed in hadoop-hdfs.     212m 34s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739614/HDFS-8493-005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 4c5da9b checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11359/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11359/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11359/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11359/console This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        Thank you Haohui Mai for the review comments. Attached patch addressing the comments.

        Most of the functions in FSDirTruncateOp should be private instead of package local.

        Since FsDirTruncateOp#prepareFileForTruncate is used in tests, have made @VisibleForTesting to it.

        Show
        rakeshr Rakesh R added a comment - Thank you Haohui Mai for the review comments. Attached patch addressing the comments. Most of the functions in FSDirTruncateOp should be private instead of package local. Since FsDirTruncateOp#prepareFileForTruncate is used in tests, have made @VisibleForTesting to it.
        Hide
        wheat9 Haohui Mai added a comment -

        Thanks for the work. There are a couple high-level comments here:

        1. Safemode related code should reside in FSNamesystem instead of FSDirTruncateOp.truncate().
        2. The blocks should be deleted in FSNamesystem instead of FSDirTruncateOp.truncate().
        3. Most of the functions in FSDirTruncateOp should be private instead of package local.

        Show
        wheat9 Haohui Mai added a comment - Thanks for the work. There are a couple high-level comments here: 1. Safemode related code should reside in FSNamesystem instead of FSDirTruncateOp.truncate() . 2. The blocks should be deleted in FSNamesystem instead of FSDirTruncateOp.truncate() . 3. Most of the functions in FSDirTruncateOp should be private instead of package local.
        Hide
        rakeshr Rakesh R added a comment -

        The test case TestEncryptedTransfer is passing locally for me. Unfortunately it hits below exception in jenkins and failed.

        java.lang.RuntimeException: java.util.zip.ZipException: invalid stored block lengths
        	at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:164)
        	at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:122)
        	at java.io.FilterInputStream.read(FilterInputStream.java:83)
        	at org.apache.xerces.impl.XMLEntityManager$RewindableInputStream.read(Unknown Source)
        	at org.apache.xerces.impl.XMLEntityManager.setupCurrentEntity(Unknown Source)
        	at org.apache.xerces.impl.XMLVersionDetector.determineDocVersion(Unknown Source)
        	at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
        	at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source)
        	at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
        	at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
        	at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source)
        	at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:150)
        	at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2546)
        	at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2534)
        	at org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2605)
        	at org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2558)
        	at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2469)
        	at org.apache.hadoop.conf.Configuration.get(Configuration.java:1294)
        	at org.apache.hadoop.hdfs.MiniDFSCluster.determineDfsBaseDir(MiniDFSCluster.java:2479)
        	at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:780)
        	at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:471)
        	at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:430)
        	at org.apache.hadoop.hdfs.TestEncryptedTransfer.testLongLivedClient(TestEncryptedTransfer.java:437)
        
        Show
        rakeshr Rakesh R added a comment - The test case TestEncryptedTransfer is passing locally for me. Unfortunately it hits below exception in jenkins and failed. java.lang.RuntimeException: java.util.zip.ZipException: invalid stored block lengths at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:164) at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:122) at java.io.FilterInputStream.read(FilterInputStream.java:83) at org.apache.xerces.impl.XMLEntityManager$RewindableInputStream.read(Unknown Source) at org.apache.xerces.impl.XMLEntityManager.setupCurrentEntity(Unknown Source) at org.apache.xerces.impl.XMLVersionDetector.determineDocVersion(Unknown Source) at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) at org.apache.xerces.parsers.XML11Configuration.parse(Unknown Source) at org.apache.xerces.parsers.XMLParser.parse(Unknown Source) at org.apache.xerces.parsers.DOMParser.parse(Unknown Source) at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source) at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:150) at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2546) at org.apache.hadoop.conf.Configuration.parse(Configuration.java:2534) at org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:2605) at org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:2558) at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:2469) at org.apache.hadoop.conf.Configuration.get(Configuration.java:1294) at org.apache.hadoop.hdfs.MiniDFSCluster.determineDfsBaseDir(MiniDFSCluster.java:2479) at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:780) at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:471) at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:430) at org.apache.hadoop.hdfs.TestEncryptedTransfer.testLongLivedClient(TestEncryptedTransfer.java:437)
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 29s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 40s There were no new javac warning messages.
        +1 javadoc 9m 55s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 17s The applied patch generated 2 new checkstyle issues (total was 405, now 400).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 19s Pre-build of native portion
        -1 hdfs tests 163m 27s Tests failed in hadoop-hdfs.
            211m 3s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestEncryptedTransfer



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12736805/HDFS-8493-004.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 990078b
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11201/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11201/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11201/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11201/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 29s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 40s There were no new javac warning messages. +1 javadoc 9m 55s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 17s The applied patch generated 2 new checkstyle issues (total was 405, now 400). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 19s Pre-build of native portion -1 hdfs tests 163m 27s Tests failed in hadoop-hdfs.     211m 3s   Reason Tests Failed unit tests hadoop.hdfs.TestEncryptedTransfer Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736805/HDFS-8493-004.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 990078b checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11201/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11201/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11201/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11201/console This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        oops, I had done one mistake in the following condition. Now I've corrected it and uploaded another patch, will wait for the jenkins report.

        FSDirTruncateOp#verifyQuotaForTruncate() 
        
        +    if (!fsn.isImageLoaded() || fsd.shouldSkipQuotaChecks()) {
        +      // Do not check quota if edit log is still being processed
        +      return;
        +    }
        
        Show
        rakeshr Rakesh R added a comment - oops, I had done one mistake in the following condition. Now I've corrected it and uploaded another patch, will wait for the jenkins report. FSDirTruncateOp#verifyQuotaForTruncate() + if (!fsn.isImageLoaded() || fsd.shouldSkipQuotaChecks()) { + // Do not check quota if edit log is still being processed + return ; + }
        Hide
        wheat9 Haohui Mai added a comment -

        Here are the failed tests from the test report:

         org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate.testTruncateOverQuota
         org.apache.hadoop.hdfs.server.namenode.TestQuotaByStorageType.testQuotaByStorageTypeWithFileCreateTruncate
        

        I believe that the failures are closely related. Can you please take a look? Thanks.

        Show
        wheat9 Haohui Mai added a comment - Here are the failed tests from the test report: org.apache.hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate.testTruncateOverQuota org.apache.hadoop.hdfs.server.namenode.TestQuotaByStorageType.testQuotaByStorageTypeWithFileCreateTruncate I believe that the failures are closely related. Can you please take a look? Thanks.
        Hide
        rakeshr Rakesh R added a comment -

        Checkstyle fixes are unrelated to my patch.

        ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java:323:3: Method length is 598 lines (max allowed is 150).
        ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:1: File length is 7,443 lines (max allowed is 2,000).
        

        Also, it looks like test case failure is unrelated to my patch.

        Haohui Mai please review the changes when you get a chance. Thanks!

        Show
        rakeshr Rakesh R added a comment - Checkstyle fixes are unrelated to my patch. ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java:323:3: Method length is 598 lines (max allowed is 150). ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:1: File length is 7,443 lines (max allowed is 2,000). Also, it looks like test case failure is unrelated to my patch. Haohui Mai please review the changes when you get a chance. Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 54s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 28s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 15s The applied patch generated 2 new checkstyle issues (total was 405, now 400).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 14s Pre-build of native portion
        -1 hdfs tests 162m 26s Tests failed in hadoop-hdfs.
            208m 46s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate
          hadoop.hdfs.server.namenode.TestQuotaByStorageType



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12736492/HDFS-8493-003.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 5cc3fce
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11179/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11179/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11179/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11179/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 54s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 15s The applied patch generated 2 new checkstyle issues (total was 405, now 400). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 162m 26s Tests failed in hadoop-hdfs.     208m 46s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate   hadoop.hdfs.server.namenode.TestQuotaByStorageType Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736492/HDFS-8493-003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 5cc3fce checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11179/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11179/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11179/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11179/console This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        Attaching another patch fixing checkstyle warnings.

        Show
        rakeshr Rakesh R added a comment - Attaching another patch fixing checkstyle warnings.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 49s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 35s There were no new javac warning messages.
        +1 javadoc 9m 39s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 13s The applied patch generated 4 new checkstyle issues (total was 405, now 402).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 16s Pre-build of native portion
        -1 hdfs tests 162m 32s Tests failed in hadoop-hdfs.
            208m 53s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestQuotaByStorageType
          hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12736442/HDFS-8493-002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / c2356cb
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11178/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11178/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11178/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11178/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 49s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 35s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 13s The applied patch generated 4 new checkstyle issues (total was 405, now 402). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 16s Pre-build of native portion -1 hdfs tests 162m 32s Tests failed in hadoop-hdfs.     208m 53s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestQuotaByStorageType   hadoop.hdfs.server.namenode.TestDiskspaceQuotaUpdate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736442/HDFS-8493-002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c2356cb checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11178/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11178/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11178/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11178/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 48s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        -1 javac 1m 14s The patch appears to cause the build to fail.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12736415/HDFS-8493-001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / da05361
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11176/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 48s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. -1 javac 1m 14s The patch appears to cause the build to fail. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736415/HDFS-8493-001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / da05361 Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11176/console This message was automatically generated.
        Hide
        rakeshr Rakesh R added a comment -

        After talking with Haohui Mai, I will work on this issue. Thanks!

        Show
        rakeshr Rakesh R added a comment - After talking with Haohui Mai , I will work on this issue. Thanks!

          People

          • Assignee:
            rakeshr Rakesh R
            Reporter:
            wheat9 Haohui Mai
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development