Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8492

DN should notify NN when client requests a missing block

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha
    • Fix Version/s: 2.8.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      If the DN has a block its volume map but not on-disk, it tells clients it's an invalid block id. The NN is not informed of the missing block until either the bp slice scanner or the directory scanner detects the missing block. DN should remove the replica from the volume map and inform the NN.

      1. HDFS-8492.01.patch
        5 kB
        Walter Su
      2. HDFS-8492-02.patch
        6 kB
        Rakesh R

        Issue Links

          Activity

          Hide
          walter.k.su Walter Su added a comment -

          Uploaded the patch. Thanks Daryn Sharp for reporting this.

          Show
          walter.k.su Walter Su added a comment - Uploaded the patch. Thanks Daryn Sharp for reporting this.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 25s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 49s There were no new javac warning messages.
          +1 javadoc 13m 5s There were no new javadoc warning messages.
          -1 release audit 0m 24s The applied patch generated 1 release audit warnings.
          -1 checkstyle 1m 41s The applied patch generated 1 new checkstyle issues (total was 167, now 166).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 48s mvn install still works.
          +1 eclipse:eclipse 0m 39s The patch built with eclipse:eclipse.
          +1 findbugs 2m 47s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 34s Pre-build of native portion
          -1 hdfs tests 165m 3s Tests failed in hadoop-hdfs.
              218m 19s  



          Reason Tests
          Failed unit tests hadoop.fs.TestFcHdfsSetUMask
            hadoop.hdfs.TestRecoverStripedFile
            hadoop.hdfs.TestLeaseRecovery2
          Timed out tests org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
            org.apache.hadoop.hdfs.server.mover.TestStorageMover



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766074/HDFS-8492.01.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 049c6e8
          Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12930/artifact/patchprocess/patchReleaseAuditProblems.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12930/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12930/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12930/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12930/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 25s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 49s There were no new javac warning messages. +1 javadoc 13m 5s There were no new javadoc warning messages. -1 release audit 0m 24s The applied patch generated 1 release audit warnings. -1 checkstyle 1m 41s The applied patch generated 1 new checkstyle issues (total was 167, now 166). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 48s mvn install still works. +1 eclipse:eclipse 0m 39s The patch built with eclipse:eclipse. +1 findbugs 2m 47s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 34s Pre-build of native portion -1 hdfs tests 165m 3s Tests failed in hadoop-hdfs.     218m 19s   Reason Tests Failed unit tests hadoop.fs.TestFcHdfsSetUMask   hadoop.hdfs.TestRecoverStripedFile   hadoop.hdfs.TestLeaseRecovery2 Timed out tests org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   org.apache.hadoop.hdfs.server.mover.TestStorageMover Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766074/HDFS-8492.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 049c6e8 Release Audit https://builds.apache.org/job/PreCommit-HDFS-Build/12930/artifact/patchprocess/patchReleaseAuditProblems.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12930/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12930/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12930/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12930/console This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Patch needs rebase

          Show
          vinayrpet Vinayakumar B added a comment - Patch needs rebase
          Hide
          rakeshr Rakesh R added a comment -

          Thanks Vinayakumar B, I've rebased the patch and attached the same. Kindly take a look at it.

          Show
          rakeshr Rakesh R added a comment - Thanks Vinayakumar B , I've rebased the patch and attached the same. Kindly take a look at it.
          Hide
          vinayrpet Vinayakumar B added a comment -

          +1, changes looks good.
          Pending Jenkins for latest patch.

          Show
          vinayrpet Vinayakumar B added a comment - +1, changes looks good. Pending Jenkins for latest patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 5s trunk passed
          +1 compile 0m 45s trunk passed
          +1 checkstyle 0m 30s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 45s trunk passed
          +1 javadoc 0m 44s trunk passed
          +1 mvninstall 0m 48s the patch passed
          +1 compile 0m 44s the patch passed
          +1 javac 0m 44s the patch passed
          -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 132 unchanged - 2 fixed = 133 total (was 134)
          +1 mvnsite 0m 52s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 56s the patch passed
          +1 javadoc 0m 37s the patch passed
          -1 unit 68m 44s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          88m 10s



          Reason Tests
          Timed out junit tests org.apache.hadoop.hdfs.TestEncryptionZones
            org.apache.hadoop.hdfs.server.namenode.TestSecureNameNode
            org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
            org.apache.hadoop.fs.TestGlobPaths
            org.apache.hadoop.hdfs.TestFileAppend2
            org.apache.hadoop.hdfs.server.namenode.TestNameNodeReconfigure
            org.apache.hadoop.hdfs.server.namenode.TestFileTruncate
            org.apache.hadoop.hdfs.server.mover.TestStorageMover
            org.apache.hadoop.hdfs.server.mover.TestMover
            org.apache.hadoop.hdfs.server.namenode.TestDeleteRace
            org.apache.hadoop.hdfs.server.namenode.TestAuditLogs



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-8492
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835531/HDFS-8492-02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a675a20b7325 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 77f2684
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17319/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17319/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17319/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 5s trunk passed +1 compile 0m 45s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 45s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 48s the patch passed +1 compile 0m 44s the patch passed +1 javac 0m 44s the patch passed -0 checkstyle 0m 26s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 132 unchanged - 2 fixed = 133 total (was 134) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 56s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 68m 44s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 88m 10s Reason Tests Timed out junit tests org.apache.hadoop.hdfs.TestEncryptionZones   org.apache.hadoop.hdfs.server.namenode.TestSecureNameNode   org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete   org.apache.hadoop.fs.TestGlobPaths   org.apache.hadoop.hdfs.TestFileAppend2   org.apache.hadoop.hdfs.server.namenode.TestNameNodeReconfigure   org.apache.hadoop.hdfs.server.namenode.TestFileTruncate   org.apache.hadoop.hdfs.server.mover.TestStorageMover   org.apache.hadoop.hdfs.server.mover.TestMover   org.apache.hadoop.hdfs.server.namenode.TestDeleteRace   org.apache.hadoop.hdfs.server.namenode.TestAuditLogs Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-8492 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835531/HDFS-8492-02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a675a20b7325 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 77f2684 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17319/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17319/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17319/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17319/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rakeshr Rakesh R added a comment -

          It looks like the test case failures are unrelated and failed due to timeouts, please ignore it.

          Show
          rakeshr Rakesh R added a comment - It looks like the test case failures are unrelated and failed due to timeouts, please ignore it.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Committed to trunk, branch-2 and branch-2.8

          Thanks Daryn Sharp, Walter Su and Rakesh R

          Show
          vinayrpet Vinayakumar B added a comment - Committed to trunk, branch-2 and branch-2.8 Thanks Daryn Sharp , Walter Su and Rakesh R
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #10702 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10702/)
          HDFS-8492. DN should notify NN when client requests a missing block (vinayakumarb: rev 1cf6ec4ad4e1f4ea71f912923b5e8627b61ef482)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeReport.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #10702 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10702/ ) HDFS-8492 . DN should notify NN when client requests a missing block (vinayakumarb: rev 1cf6ec4ad4e1f4ea71f912923b5e8627b61ef482) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDatanodeReport.java
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 53s trunk passed
          +1 compile 0m 44s trunk passed
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 51s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 42s trunk passed
          +1 javadoc 0m 39s trunk passed
          +1 mvninstall 0m 50s the patch passed
          +1 compile 0m 47s the patch passed
          +1 javac 0m 47s the patch passed
          -0 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 132 unchanged - 2 fixed = 133 total (was 134)
          +1 mvnsite 0m 47s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 46s the patch passed
          +1 javadoc 0m 37s the patch passed
          -1 unit 57m 2s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          75m 34s



          Reason Tests
          Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestINodeFile
            org.apache.hadoop.hdfs.server.namenode.ha.TestLossyRetryInvocationHandler
            org.apache.hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
            org.apache.hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
            org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HDFS-8492
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835531/HDFS-8492-02.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 77be5cb6eb40 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4e403de
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17323/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/17323/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17323/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17323/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 53s trunk passed +1 compile 0m 44s trunk passed +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 42s trunk passed +1 javadoc 0m 39s trunk passed +1 mvninstall 0m 50s the patch passed +1 compile 0m 47s the patch passed +1 javac 0m 47s the patch passed -0 checkstyle 0m 24s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 132 unchanged - 2 fixed = 133 total (was 134) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 37s the patch passed -1 unit 57m 2s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 75m 34s Reason Tests Timed out junit tests org.apache.hadoop.hdfs.server.namenode.TestINodeFile   org.apache.hadoop.hdfs.server.namenode.ha.TestLossyRetryInvocationHandler   org.apache.hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA   org.apache.hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA   org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HDFS-8492 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835531/HDFS-8492-02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 77be5cb6eb40 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4e403de Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/17323/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/17323/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/17323/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/17323/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

            People

            • Assignee:
              walter.k.su Walter Su
              Reporter:
              daryn Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development