Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8462

Implement GETXATTRS and LISTXATTRS operations for WebImageViewer

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In Hadoop 2.7.0, WebImageViewer supports the following operations:

      • GETFILESTATUS
      • LISTSTATUS
      • GETACLSTATUS

      I'm thinking it would be better for administrators if GETXATTRS and LISTXATTRS are supported.

      1. HDFS-8462-00.patch
        15 kB
        Jagadesh Kiran N
      2. HDFS-8462-01.patch
        16 kB
        Jagadesh Kiran N
      3. HDFS-8462-02.patch
        18 kB
        Jagadesh Kiran N
      4. HDFS-8462-03.patch
        20 kB
        Jagadesh Kiran N
      5. HDFS-8462-04.patch
        20 kB
        Jagadesh Kiran N
      6. HDFS-8462-05.patch
        20 kB
        Jagadesh Kiran N
      7. HDFS-8462-06.patch
        20 kB
        Jagadesh Kiran N

        Activity

        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        I have attached the patch please review

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - I have attached the patch please review
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Please find the attached patch

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Please find the attached patch
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 18m 25s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 47s There were no new javac warning messages.
        +1 javadoc 9m 52s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 16s The applied patch generated 15 new checkstyle issues (total was 136, now 150).
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 22s Pre-build of native portion
        +1 hdfs tests 162m 53s Tests passed in hadoop-hdfs.
            210m 29s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12738401/HDFS-8462-00.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 0e80d51
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11275/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11275/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11275/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11275/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11275/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 25s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 47s There were no new javac warning messages. +1 javadoc 9m 52s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 16s The applied patch generated 15 new checkstyle issues (total was 136, now 150). -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 22s Pre-build of native portion +1 hdfs tests 162m 53s Tests passed in hadoop-hdfs.     210m 29s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738401/HDFS-8462-00.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0e80d51 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11275/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11275/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11275/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11275/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11275/console This message was automatically generated.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Fixed the Whitespaces & Checkstyle errors

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Fixed the Whitespaces & Checkstyle errors
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 52s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 36s There were no new javac warning messages.
        +1 javadoc 9m 42s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 11s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 10s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 14s Pre-build of native portion
        +1 hdfs tests 160m 44s Tests passed in hadoop-hdfs.
            207m 3s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12738871/HDFS-8462-01.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / c7729ef
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11304/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11304/testReport/
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11304/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 52s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 11s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 10s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion +1 hdfs tests 160m 44s Tests passed in hadoop-hdfs.     207m 3s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738871/HDFS-8462-01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c7729ef hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11304/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11304/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11304/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jagadesh Kiran N for taking this issue. Some comments:

        FSImageLoader#getXAttrs
           * @return JSON formatted ListXAttrs
        

        1. Would you change ListXAttrs to XAttrs? (http://hadoop.apache.org/docs/r2.7.0/hadoop-project-dist/hadoop-hdfs/WebHDFS.html#XAttrs_JSON_Schema)

        FSImageLoader#listXAttrs
           * @return JSON formatted ListXAttrs
        

        2. Would you change ListXAttrs to XAttrNames? (http://hadoop.apache.org/docs/r2.7.0/hadoop-project-dist/hadoop-hdfs/WebHDFS.html#XAttrNames_JSON_Schema)

        3. For testing these operation, would you create an WebHdfsFileSystem instance and call getXAttr, getXAttrs, and listXAttrs as TestOfflineImageViewerForAcl?

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jagadesh Kiran N for taking this issue. Some comments: FSImageLoader#getXAttrs * @ return JSON formatted ListXAttrs 1. Would you change ListXAttrs to XAttrs ? ( http://hadoop.apache.org/docs/r2.7.0/hadoop-project-dist/hadoop-hdfs/WebHDFS.html#XAttrs_JSON_Schema ) FSImageLoader#listXAttrs * @ return JSON formatted ListXAttrs 2. Would you change ListXAttrs to XAttrNames ? ( http://hadoop.apache.org/docs/r2.7.0/hadoop-project-dist/hadoop-hdfs/WebHDFS.html#XAttrNames_JSON_Schema ) 3. For testing these operation, would you create an WebHdfsFileSystem instance and call getXAttr , getXAttrs , and listXAttrs as TestOfflineImageViewerForAcl ?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        4. Would you add these operations to the document?

        HdfsImageViewer.md
        The Web processor now supports the following operations:
        
        * [LISTSTATUS](./WebHDFS.html#List_a_Directory)
        * [GETFILESTATUS](./WebHDFS.html#Status_of_a_FileDirectory)
        * [GETACLSTATUS](./WebHDFS.html#Get_ACL_Status)
        
        Show
        ajisakaa Akira Ajisaka added a comment - 4. Would you add these operations to the document? HdfsImageViewer.md The Web processor now supports the following operations: * [LISTSTATUS](./WebHDFS.html#List_a_Directory) * [GETFILESTATUS](./WebHDFS.html#Status_of_a_FileDirectory) * [GETACLSTATUS](./WebHDFS.html#Get_ACL_Status)
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Thanks Akira Ajisaka for reviewing the patch, i will soon update the patch as per your comments

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Thanks Akira Ajisaka for reviewing the patch, i will soon update the patch as per your comments
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Hi Akira Ajisaka i have attached the patch with changes you suggested as part of review.Please review the same

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Hi Akira Ajisaka i have attached the patch with changes you suggested as part of review.Please review the same
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 20m 49s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 26s There were no new javac warning messages.
        +1 javadoc 9m 35s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 site 2m 59s Site still builds.
        +1 checkstyle 2m 12s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 13s Pre-build of native portion
        -1 hdfs tests 160m 32s Tests failed in hadoop-hdfs.
            212m 31s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12740137/HDFS-8462-02.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / 6e3fcff
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11393/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11393/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11393/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 49s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 26s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 2m 59s Site still builds. +1 checkstyle 2m 12s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion -1 hdfs tests 160m 32s Tests failed in hadoop-hdfs.     212m 31s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestFileTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12740137/HDFS-8462-02.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 6e3fcff hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11393/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11393/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11393/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jagadesh Kiran N for updating the patch. Mostly looks good to me.
        I found that if the provided xattr.name is not found in the specified path, WebImageViewer returns 500 (Internal Server Error). In contrast, WebHDFS returns 403 (Forbidden) in the same condition. The reason is, if IOException occurs, FSImageHandler#exceptionCaught sets 500, and o.a.h.hdfs.web.ExceptionHandler#toResponse sets 403.
        Would you fix the return code to 403 in FSImageHandler when IOException happens? We can safely fix it in this jira because IOException should not happen in the other operations (GETFILESTATUS, LISTSTATUS, GETACLSTATUS).

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jagadesh Kiran N for updating the patch. Mostly looks good to me. I found that if the provided xattr.name is not found in the specified path, WebImageViewer returns 500 (Internal Server Error). In contrast, WebHDFS returns 403 (Forbidden) in the same condition. The reason is, if IOException occurs, FSImageHandler#exceptionCaught sets 500, and o.a.h.hdfs.web.ExceptionHandler#toResponse sets 403. Would you fix the return code to 403 in FSImageHandler when IOException happens? We can safely fix it in this jira because IOException should not happen in the other operations (GETFILESTATUS, LISTSTATUS, GETACLSTATUS).
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Would you fix the return code to 403 in FSImageHandler when IOException happens?

        and would you please add a test case for the return code?

        Show
        ajisakaa Akira Ajisaka added a comment - Would you fix the return code to 403 in FSImageHandler when IOException happens? and would you please add a test case for the return code?
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Thanks Akira Ajisaka for your review comments, i hv added the IO Exception and Test Code ,Please review

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Thanks Akira Ajisaka for your review comments, i hv added the IO Exception and Test Code ,Please review
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 21m 22s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 44s There were no new javac warning messages.
        +1 javadoc 10m 2s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 1s Site still builds.
        +1 checkstyle 2m 16s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 20s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 19s Pre-build of native portion
        +1 hdfs tests 163m 9s Tests passed in hadoop-hdfs.
            216m 46s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12740427/HDFS-8462-03.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / 5b5bb8d
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11407/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11407/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11407/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 21m 22s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 10m 2s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 3m 1s Site still builds. +1 checkstyle 2m 16s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 20s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 19s Pre-build of native portion +1 hdfs tests 163m 9s Tests passed in hadoop-hdfs.     216m 46s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12740427/HDFS-8462-03.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 5b5bb8d hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11407/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11407/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11407/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jagadesh Kiran N for updating the patch. Minor comment:

        TestOfflineImageViewerForXAttr.java
            WebImageViewer viewer = new WebImageViewer(
                NetUtils.createSocketAddr("localhost:0"));
            try {
              viewer.initServer(originalFsimage.getAbsolutePath());
        ...
            } finally {
              // shutdown the viewer
              viewer.close();
            }
        

        Would you use try-with-resources instead of try-finally? I'm +1 if that is addressed.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jagadesh Kiran N for updating the patch. Minor comment: TestOfflineImageViewerForXAttr.java WebImageViewer viewer = new WebImageViewer( NetUtils.createSocketAddr( "localhost:0" )); try { viewer.initServer(originalFsimage.getAbsolutePath()); ... } finally { // shutdown the viewer viewer.close(); } Would you use try-with-resources instead of try-finally? I'm +1 if that is addressed.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Thanks for your review Akira Ajisaka changes done with try resources ,attached the patch ,please review

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Thanks for your review Akira Ajisaka changes done with try resources ,attached the patch ,please review
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 18m 43s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 45s There were no new javac warning messages.
        +1 javadoc 9m 58s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 1s Site still builds.
        +1 checkstyle 0m 44s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 39s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 3m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 18s Pre-build of native portion
        +1 hdfs tests 159m 29s Tests passed in hadoop-hdfs.
            208m 56s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741031/HDFS-8462-04.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / 445b132
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11434/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11434/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11434/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 18m 43s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 9m 58s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 site 3m 1s Site still builds. +1 checkstyle 0m 44s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 39s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 18s Pre-build of native portion +1 hdfs tests 159m 29s Tests passed in hadoop-hdfs.     208m 56s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741031/HDFS-8462-04.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 445b132 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11434/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11434/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11434/console This message was automatically generated.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        The failure "Findbugs (version ) appears to be broken on trunk." is not related to the patch applied , Akira Ajisaka please process

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - The failure "Findbugs (version ) appears to be broken on trunk." is not related to the patch applied , Akira Ajisaka please process
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jagadesh Kiran N for updating the patch. One comment:

        TestOfflineImageViewerForXAttr.java
            try (DistributedFileSystem hdfs = cluster.getFileSystem()) {
        

        You don't need to use try-with-resources in the method. cluster.shutdown() will close its FileSystem.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jagadesh Kiran N for updating the patch. One comment: TestOfflineImageViewerForXAttr.java try (DistributedFileSystem hdfs = cluster.getFileSystem()) { You don't need to use try-with-resources in the method. cluster.shutdown() will close its FileSystem.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Hi Akira Ajisaka updated the patch , pls review

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Hi Akira Ajisaka updated the patch , pls review
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        I think it makes sense to treat changes as a feature itself as these operation were not supported in Offline Image viewer earlier. What's is your opinion, Vinayakumar B , Akira Ajisaka ?

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - I think it makes sense to treat changes as a feature itself as these operation were not supported in Offline Image viewer earlier. What's is your opinion, Vinayakumar B , Akira Ajisaka ?
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 21m 2s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 30s There were no new javac warning messages.
        +1 javadoc 9m 39s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 0s Site still builds.
        +1 checkstyle 2m 15s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 18s Pre-build of native portion
        +1 hdfs tests 161m 23s Tests passed in hadoop-hdfs.
            213m 54s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741569/HDFS-8462-05.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / 2ba6465
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11462/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11462/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11462/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 21m 2s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 3m 0s Site still builds. +1 checkstyle 2m 15s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 18s Pre-build of native portion +1 hdfs tests 161m 23s Tests passed in hadoop-hdfs.     213m 54s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741569/HDFS-8462-05.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 2ba6465 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11462/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11462/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11462/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        IMO, Offline Image viewer itself is a feature, which already present, but supporting additional operations in already existing Offline Image viewer is an Improvement.

        Show
        vinayrpet Vinayakumar B added a comment - IMO, Offline Image viewer itself is a feature, which already present, but supporting additional operations in already existing Offline Image viewer is an Improvement.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Jagadesh Kiran N for updating the patch.

        TestOfflineImageViewerForXAttr.java
            cluster = new MiniDFSCluster.Builder(conf).build();
            cluster.waitActive();
        

        cluster.shutdown() should be called if the cluster fails to become active. Would you please move the codes into try clause? I'm +1 if that is addressed.

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Jagadesh Kiran N for updating the patch. TestOfflineImageViewerForXAttr.java cluster = new MiniDFSCluster.Builder(conf).build(); cluster.waitActive(); cluster.shutdown() should be called if the cluster fails to become active. Would you please move the codes into try clause? I'm +1 if that is addressed.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        IMO, Offline Image viewer itself is a feature, which already present, but supporting additional operations in already existing Offline Image viewer is an Improvement.

        Agree.

        Show
        ajisakaa Akira Ajisaka added a comment - IMO, Offline Image viewer itself is a feature, which already present, but supporting additional operations in already existing Offline Image viewer is an Improvement. Agree.
        Hide
        jagadesh.kiran Jagadesh Kiran N added a comment -

        Attached the patch Akira Ajisaka ,please review

        Show
        jagadesh.kiran Jagadesh Kiran N added a comment - Attached the patch Akira Ajisaka ,please review
        Hide
        ajisakaa Akira Ajisaka added a comment -

        The latest patch looks good to me. +1 pending Jenkins.

        Show
        ajisakaa Akira Ajisaka added a comment - The latest patch looks good to me. +1 pending Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 20m 54s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 40s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 site 3m 0s Site still builds.
        +1 checkstyle 2m 12s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
        +1 findbugs 3m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 native 3m 14s Pre-build of native portion
        +1 hdfs tests 161m 55s Tests passed in hadoop-hdfs.
            214m 10s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741820/HDFS-8462-06.patch
        Optional Tests javadoc javac unit findbugs checkstyle site
        git revision trunk / a815cc1
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11485/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11485/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11485/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 54s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 3m 0s Site still builds. +1 checkstyle 2m 12s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 3m 15s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion +1 hdfs tests 161m 55s Tests passed in hadoop-hdfs.     214m 10s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741820/HDFS-8462-06.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / a815cc1 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11485/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11485/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11485/console This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        I've committed this to trunk and branch-2. Thanks Jagadesh Kiran N for the contribution!

        Show
        ajisakaa Akira Ajisaka added a comment - I've committed this to trunk and branch-2. Thanks Jagadesh Kiran N for the contribution!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8067 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8067/)
        HDFS-8462. Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8067 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8067/ ) HDFS-8462 . Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #240 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/240/)
        HDFS-8462. Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #240 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/240/ ) HDFS-8462 . Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #970 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/970/)
        HDFS-8462. Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #970 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/970/ ) HDFS-8462 . Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #229 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/229/)
        HDFS-8462. Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #229 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/229/ ) HDFS-8462 . Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #238 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/238/)
        HDFS-8462. Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #238 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/238/ ) HDFS-8462 . Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2168 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2168/)
        HDFS-8462. Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2168 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2168/ ) HDFS-8462 . Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2186/)
        HDFS-8462. Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java
        • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2186/ ) HDFS-8462 . Implement GETXATTRS and LISTXATTRS operations for WebImageViewer. Contributed by Jagadesh Kiran N. (aajisaka: rev bc433908d35758ff0a7225cd6f5662959ef4d294) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewerForXAttr.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsImageViewer.md hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageLoader.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

          People

          • Assignee:
            jagadesh.kiran Jagadesh Kiran N
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development