Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8404

Pending block replication can get stuck using older genstamp

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      If an under-replicated block gets into the pending-replication list, but later the genstamp of that block ends up being newer than the one originally submitted for replication, the block will fail replication until the NN is restarted.

      It will be safer if processPendingReplications() gets up-to-date blockinfo before resubmitting replication work.

      1. HDFS-8404-v0.patch
        7 kB
        Nathan Roberts
      2. HDFS-8404-v1.patch
        7 kB
        Nathan Roberts

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 47s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        -1 javac 1m 35s The patch appears to cause the build to fail.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12732974/HDFS-8404-v0.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 09fe16f
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10988/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 47s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. -1 javac 1m 35s The patch appears to cause the build to fail. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732974/HDFS-8404-v0.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 09fe16f Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10988/console This message was automatically generated.
        Hide
        kihwal Kihwal Lee added a comment -

        getBlockReplication() got renamed recently.

        Show
        kihwal Kihwal Lee added a comment - getBlockReplication() got renamed recently.
        Hide
        nroberts Nathan Roberts added a comment -

        Thanks Kihwal Lee. Updated based on latest trunk.

        Show
        nroberts Nathan Roberts added a comment - Thanks Kihwal Lee . Updated based on latest trunk.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 34s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 33s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 2m 11s The applied patch generated 1 new checkstyle issues (total was 209, now 208).
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 3m 0s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 native 3m 13s Pre-build of native portion
        +1 hdfs tests 170m 1s Tests passed in hadoop-hdfs.
            212m 32s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12733158/HDFS-8404-v1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 03a293a
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11005/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11005/artifact/patchprocess/whitespace.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11005/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11005/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11005/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 11s The applied patch generated 1 new checkstyle issues (total was 209, now 208). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 0s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 13s Pre-build of native portion +1 hdfs tests 170m 1s Tests passed in hadoop-hdfs.     212m 32s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733158/HDFS-8404-v1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 03a293a checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11005/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11005/artifact/patchprocess/whitespace.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11005/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11005/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11005/console This message was automatically generated.
        Hide
        kihwal Kihwal Lee added a comment -

        +1 the patch looks good.

        Show
        kihwal Kihwal Lee added a comment - +1 the patch looks good.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7865 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7865/)
        HDFS-8404. Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7865 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7865/ ) HDFS-8404 . Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java
        Hide
        kihwal Kihwal Lee added a comment -

        Committed to trunk, branch-2 and branch-2.7. Thanks for fixing this, Nathan.

        Show
        kihwal Kihwal Lee added a comment - Committed to trunk, branch-2 and branch-2.7. Thanks for fixing this, Nathan.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/202/)
        HDFS-8404. Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/202/ ) HDFS-8404 . Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #933 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/933/)
        HDFS-8404. Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #933 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/933/ ) HDFS-8404 . Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2131 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2131/)
        HDFS-8404. Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2131 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2131/ ) HDFS-8404 . Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/191/)
        HDFS-8404. Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/191/ ) HDFS-8404 . Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #201 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/201/)
        HDFS-8404. Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #201 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/201/ ) HDFS-8404 . Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2149 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2149/)
        HDFS-8404. Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2149 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2149/ ) HDFS-8404 . Pending block replication can get stuck using older genstamp. Contributed by Nathan Roberts. (kihwal: rev 8860e352c394372e4eb3ebdf82ea899567f34e4e) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestPendingReplication.java
        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Sangjin Lee backported this to 2.6.1 after fixing minor issues.

        I just pushed the commit to 2.6.1 after running compilation and TestPendingReplication which changed in the patch.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Sangjin Lee backported this to 2.6.1 after fixing minor issues. I just pushed the commit to 2.6.1 after running compilation and TestPendingReplication which changed in the patch.

          People

          • Assignee:
            nroberts Nathan Roberts
            Reporter:
            nroberts Nathan Roberts
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development