[HDFS-8344] NameNode doesn't recover lease for files with missing blocks

• Type: Bug
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.7.0
• Component/s: namenode
• Release Note: Allow a configuration to specify the maximum number of recovery attempts for blocks under construction.
• Assignee: Unassigned
• Reporter: Ravi Prakash
• Created: 07/May/15 17:17
• Updated: 02/Oct/19 17:14

Description

I found another(?) instance in which the lease is not recovered. This is reproducible easily on a pseudo-distributed single node cluster

1. Before you start it helps if you set. This is not necessary, but simply reduces how long you have to wait

         public static final long LEASE_SOFTLIMIT_PERIOD = 30 * 1000;
         public static final long LEASE_HARDLIMIT_PERIOD = 2 * LEASE_SOFTLIMIT_PERIOD;
   

2. Client starts to write a file. (could be less than 1 block, but it hflushed so some of the data has landed on the datanodes) (I'm copying the client code I am using. I generate a jar and run it using $ hadoop jar TestHadoop.jar)
3. Client crashes. (I simulate this by kill -9 the $(hadoop jar TestHadoop.jar) process after it has printed "Wrote to the bufferedWriter"
4. Shoot the datanode. (Since I ran on a pseudo-distributed cluster, there was only 1)

I believe the lease should be recovered and the block should be marked missing. However this is not happening. The lease is never recovered.
The effect of this bug for us was that nodes could not be decommissioned cleanly. Although we knew that the client had crashed, the Namenode never released the leases (even after restarting the Namenode) (even months afterwards). There are actually several other cases too where we don't consider what happens if ALL the datanodes die while the file is being written, but I am going to punt on that for another time.

Issue Links

• is related to: HDFS-8406 Lease recovery continually failed
• relates to: HDFS-8498 Blocks can be committed with wrong size
• relates to: HDFS-7342 Lease Recovery doesn't happen some times
• relates to: HDFS-8999 Allow a file to be closed with COMMITTED but not yet COMPLETE blocks.
• relates to: HDFS-4882 Prevent the Namenode's LeaseManager from looping forever in checkLeases
• relates to: HDFS-9232 Shouldn't start block recovery if block has no enough replicas