Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8270

create() always retried with hardcoded timeout when file already exists with open lease

    Details

    • Hadoop Flags:
      Reviewed
    • Release Note:
      Proxy level retries will not be done on AlreadyBeingCreatedExeption for create() op.

      Description

      In Hbase we stumbled on unexpected behaviour, which could
      break things.
      HDFS-6478 fixed wrong exception
      translation, but that apparently led to unexpected bahaviour:
      clients trying to create file without override=true will be forced
      to retry hardcoded amount of time (60 seconds).
      That could break or slowdown systems, that use filesystem
      for locks (like hbase fsck did, and we got it broken HBASE-13574).

      We should make this behaviour configurable, do client really need
      to wait lease timeout to be sure that file doesn't exists, or it it should
      be enough to fail fast.

      1. HDFS-8270.1.patch
        6 kB
        J.Andreina
      2. HDFS-8270.2.patch
        8 kB
        J.Andreina
      3. HDFS-8270.3.patch
        9 kB
        J.Andreina
      4. HDFS-8270-branch-2.6-v3.patch
        3 kB
        Chris Trezzo
      5. HDFS-8270-branch-2.7-03.patch
        5 kB
        Vinayakumar B

        Issue Links

          Activity

          Hide
          andreina J.Andreina added a comment -

          I would like to take up this issue
          Please let me know if you are already started on this

          Show
          andreina J.Andreina added a comment - I would like to take up this issue Please let me know if you are already started on this
          Hide
          octo47 Andrey Stepachev added a comment -

          J.Andreina please, do it. I didn't start it yet.

          Show
          octo47 Andrey Stepachev added a comment - J.Andreina please, do it. I didn't start it yet.
          Hide
          andreina J.Andreina added a comment -

          Thanks Andrey Stepachev. Iam assigning the issue to me. Will soon update the patch.

          Show
          andreina J.Andreina added a comment - Thanks Andrey Stepachev . Iam assigning the issue to me. Will soon update the patch.
          Hide
          jingzhao Jing Zhao added a comment -

          I think we can use HDFS-6697 to make the lease soft and hard limits configurable, and make retry times configurable as well.

          Show
          jingzhao Jing Zhao added a comment - I think we can use HDFS-6697 to make the lease soft and hard limits configurable, and make retry times configurable as well.
          Hide
          andreina J.Andreina added a comment -

          Thanks Jing Zhao for your suggestion.

          But I have one doubt on this issue:

          In NonHA, If client tries to create the same file, which is already exists and open, then NameNode was throwing already being created exception immediately. For NonHA case, Retry policy was added to retry 5 times, each time after 60 sec(SOFT_LEASE_TIMEOUT).

          However this retry was not working until HDFS-6478 fixed this.

          This led to behavior change and call will retry upto 5 min, before failing.
          Due to this downstream projects are facing issues. HBase reported it in HDFS-8270.

          Now my doubt is, Is retry of upto 5 mins (or a configurable retry time ) for AlreadyBeingCreatedException is really necessary in NonHA case?
          Whether waiting for a create operation failure is correct?

          Show
          andreina J.Andreina added a comment - Thanks Jing Zhao for your suggestion. But I have one doubt on this issue: In NonHA, If client tries to create the same file, which is already exists and open, then NameNode was throwing already being created exception immediately. For NonHA case, Retry policy was added to retry 5 times, each time after 60 sec(SOFT_LEASE_TIMEOUT). However this retry was not working until HDFS-6478 fixed this. This led to behavior change and call will retry upto 5 min, before failing. Due to this downstream projects are facing issues. HBase reported it in HDFS-8270 . Now my doubt is , Is retry of upto 5 mins (or a configurable retry time ) for AlreadyBeingCreatedException is really necessary in NonHA case? Whether waiting for a create operation failure is correct?
          Hide
          vinayrpet Vinayakumar B added a comment -

          This behaviour is only with NonHA. In HA it wont retry for AlreadyBeingCreatedException.

          I see it strange. Retry for 5 min,. thats really not acceptable.

          IMHO, by changing the SOFT_LEASE_TIMEOUT and and number of retries although we just working around this problem, but also changing the lease behaviour itself.
          If this configurations changed only in client side to small value ( ex: 200ms), Same exception will be thrown as Lease still exists at NN.

          Why to keep this behaviour change only in case of Non-HA?

          Any thoughts?

          Show
          vinayrpet Vinayakumar B added a comment - This behaviour is only with NonHA. In HA it wont retry for AlreadyBeingCreatedException . I see it strange. Retry for 5 min,. thats really not acceptable. IMHO, by changing the SOFT_LEASE_TIMEOUT and and number of retries although we just working around this problem, but also changing the lease behaviour itself. If this configurations changed only in client side to small value ( ex: 200ms), Same exception will be thrown as Lease still exists at NN. Why to keep this behaviour change only in case of Non-HA? Any thoughts?
          Hide
          octo47 Andrey Stepachev added a comment -

          I'd remove that at all.
          I think that this retries can be useful in case of dead client holding lease,
          so I think the idea was to wait to be sure, that file really not exists anymore.

          But it seems should be userlevel implementation, not hdfs level, we should
          refuse file creation immediately.

          Show
          octo47 Andrey Stepachev added a comment - I'd remove that at all. I think that this retries can be useful in case of dead client holding lease, so I think the idea was to wait to be sure, that file really not exists anymore. But it seems should be userlevel implementation, not hdfs level, we should refuse file creation immediately.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Hi Uma Maheswara Rao G you have thoughts about this?

          Show
          vinayrpet Vinayakumar B added a comment - Hi Uma Maheswara Rao G you have thoughts about this?
          Hide
          andreina J.Andreina added a comment -

          Attached an initial patch.
          Please review and provide feedback.

          Show
          andreina J.Andreina added a comment - Attached an initial patch. Please review and provide feedback.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 37s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 28s There were no new javac warning messages.
          +1 javadoc 9m 35s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 17s The applied patch generated 4 new checkstyle issues (total was 145, now 146).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 37s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 13s Pre-build of native portion
          -1 hdfs tests 160m 38s Tests failed in hadoop-hdfs.
              203m 29s  



          Reason Tests
          Failed unit tests hadoop.hdfs.TestDFSClientRetries
            hadoop.hdfs.TestIsMethodSupported
            hadoop.hdfs.server.namenode.TestCheckpoint



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12735834/HDFS-8270.1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 50eeea1
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11150/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11150/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11150/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11150/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 37s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 17s The applied patch generated 4 new checkstyle issues (total was 145, now 146). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 37s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 13s Pre-build of native portion -1 hdfs tests 160m 38s Tests failed in hadoop-hdfs.     203m 29s   Reason Tests Failed unit tests hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.TestIsMethodSupported   hadoop.hdfs.server.namenode.TestCheckpoint Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735834/HDFS-8270.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 50eeea1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11150/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11150/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11150/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11150/console This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Seems like default retries also got removed.
          Client is not retrying for even connect exceptions.

          Just following changes will do IMO

          in NameNodeProxies#createNNProxyWithClientProtocol(..) inside withRetries if block, do the below changes. Let everything else be same.

               if (withRetries) { // create the proxy with retries
           
          -      RetryPolicy createPolicy = RetryPolicies
          -          .retryUpToMaximumCountWithFixedSleep(5,
          -              HdfsServerConstants.LEASE_SOFTLIMIT_PERIOD, TimeUnit.MILLISECONDS);
          -    
          -      Map<Class<? extends Exception>, RetryPolicy> remoteExceptionToPolicyMap 
          -                 = new HashMap<Class<? extends Exception>, RetryPolicy>();
          -      remoteExceptionToPolicyMap.put(AlreadyBeingCreatedException.class,
          -          createPolicy);
          -
          -      RetryPolicy methodPolicy = RetryPolicies.retryByRemoteException(
          -          defaultPolicy, remoteExceptionToPolicyMap);
                 Map<String, RetryPolicy> methodNameToPolicyMap 
                            = new HashMap<String, RetryPolicy>();
          -    
          -      methodNameToPolicyMap.put("create", methodPolicy);
           
                 ClientProtocol translatorProxy =
                   new ClientNamenodeProtocolTranslatorPB(proxy);
          
          Show
          vinayrpet Vinayakumar B added a comment - Seems like default retries also got removed. Client is not retrying for even connect exceptions. Just following changes will do IMO in NameNodeProxies#createNNProxyWithClientProtocol(..) inside withRetries if block, do the below changes. Let everything else be same. if (withRetries) { // create the proxy with retries - RetryPolicy createPolicy = RetryPolicies - .retryUpToMaximumCountWithFixedSleep(5, - HdfsServerConstants.LEASE_SOFTLIMIT_PERIOD, TimeUnit.MILLISECONDS); - - Map< Class <? extends Exception>, RetryPolicy> remoteExceptionToPolicyMap - = new HashMap< Class <? extends Exception>, RetryPolicy>(); - remoteExceptionToPolicyMap.put(AlreadyBeingCreatedException.class, - createPolicy); - - RetryPolicy methodPolicy = RetryPolicies.retryByRemoteException( - defaultPolicy, remoteExceptionToPolicyMap); Map< String , RetryPolicy> methodNameToPolicyMap = new HashMap< String , RetryPolicy>(); - - methodNameToPolicyMap.put( "create" , methodPolicy); ClientProtocol translatorProxy = new ClientNamenodeProtocolTranslatorPB(proxy);
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          This came up on the dev lists. Did a quick scan. Seems like HDFS-6478 which broke the functionality went into 2.6.0. Given that, I don't this should block 2.7.1, but if you can get it in in a day or two, I'm all good.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - This came up on the dev lists. Did a quick scan. Seems like HDFS-6478 which broke the functionality went into 2.6.0. Given that, I don't this should block 2.7.1, but if you can get it in in a day or two, I'm all good.
          Hide
          jingzhao Jing Zhao added a comment -

          Totally agree this retry logic should not be hardcoded inside of the proxy creation code. The only concern is whether directly removing this retry may break some existing applications which depend on this retry. If yes we may have to make this retry configurable and by default we enable it.

          Show
          jingzhao Jing Zhao added a comment - Totally agree this retry logic should not be hardcoded inside of the proxy creation code. The only concern is whether directly removing this retry may break some existing applications which depend on this retry. If yes we may have to make this retry configurable and by default we enable it.
          Hide
          vinayrpet Vinayakumar B added a comment -

          The only concern is whether directly removing this retry may break some existing applications which depend on this retry.

          I agree with you. But, till HDFS-6478 was in, this retry was not working AFAIK, and only after this real issue of waiting for long time started showing up. I will re-confirm again anyway. In that case I don't think removing would be problem to existing applications.

          Show
          vinayrpet Vinayakumar B added a comment - The only concern is whether directly removing this retry may break some existing applications which depend on this retry. I agree with you. But, till HDFS-6478 was in, this retry was not working AFAIK, and only after this real issue of waiting for long time started showing up. I will re-confirm again anyway. In that case I don't think removing would be problem to existing applications.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Yes, before HDFS-6478, retry for create() on AlreadyBeingCreatedException was not working. So we can go ahead and remove the retry IMO.

          Show
          vinayrpet Vinayakumar B added a comment - Yes, before HDFS-6478 , retry for create() on AlreadyBeingCreatedException was not working. So we can go ahead and remove the retry IMO.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Hi J.Andreina,
          In the patch, Instead of removing all retries, need to remove retries for only method-exception. Default retries should be there to retry on connect exceptions / namenode restart cases.

          So following changes in would be enough in NameNodeProxies.java.

          @@ -442,22 +440,9 @@ private static ClientProtocol createNNProxyWithClientProtocol(
           
               if (withRetries) { // create the proxy with retries
           
          -      RetryPolicy createPolicy = RetryPolicies
          -          .retryUpToMaximumCountWithFixedSleep(5,
          -              HdfsServerConstants.LEASE_SOFTLIMIT_PERIOD, TimeUnit.MILLISECONDS);
          -    
          -      Map<Class<? extends Exception>, RetryPolicy> remoteExceptionToPolicyMap 
          -                 = new HashMap<Class<? extends Exception>, RetryPolicy>();
          -      remoteExceptionToPolicyMap.put(AlreadyBeingCreatedException.class,
          -          createPolicy);
          -
          -      RetryPolicy methodPolicy = RetryPolicies.retryByRemoteException(
          -          defaultPolicy, remoteExceptionToPolicyMap);
                 Map<String, RetryPolicy> methodNameToPolicyMap 
                            = new HashMap<String, RetryPolicy>();
               
          -      methodNameToPolicyMap.put("create", methodPolicy);
          -
                 ClientProtocol translatorProxy =
                   new ClientNamenodeProtocolTranslatorPB(proxy);
                 return (ClientProtocol) RetryProxy.create(

          Other changes in other files is fine. I think you can also remove the configuration key from DFSConfigKeys.java as its nowhere used after the patch.

          Show
          vinayrpet Vinayakumar B added a comment - Hi J.Andreina , In the patch, Instead of removing all retries, need to remove retries for only method-exception. Default retries should be there to retry on connect exceptions / namenode restart cases. So following changes in would be enough in NameNodeProxies.java. @@ -442,22 +440,9 @@ private static ClientProtocol createNNProxyWithClientProtocol( if (withRetries) { // create the proxy with retries - RetryPolicy createPolicy = RetryPolicies - .retryUpToMaximumCountWithFixedSleep(5, - HdfsServerConstants.LEASE_SOFTLIMIT_PERIOD, TimeUnit.MILLISECONDS); - - Map< Class <? extends Exception>, RetryPolicy> remoteExceptionToPolicyMap - = new HashMap< Class <? extends Exception>, RetryPolicy>(); - remoteExceptionToPolicyMap.put(AlreadyBeingCreatedException.class, - createPolicy); - - RetryPolicy methodPolicy = RetryPolicies.retryByRemoteException( - defaultPolicy, remoteExceptionToPolicyMap); Map< String , RetryPolicy> methodNameToPolicyMap = new HashMap< String , RetryPolicy>(); - methodNameToPolicyMap.put( "create" , methodPolicy); - ClientProtocol translatorProxy = new ClientNamenodeProtocolTranslatorPB(proxy); return (ClientProtocol) RetryProxy.create( Other changes in other files is fine. I think you can also remove the configuration key from DFSConfigKeys.java as its nowhere used after the patch.
          Hide
          andreina J.Andreina added a comment -

          Thanks all for the review comments.
          Vinayakumar B , I have updated the patch as per your suggestion.
          Please review the patch.

          Show
          andreina J.Andreina added a comment - Thanks all for the review comments. Vinayakumar B , I have updated the patch as per your suggestion. Please review the patch.
          Hide
          vinayrpet Vinayakumar B added a comment -

          +1, LGTM

          Will wait for others to give their opinion before commit.
          Jenkins also pending

          Show
          vinayrpet Vinayakumar B added a comment - +1, LGTM Will wait for others to give their opinion before commit. Jenkins also pending
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 49s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 32s There were no new javac warning messages.
          +1 javadoc 9m 41s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 16s The applied patch generated 3 new checkstyle issues (total was 562, now 563).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 21s Pre-build of native portion
          +1 hdfs tests 162m 21s Tests passed in hadoop-hdfs.
              209m 20s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12736799/HDFS-8270.2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 990078b
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11199/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11199/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11199/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11199/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 49s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 41s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 16s The applied patch generated 3 new checkstyle issues (total was 562, now 563). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 21s Pre-build of native portion +1 hdfs tests 162m 21s Tests passed in hadoop-hdfs.     209m 20s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12736799/HDFS-8270.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 990078b checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11199/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11199/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11199/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11199/console This message was automatically generated.
          Hide
          andreina J.Andreina added a comment -

          Fixed checkstyle error and attached updated patch.
          Please review.

          Show
          andreina J.Andreina added a comment - Fixed checkstyle error and attached updated patch. Please review.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 7s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 29s There were no new javac warning messages.
          +1 javadoc 9m 50s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 2m 19s The applied patch generated 1 new checkstyle issues (total was 562, now 561).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 13s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 native 3m 14s Pre-build of native portion
          +1 hdfs tests 161m 5s Tests passed in hadoop-hdfs.
              207m 50s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12737071/HDFS-8270.3.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / c1d50a9
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11215/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11215/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11215/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11215/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 7s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 50s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 2m 19s The applied patch generated 1 new checkstyle issues (total was 562, now 561). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 13s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion +1 hdfs tests 161m 5s Tests passed in hadoop-hdfs.     207m 50s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12737071/HDFS-8270.3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / c1d50a9 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11215/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11215/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11215/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11215/console This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          In that case I don't think removing would be problem to existing applications.

          Yeah, I also confirmed with Vikram Dixit K about Hive. +1 for removing this retry.

          Show
          jingzhao Jing Zhao added a comment - In that case I don't think removing would be problem to existing applications. Yeah, I also confirmed with Vikram Dixit K about Hive. +1 for removing this retry.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Latest patch looks good to me.
          Checkstyle is related to file length.

          Committing soon.

          Show
          vinayrpet Vinayakumar B added a comment - Latest patch looks good to me. Checkstyle is related to file length. Committing soon.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Thanks Jing Zhao for the confirmation.

          Show
          vinayrpet Vinayakumar B added a comment - Thanks Jing Zhao for the confirmation.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Committed to trunk, branch-2 and branch-2.7

          Thanks J.Andreina for taking up the issue and contributing the fix.
          Thanks Jing Zhao, Andrey Stepachev for discussions.

          cc: Vinod Kumar Vavilapalli

          There was a conflict while cherry picking to branch-2.7 as HDFS-8403 was not available in branch-2.7.
          So attaching the branch-2.7 committed patch for reference.

          Show
          vinayrpet Vinayakumar B added a comment - Committed to trunk, branch-2 and branch-2.7 Thanks J.Andreina for taking up the issue and contributing the fix. Thanks Jing Zhao , Andrey Stepachev for discussions. cc: Vinod Kumar Vavilapalli There was a conflict while cherry picking to branch-2.7 as HDFS-8403 was not available in branch-2.7. So attaching the branch-2.7 committed patch for reference.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7948 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7948/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7948 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7948/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          Hide
          andreina J.Andreina added a comment -

          Thanks all for the review comments.
          Thanks Vinayakumar B for the commit.

          Show
          andreina J.Andreina added a comment - Thanks all for the review comments. Thanks Vinayakumar B for the commit.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #217 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/217/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #217 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/217/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #947 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/947/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #947 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/947/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2163 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2163/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2163 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2163/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/215/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/215/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2145 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2145/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2145 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2145/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #206 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/206/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #206 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/206/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 54f83d9bd917e8641e902c5f0695e65ded472f9a) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/NameNodeProxies.java
          Hide
          ctrezzo Chris Trezzo added a comment -

          Branch 2.6 patch attached. This was a trivial backport from the 2.7 patch. I applied it and ran TestFileCreation (which passed).

          Show
          ctrezzo Chris Trezzo added a comment - Branch 2.6 patch attached. This was a trivial backport from the 2.7 patch. I applied it and ran TestFileCreation (which passed).
          Hide
          vinayrpet Vinayakumar B added a comment -

          Cherry-picked to 2.6.1

          Show
          vinayrpet Vinayakumar B added a comment - Cherry-picked to 2.6.1
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8305 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8305/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8305 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8305/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #284 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/284/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #284 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/284/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2233 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2233/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2233 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2233/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2214 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2214/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2214 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2214/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #276 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/276/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #276 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/276/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #288 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/288/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #288 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/288/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1018 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1018/)
          HDFS-8270. create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1018 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1018/ ) HDFS-8270 . create() always retried with hardcoded timeout when file already exists with open lease (Contributed by J.Andreina) (vinayakumarb: rev 84bf71295a5e52b2a7bb69440a885a25bc75f544) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          This was marked as committed in 2.6.1 but it wasn't actually in the 2.6.1 branch. Presumably because it got committed to 2.6 and by that time I already created the 2.6.1 branch.

          I just pushed the fix to the right 2.6.1 branch. Ran compilation and TestFileCreation before the push.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - This was marked as committed in 2.6.1 but it wasn't actually in the 2.6.1 branch. Presumably because it got committed to 2.6 and by that time I already created the 2.6.1 branch. I just pushed the fix to the right 2.6.1 branch. Ran compilation and TestFileCreation before the push.

            People

            • Assignee:
              andreina J.Andreina
              Reporter:
              octo47 Andrey Stepachev
            • Votes:
              1 Vote for this issue
              Watchers:
              16 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development