Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-823

In Checkpointer the getImage servlet is added to public rather than internal servlet list

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0, 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Checkpointer.java:99

          httpServer.addServlet("getimage", "/getimage", GetImageServlet.class);

      This should be addInternalServlet, as it is for Namenode to ensure this servlet does not get filtered.

      1. HDFS-823.patch
        0.8 kB
        Jakob Homan

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #94 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/94/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #94 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/94/ )
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #148 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/148/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #148 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/148/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #145 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/145/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #145 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/145/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #170 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/170/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #170 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/170/ )
        Hide
        Jakob Homan added a comment -

        I have committed this to trunk and .21. Resolving issue as fixed.

        Show
        Jakob Homan added a comment - I have committed this to trunk and .21. Resolving issue as fixed.
        Hide
        Jakob Homan added a comment -

        Looks like Hudson is falling down on the job again. Manual test-patch:

        [exec] -1 overall.  
        [exec] 
        [exec]     +1 @author.  The patch does not contain any @author tags.
        [exec] 
        [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
        [exec]                         Please justify why no new tests are needed for this patch.
        [exec]                         Also please list what manual steps were performed to verify this patch.
        [exec] 
        [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
        [exec] 
        [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
        [exec] 
        [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
        [exec] 
        [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.

        No tests as explained above. Tests all pass locally except known-bad TestHDFSTrash. Will commit to trunk and 21.

        Show
        Jakob Homan added a comment - Looks like Hudson is falling down on the job again. Manual test-patch: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. No tests as explained above. Tests all pass locally except known-bad TestHDFSTrash. Will commit to trunk and 21.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Jakob Homan added a comment -

        submitting patch.

        Show
        Jakob Homan added a comment - submitting patch.
        Hide
        Jakob Homan added a comment -

        Trivial patch. No tests as is using filtering, which we aren't using right now.

        Show
        Jakob Homan added a comment - Trivial patch. No tests as is using filtering, which we aren't using right now.

          People

          • Assignee:
            Jakob Homan
            Reporter:
            Jakob Homan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development