Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8229

LAZY_PERSIST file gets deleted after NameNode restart.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      2015-04-20 10:26:55,180 WARN org.apache.hadoop.hdfs.server.namenode.FSNamesystem: Removing lazyPersist file /LAZY_PERSIST/smallfile with no replicas.
      

      After namenode restart and before DN's registration if LazyPersistFileScrubber will run then it will delete Lazy persist file.

      1. HDFS-8229_1.patch
        4 kB
        Surendra Singh Lilhore
      2. HDFS-8229_2.patch
        5 kB
        Surendra Singh Lilhore
      3. HDFS-8229.patch
        2 kB
        Surendra Singh Lilhore

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2131 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2131/)
          HDFS-8229. LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2131 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2131/ ) HDFS-8229 . LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #182 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/182/)
          HDFS-8229. LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #182 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/182/ ) HDFS-8229 . LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2113 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2113/)
          HDFS-8229. LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2113 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2113/ ) HDFS-8229 . LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/172/)
          HDFS-8229. LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/172/ ) HDFS-8229 . LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #915 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/915/)
          HDFS-8229. LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #915 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/915/ ) HDFS-8229 . LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #181 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/181/)
          HDFS-8229. LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #181 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/181/ ) HDFS-8229 . LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #7716 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7716/)
          HDFS-8229. LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #7716 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7716/ ) HDFS-8229 . LAZY_PERSIST file gets deleted after NameNode restart. (Contributed by Surendra Singh Lilhore) (arp: rev 6f541edce0ed64bf316276715c4bc07794ff20ac) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/LazyPersistTestCase.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestLazyPersistFiles.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Committed to trunk and branch-2.

          Thanks for the contribution Surendra Singh Lilhore.

          Show
          arpitagarwal Arpit Agarwal added a comment - Committed to trunk and branch-2. Thanks for the contribution Surendra Singh Lilhore .
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 46s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 28s There were no new javac warning messages.
          +1 javadoc 9m 35s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 20s The applied patch generated 2 new checkstyle issues (total was 359, now 360).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 32s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 native 3m 12s Pre-build of native portion
          +1 hdfs tests 164m 32s Tests passed in hadoop-hdfs.
              206m 31s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12729442/HDFS-8229_2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 279958b
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10507/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10507/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10507/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10507/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 46s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 20s The applied patch generated 2 new checkstyle issues (total was 359, now 360). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 3s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 12s Pre-build of native portion +1 hdfs tests 164m 32s Tests passed in hadoop-hdfs.     206m 31s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729442/HDFS-8229_2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 279958b checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10507/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10507/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10507/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10507/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          The patch artifact directory has been removed!
          This is a fatal error for test-patch.sh. Aborting.
          Jenkins (node H3) information at https://builds.apache.org/job/PreCommit-HDFS-Build/10501/ may provide some hints.

          Show
          hadoopqa Hadoop QA added a comment - The patch artifact directory has been removed! This is a fatal error for test-patch.sh. Aborting. Jenkins (node H3) information at https://builds.apache.org/job/PreCommit-HDFS-Build/10501/ may provide some hints.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 25s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 29s There were no new javac warning messages.
          +1 javadoc 9m 35s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 5m 28s The applied patch generated 1 additional checkstyle issues.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
          -1 findbugs 3m 7s The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.
          +1 native 3m 12s Pre-build of native portion
          -1 hdfs tests 233m 19s Tests failed in hadoop-hdfs.
              279m 6s  



          Reason Tests
          FindBugs module:hadoop-hdfs
            Class org.apache.hadoop.hdfs.DataStreamer$LastException is not derived from an Exception, even though it is named as such At DataStreamer.java:from an Exception, even though it is named as such At DataStreamer.java:[lines 177-201]
          Failed unit tests hadoop.hdfs.server.namenode.TestDeleteRace
            hadoop.hdfs.TestClose
            hadoop.hdfs.TestDFSClientRetries
            hadoop.hdfs.TestQuota
            hadoop.hdfs.TestMultiThreadedHflush
            hadoop.hdfs.TestDFSOutputStream
            hadoop.hdfs.server.namenode.TestSaveNamespace
            hadoop.hdfs.server.datanode.TestBlockRecovery
            hadoop.cli.TestHDFSCLI
            hadoop.hdfs.TestFileLengthOnClusterRestart
            hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation
          Timed out tests org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache
            org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery
            org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
            org.apache.hadoop.hdfs.TestDataTransferProtocol



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12729442/HDFS-8229_2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / de9404f
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10482/artifact/patchprocess/checkstyle-result-diff.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/10482/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10482/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10482/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10482/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 25s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 28s The applied patch generated 1 additional checkstyle issues. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. -1 findbugs 3m 7s The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 native 3m 12s Pre-build of native portion -1 hdfs tests 233m 19s Tests failed in hadoop-hdfs.     279m 6s   Reason Tests FindBugs module:hadoop-hdfs   Class org.apache.hadoop.hdfs.DataStreamer$LastException is not derived from an Exception, even though it is named as such At DataStreamer.java:from an Exception, even though it is named as such At DataStreamer.java: [lines 177-201] Failed unit tests hadoop.hdfs.server.namenode.TestDeleteRace   hadoop.hdfs.TestClose   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.TestQuota   hadoop.hdfs.TestMultiThreadedHflush   hadoop.hdfs.TestDFSOutputStream   hadoop.hdfs.server.namenode.TestSaveNamespace   hadoop.hdfs.server.datanode.TestBlockRecovery   hadoop.cli.TestHDFSCLI   hadoop.hdfs.TestFileLengthOnClusterRestart   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation Timed out tests org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache   org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery   org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   org.apache.hadoop.hdfs.TestDataTransferProtocol Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729442/HDFS-8229_2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / de9404f checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10482/artifact/patchprocess/checkstyle-result-diff.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/10482/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10482/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10482/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10482/console This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1 for the patch. Thanks for the updates Surendra Singh Lilhore.

          I kicked off another pre-commit build since previous results look wrong.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1 for the patch. Thanks for the updates Surendra Singh Lilhore . I kicked off another pre-commit build since previous results look wrong.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 28s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 25s There were no new javac warning messages.
          +1 javadoc 9m 33s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 5m 27s The applied patch generated 1 additional checkstyle issues.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          -1 findbugs 3m 7s The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.
          +1 native 3m 11s Pre-build of native portion
          -1 hdfs tests 225m 54s Tests failed in hadoop-hdfs.
              271m 34s  



          Reason Tests
          FindBugs module:hadoop-hdfs
            Class org.apache.hadoop.hdfs.DataStreamer$LastException is not derived from an Exception, even though it is named as such At DataStreamer.java:from an Exception, even though it is named as such At DataStreamer.java:[lines 177-201]
          Failed unit tests hadoop.hdfs.server.namenode.TestDeleteRace
            hadoop.hdfs.TestClose
            hadoop.hdfs.TestDFSClientRetries
            hadoop.hdfs.TestQuota
            hadoop.hdfs.TestMultiThreadedHflush
            hadoop.hdfs.TestDFSOutputStream
            hadoop.hdfs.server.namenode.TestSaveNamespace
            hadoop.hdfs.server.datanode.TestBlockRecovery
            hadoop.cli.TestHDFSCLI
            hadoop.hdfs.TestFileLengthOnClusterRestart
            hadoop.hdfs.TestCrcCorruption
            hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation
          Timed out tests org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache
            org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery
            org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
            org.apache.hadoop.hdfs.TestDataTransferProtocol



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12729442/HDFS-8229_2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / f5b3847
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10475/artifact/patchprocess/checkstyle-result-diff.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/10475/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10475/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10475/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10475/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 28s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 25s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 27s The applied patch generated 1 additional checkstyle issues. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. -1 findbugs 3m 7s The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 native 3m 11s Pre-build of native portion -1 hdfs tests 225m 54s Tests failed in hadoop-hdfs.     271m 34s   Reason Tests FindBugs module:hadoop-hdfs   Class org.apache.hadoop.hdfs.DataStreamer$LastException is not derived from an Exception, even though it is named as such At DataStreamer.java:from an Exception, even though it is named as such At DataStreamer.java: [lines 177-201] Failed unit tests hadoop.hdfs.server.namenode.TestDeleteRace   hadoop.hdfs.TestClose   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.TestQuota   hadoop.hdfs.TestMultiThreadedHflush   hadoop.hdfs.TestDFSOutputStream   hadoop.hdfs.server.namenode.TestSaveNamespace   hadoop.hdfs.server.datanode.TestBlockRecovery   hadoop.cli.TestHDFSCLI   hadoop.hdfs.TestFileLengthOnClusterRestart   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation Timed out tests org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache   org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery   org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   org.apache.hadoop.hdfs.TestDataTransferProtocol Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729442/HDFS-8229_2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f5b3847 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10475/artifact/patchprocess/checkstyle-result-diff.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/10475/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10475/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10475/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10475/console This message was automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached new patch, please review.

          In test case I am not using getCorruptReplicaBlocksCount() API for counting corrupt blocks because of HDFS-8296

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached new patch, please review. In test case I am not using getCorruptReplicaBlocksCount() API for counting corrupt blocks because of HDFS-8296
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks, yes I will update the patch soon..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks, yes I will update the patch soon..
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks you are right. I missed that part. +1 for the fix.

          Do you want to take a shot at updating the test case?

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks you are right. I missed that part. +1 for the fix. Do you want to take a shot at updating the test case?
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Arpit Agarwal for review. I have one doubt, why we need to check isHaEnabled() and inActiveState() ??

          LazyPersistFileScrubber started by startActiveServices() and this API start services for active namenode only. Please correct me if I am wrong.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Arpit Agarwal for review. I have one doubt, why we need to check isHaEnabled() and inActiveState() ?? LazyPersistFileScrubber started by startActiveServices() and this API start services for active namenode only. Please correct me if I am wrong.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks for the update Surendra Singh Lilhore. We should also add a check for HA status. if isHaEnabled() then inActiveState() should be true. Sorry I should have mentioned that earlier.

          Also perhaps we can update the test case to make it more predictable. e.g. stop DNs, restart just the NN, wait until we see corrupt files and check they are not deleted.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks for the update Surendra Singh Lilhore . We should also add a check for HA status. if isHaEnabled() then inActiveState() should be true. Sorry I should have mentioned that earlier. Also perhaps we can update the test case to make it more predictable. e.g. stop DNs, restart just the NN, wait until we see corrupt files and check they are not deleted.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Arpit Agarwal thanks for review and suggestion. I have attached new patch, Please review.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Arpit Agarwal thanks for review and suggestion. I have attached new patch, Please review.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thank you for reporting this Surendra Singh Lilhore, good catch.

          A better fix is to check is to avoid deleting until the NN is out of safe mode.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thank you for reporting this Surendra Singh Lilhore , good catch. A better fix is to check is to avoid deleting until the NN is out of safe mode.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          After namenode start LazyPersistFileScrubber should wait for DN's registration and then it should do cleanup. For waiting DN's registration I think DFS_DATANODE_LAZY_WRITER_INTERVAL_SEC is enough if DN’s are running.

           try {
                    clearCorruptLazyPersistFiles();
                    Thread.sleep(scrubIntervalSec * 1000);
                  } catch (InterruptedException e) {
          

          Here thread should sleep for scrubIntervalSec seconds and then clear corrupt lazy persist files.

          Attached initial patch. Please review and give your suggestion.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - After namenode start LazyPersistFileScrubber should wait for DN's registration and then it should do cleanup. For waiting DN's registration I think DFS_DATANODE_LAZY_WRITER_INTERVAL_SEC is enough if DN’s are running. try { clearCorruptLazyPersistFiles(); Thread .sleep(scrubIntervalSec * 1000); } catch (InterruptedException e) { Here thread should sleep for scrubIntervalSec seconds and then clear corrupt lazy persist files. Attached initial patch. Please review and give your suggestion.

            People

            • Assignee:
              surendrasingh Surendra Singh Lilhore
              Reporter:
              surendrasingh Surendra Singh Lilhore
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development