Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8191

Fix byte to integer casting in SimulatedFSDataset#simulatedByte

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    1. HDFS-8191.000.patch
      2 kB
      Zhe Zhang
    2. HDFS-8191.001.patch
      8 kB
      Zhe Zhang
    3. HDFS-8191.002.patch
      8 kB
      Zhe Zhang
    4. HDFS-8191.003.patch
      8 kB
      Zhe Zhang
    5. HDFS-8191.003.patch
      8 kB
      Zhe Zhang

      Activity

      Hide
      zhz Zhe Zhang added a comment -

      The default upcasting from byte to integer will result in negative integers if the first bit of the byte is 1. This causes read() to return -1, indicating end of stream. This patch uses a byte mask for read() to always return the actual byte with value 0~255.

      Show
      zhz Zhe Zhang added a comment - The default upcasting from byte to integer will result in negative integers if the first bit of the byte is 1. This causes read() to return -1, indicating end of stream. This patch uses a byte mask for read() to always return the actual byte with value 0~255.
      Hide
      andrew.wang Andrew Wang added a comment -

      Thanks Zhe, this looks good, explanation makes sense too. Could we add a unit test though?

      Show
      andrew.wang Andrew Wang added a comment - Thanks Zhe, this looks good, explanation makes sense too. Could we add a unit test though?
      Hide
      hadoopqa Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12726721/HDFS-8191.000.patch
      against trunk revision 44872b7.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 1 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. There were no new javadoc warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

      org.apache.hadoop.hdfs.qjournal.client.TestQuorumJournalManager
      org.apache.hadoop.hdfs.server.datanode.TestSimulatedFSDataset

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10325//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10325//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726721/HDFS-8191.000.patch against trunk revision 44872b7. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.qjournal.client.TestQuorumJournalManager org.apache.hadoop.hdfs.server.datanode.TestSimulatedFSDataset Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10325//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10325//console This message is automatically generated.
      Hide
      zhz Zhe Zhang added a comment -

      Thanks Andrew for the review! Yes a unit test is a good idea.

      It turns out I need to refactor TestSimulatedFSDataset quite a bit to inject simulated books with negative block IDs. But I think the added negativeBlkID will be useful in the future as well.

      Both Jenkins failures pass locally.

      Show
      zhz Zhe Zhang added a comment - Thanks Andrew for the review! Yes a unit test is a good idea. It turns out I need to refactor TestSimulatedFSDataset quite a bit to inject simulated books with negative block IDs. But I think the added negativeBlkID will be useful in the future as well. Both Jenkins failures pass locally.
      Hide
      hadoopqa Hadoop QA added a comment -

      +1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12726801/HDFS-8191.001.patch
      against trunk revision d52de61.

      +1 @author. The patch does not contain any @author tags.

      +1 tests included. The patch appears to include 2 new or modified test files.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. There were no new javadoc warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

      Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10330//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10330//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726801/HDFS-8191.001.patch against trunk revision d52de61. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10330//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10330//console This message is automatically generated.
      Hide
      andrew.wang Andrew Wang added a comment -

      Couple notes:

      • Rather than adding another argument to addSomeBlocks, let's keep the one-arg form of addSomeBlocks and have it default negativeBlocks to false. Have a two-arg form just for testWriteRead.

      I'm not very happy with this test in general. Not exactly related to this change, but if you don't mind let's do a few small cleanups:

      • Make addSomeBlocks and blockIdToLen static
      • testWriteRead's "read" function, let's break it out into a new static function "readSomeBlocks" and put it by addSomeBlocks. The logic is heavily interlinked.
      Show
      andrew.wang Andrew Wang added a comment - Couple notes: Rather than adding another argument to addSomeBlocks, let's keep the one-arg form of addSomeBlocks and have it default negativeBlocks to false. Have a two-arg form just for testWriteRead. I'm not very happy with this test in general. Not exactly related to this change, but if you don't mind let's do a few small cleanups: Make addSomeBlocks and blockIdToLen static testWriteRead's "read" function, let's break it out into a new static function "readSomeBlocks" and put it by addSomeBlocks. The logic is heavily interlinked.
      Hide
      zhz Zhe Zhang added a comment -

      Thanks Andrew for the review!

      A addSomeBlocks with default positive IDs is a good way to minimize changes. The patch also removes the hard coded starting block ID (1).

      Show
      zhz Zhe Zhang added a comment - Thanks Andrew for the review! A addSomeBlocks with default positive IDs is a good way to minimize changes. The patch also removes the hard coded starting block ID (1).
      Hide
      andrew.wang Andrew Wang added a comment -

      testInjectionNonEmpty I think still is using the 3-arg when it could use the 2-arg addSomeBlocks. Might also consider reordering the addSomeBlock functions so it reads downwards in terms of what calls what, e.g. 1-arg then 2-arg then 3-arg.

      +1 anyway, these are pretty nitty.

      Show
      andrew.wang Andrew Wang added a comment - testInjectionNonEmpty I think still is using the 3-arg when it could use the 2-arg addSomeBlocks. Might also consider reordering the addSomeBlock functions so it reads downwards in terms of what calls what, e.g. 1-arg then 2-arg then 3-arg. +1 anyway, these are pretty nitty.
      Hide
      zhz Zhe Zhang added a comment -

      Thanks Andrew for the comment. Reordering sounds good. testInjectionNonEmpty uses the 3-arg addSomeBlocks because it needs to change the starting block ID. This is kind of hard to avoid. As you mentioned the code in this test class isn't too neat. It's probably because SimulateFSDataset isn't currently heavily used. The EC branch will make more use of it; we should definitely revisit this code and refactor it.

      Show
      zhz Zhe Zhang added a comment - Thanks Andrew for the comment. Reordering sounds good. testInjectionNonEmpty uses the 3-arg addSomeBlocks because it needs to change the starting block ID. This is kind of hard to avoid. As you mentioned the code in this test class isn't too neat. It's probably because SimulateFSDataset isn't currently heavily used. The EC branch will make more use of it; we should definitely revisit this code and refactor it.
      Hide
      andrew.wang Andrew Wang added a comment -

      Missed that injection change, +1 again. Thanks for working on this Zhe, let's see what the shiny new test-patch says.

      Show
      andrew.wang Andrew Wang added a comment - Missed that injection change, +1 again. Thanks for working on this Zhe, let's see what the shiny new test-patch says.
      Hide
      andrew.wang Andrew Wang added a comment -

      I kicked the precommit, dunno why it didn't run.

      https://builds.apache.org/job/PreCommit-HDFS-Build/10363/

      Show
      andrew.wang Andrew Wang added a comment - I kicked the precommit, dunno why it didn't run. https://builds.apache.org/job/PreCommit-HDFS-Build/10363/
      Hide
      zhz Zhe Zhang added a comment -

      Thanks Andrew for reviewing again! Maybe the new shiny buildbot is too busy Attaching a duplicate 003 patch to trigger it.

      Show
      zhz Zhe Zhang added a comment - Thanks Andrew for reviewing again! Maybe the new shiny buildbot is too busy Attaching a duplicate 003 patch to trigger it.
      Hide
      hadoopqa Hadoop QA added a comment -



      +1 overall



      Vote Subsystem Runtime Comment
      0 pre-patch 5m 11s Pre-patch trunk compilation is healthy.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
      +1 whitespace 0m 0s The patch has no lines that end in whitespace.
      +1 javac 7m 37s There were no new javac warning messages.
      +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
      +1 checkstyle 5m 27s There were no new checkstyle issues.
      +1 install 1m 33s mvn install still works.
      +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
      +1 findbugs 3m 5s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
      +1 native 1m 21s Pre-build of native portion
      +1 hdfs tests 165m 15s Tests passed in hadoop-hdfs.
          190m 24s  



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12727467/HDFS-8191.003.patch
      Optional Tests javac unit findbugs checkstyle
      git revision trunk / ac281e3
      hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10363/artifact/patchprocess/testrun_hadoop-hdfs.txt
      Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10363/testReport/
      Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10363/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 11s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 37s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 5m 27s There were no new checkstyle issues. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 3m 5s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 1m 21s Pre-build of native portion +1 hdfs tests 165m 15s Tests passed in hadoop-hdfs.     190m 24s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727467/HDFS-8191.003.patch Optional Tests javac unit findbugs checkstyle git revision trunk / ac281e3 hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10363/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10363/testReport/ Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10363/console This message was automatically generated.
      Hide
      hadoopqa Hadoop QA added a comment -

      The patch artifact directory on has been removed!
      This is a fatal error for test-patch.sh. Aborting.
      Jenkins (node H3) information at https://builds.apache.org/job/PreCommit-HDFS-Build/10364/ may provide some hints.

      Show
      hadoopqa Hadoop QA added a comment - The patch artifact directory on has been removed! This is a fatal error for test-patch.sh. Aborting. Jenkins (node H3) information at https://builds.apache.org/job/PreCommit-HDFS-Build/10364/ may provide some hints.
      Hide
      andrew.wang Andrew Wang added a comment -

      Pushed to trunk and branch-2, thanks for working on this Zhe!

      Show
      andrew.wang Andrew Wang added a comment - Pushed to trunk and branch-2, thanks for working on this Zhe!
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-trunk-Commit #7665 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7665/)
      HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11)

      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java
      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7665 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7665/ ) HDFS-8191 . Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      Hide
      zhz Zhe Zhang added a comment -

      Thanks Andrew for reviewing and taking care of the commit.

      Show
      zhz Zhe Zhang added a comment - Thanks Andrew for reviewing and taking care of the commit.
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #174 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/174/)
      HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11)

      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java
      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #174 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/174/ ) HDFS-8191 . Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Yarn-trunk #908 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/908/)
      HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11)

      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #908 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/908/ ) HDFS-8191 . Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Hdfs-trunk #2106 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2106/)
      HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11)

      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java
      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2106 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2106/ ) HDFS-8191 . Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #165 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/165/)
      HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11)

      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #165 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/165/ ) HDFS-8191 . Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #175 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/175/)
      HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11)

      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #175 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/175/ ) HDFS-8191 . Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2124 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2124/)
      HDFS-8191. Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11)

      • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java
      • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2124 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2124/ ) HDFS-8191 . Fix byte to integer casting in SimulatedFSDataset#simulatedByte. Contributed by Zhe Zhang. (wang: rev c7d9ad68e34c7f8b9efada6cfbf7d5474cbeff11) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/SimulatedFSDataset.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestSimulatedFSDataset.java

        People

        • Assignee:
          zhz Zhe Zhang
          Reporter:
          zhz Zhe Zhang
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development