Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8147

Mover should not schedule two replicas to the same DN storage

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Scenario:
      1. Three DN cluster. For DNs storage type is like this.
      DN1 : DISK,ARCHIVE
      DN2 : DISK
      DN3 : DISK,ARCHIVE (All DNs are in same rack)
      2. One file with two replicas (In DN1 and DN2)
      3. Set file storage policy COLD
      4. Now execute Mover.

      Expected Result: File blocks should move in DN1:ARCHIVE and DN3:ARCHIVE

      Actual Result: chooseTargetInSameNode() move D1:DISK block to D1:ARCHIVE, but in next iteration chooseTarget() for same rake is selecting again DN1:ARCHIVE for target where already same block exists.
      chooseTargetInSameNode() and chooseTarget() should not select the node as target where already same replica exists. The dispatcher will fail to move block as shown in the log below. Then, the Mover will try again in next iteration.

      Logs

      15/04/15 10:47:17 WARN balancer.Dispatcher: Failed to move blk_1073741852_1028 with size=11990 from 10.19.92.74:50010:DISK to 10.19.92.73:50010:ARCHIVE through 10.19.92.73:50010: Got error, status message opReplaceBlock BP-1258709199-10.19.92.74-1428292615636:blk_1073741852_1028 received exception org.apache.hadoop.hdfs.server.datanode.ReplicaAlreadyExistsException: Replica FinalizedReplica, blk_1073741852_1028, FINALIZED
      
      1. HDFS-8147.patch
        2 kB
        Surendra Singh Lilhore
      2. HDFS-8147_4.patch
        4 kB
        Surendra Singh Lilhore
      3. HDFS-8147_3.patch
        5 kB
        Surendra Singh Lilhore
      4. HDFS-8147_2.patch
        3 kB
        Walter Su
      5. HDFS-8147_1.patch
        1 kB
        Surendra Singh Lilhore

        Issue Links

          Activity

          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached patch, Please review.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached patch, Please review.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726137/HDFS-8147.patch
          against trunk revision 76e7264.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10299//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10299//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726137/HDFS-8147.patch against trunk revision 76e7264. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10299//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10299//console This message is automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          I think the problem is that when the Mover schedule the moves DN1 ARCHIVE does not has the block. When dispatching the blocks, one of them is dispatched successfully but the other will fail.

          We already have block.isLocatedOn(target) in isGoodBlockCandidate(..). So I think the patch may not help. Could you test it?

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - I think the problem is that when the Mover schedule the moves DN1 ARCHIVE does not has the block. When dispatching the blocks, one of them is dispatched successfully but the other will fail. We already have block.isLocatedOn(target) in isGoodBlockCandidate(..). So I think the patch may not help. Could you test it?
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Thanks Tsz Wo Nicholas Sze for comments

          I think the problem is that when the Mover schedule the moves DN1 ARCHIVE does not has the block. When dispatching the blocks, one of them is dispatched successfully but the other will fail.

          Based my understanding Mover will move only one replica for block at a time in one iteration. It will not move all replicas for same block concurrently, that’s why no chance of conflict in dispatching.

          We already have block.isLocatedOn(target) in isGoodBlockCandidate(..). So I think the patch may not help. Could you test it?

          I already test this patch and its working for me.

          Yes we have block.isLocatedOn(target) in isGoodBlockCandidate(..), but Mover will not use this API.

          After selecting target block, mover will call dispatcher.executePendingMove(..) and then executePendingMove(..) directly call p.dispatch().

          public void executePendingMove(final PendingMove p) {
              // move the block
              moveExecutor.execute(new Runnable() {
                @Override
                public void run() {
                  p.dispatch();
                }
              });
            }
          
          Show
          surendrasingh Surendra Singh Lilhore added a comment - Thanks Tsz Wo Nicholas Sze for comments I think the problem is that when the Mover schedule the moves DN1 ARCHIVE does not has the block. When dispatching the blocks, one of them is dispatched successfully but the other will fail. Based my understanding Mover will move only one replica for block at a time in one iteration. It will not move all replicas for same block concurrently, that’s why no chance of conflict in dispatching. We already have block.isLocatedOn(target) in isGoodBlockCandidate(..). So I think the patch may not help. Could you test it? I already test this patch and its working for me. Yes we have block.isLocatedOn(target) in isGoodBlockCandidate(..) , but Mover will not use this API. After selecting target block, mover will call dispatcher.executePendingMove(..) and then executePendingMove(..) directly call p.dispatch() . public void executePendingMove( final PendingMove p) { // move the block moveExecutor.execute( new Runnable () { @Override public void run() { p.dispatch(); } }); }
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          > ... Mover will not use this API.

          No, Mover does use it. It calls source.addPendingMove(db, target) to create the PendingMove.
          source.addPendingMove(db, target)
          => target.addPendingMove(block, new PendingMove(this, target)
          => pm.markMovedIfGoodBlock(block, getStorageType())
          => isGoodBlockCandidate(source, target, targetStorageType, block)

          If your patch is working, could you add a test to verify it?

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - > ... Mover will not use this API. No, Mover does use it. It calls source.addPendingMove(db, target) to create the PendingMove. source.addPendingMove(db, target) => target.addPendingMove(block, new PendingMove(this, target) => pm.markMovedIfGoodBlock(block, getStorageType()) => isGoodBlockCandidate(source, target, targetStorageType, block) If your patch is working, could you add a test to verify it?
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Ooh sorry I missed it...but block.isLocatedOn(target) always returning false.

              public synchronized boolean isLocatedOn(L loc) {
                return locations.contains(loc);
              }
          

          The reason is locations is list of Dispatcher#Source objects and loc object of StorageGroup. So contains() always return false. It better to override equals() in StorageGroup. Attached patch with this fix.

          Tsz Wo Nicholas Sze
          Please review and give your suggestion.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Ooh sorry I missed it...but block.isLocatedOn(target) always returning false. public synchronized boolean isLocatedOn(L loc) { return locations.contains(loc); } The reason is locations is list of Dispatcher#Source objects and loc object of StorageGroup . So contains() always return false. It better to override equals() in StorageGroup. Attached patch with this fix. Tsz Wo Nicholas Sze Please review and give your suggestion.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726523/HDFS-8147_1.patch
          against trunk revision 8511d80.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          -1 findbugs. The patch appears to introduce 4 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10314//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/10314//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10314//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726523/HDFS-8147_1.patch against trunk revision 8511d80. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 4 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10314//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/10314//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10314//console This message is automatically generated.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          I will fix the findbugs and add test code soon..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - I will fix the findbugs and add test code soon..
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          > ... So contains() always return false. It better to override equals() in StorageGroup. ...

          I see. Thanks for pointing it out and working on it.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - > ... So contains() always return false. It better to override equals() in StorageGroup. ... I see. Thanks for pointing it out and working on it.
          Hide
          walter.k.su Walter Su added a comment -

          >... It better to override equals() in StorageGroup. ...
          I don't think it'll work.
          I closed HDFS-8204, and moved the patch of it here. Btw, I think Mover and Balancer should use the same guard isGoodBlockCandidate

          Show
          walter.k.su Walter Su added a comment - >... It better to override equals() in StorageGroup. ... I don't think it'll work. I closed HDFS-8204 , and moved the patch of it here. Btw, I think Mover and Balancer should use the same guard isGoodBlockCandidate
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Walter Su Pls check Tsz Wo Nicholas Sze comment, mover will use isGoodBlockCandidate.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Walter Su Pls check Tsz Wo Nicholas Sze comment, mover will use isGoodBlockCandidate .
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Attached new patch, Please review..

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Attached new patch, Please review..
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 37s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 44s There were no new javac warning messages.
          +1 javadoc 9m 33s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 3m 59s The applied patch generated 1 additional checkstyle issues.
          +1 install 1m 31s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 3m 7s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 native 3m 18s Pre-build of native portion
          +1 hdfs tests 164m 41s Tests passed in hadoop-hdfs.
              209m 28s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727159/HDFS-8147_3.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / b08908a
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10343/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10343/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10343/testReport/
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10343//console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 37s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 44s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 3m 59s The applied patch generated 1 additional checkstyle issues. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 7s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 18s Pre-build of native portion +1 hdfs tests 164m 41s Tests passed in hadoop-hdfs.     209m 28s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727159/HDFS-8147_3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / b08908a checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10343/artifact/patchprocess/checkstyle-result-diff.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10343/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10343/testReport/ Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10343//console This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -
          • For StorageGroup,
            • hashCode() should use getStorageType() and getDatanodeInfo() to compute hash code since equals(..) uses them. Using super.hashCode() seems wrong since it is not consistent with equals(..).
            • The equal(..) method can be simplified as below:
                    @Override
                    public int hashCode() {
                      return getStorageType().hashCode()
                          ^ getDatanodeInfo().hashCode();
                    }
              
                    @Override
                    public boolean equals(Object obj) {
                      if (this == obj) {
                        return true;
                      } else if (obj == null || !(obj instanceof StorageGroup)) {
                        return false;
                      } else {
                        final StorageGroup that = (StorageGroup) obj;
                        return this.getStorageType() == that.getStorageType()
                            && this.getDatanodeInfo().equals(that.getDatanodeInfo());
                      }
                    }
              
          • For Source, we should simply use the super methods, i.e.
                @Override
                public int hashCode() {
                  return super.hashCode();
                }
            
                @Override
                public boolean equals(Object obj) {
                  return super.equals(obj);
                }
            
          • For the test, why don't you use the same test case described in your description? The current test case takes a long time since Mover has to try multiple times before exiting.
          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - For StorageGroup, hashCode() should use getStorageType() and getDatanodeInfo() to compute hash code since equals(..) uses them. Using super.hashCode() seems wrong since it is not consistent with equals(..). The equal(..) method can be simplified as below: @Override public int hashCode() { return getStorageType().hashCode() ^ getDatanodeInfo().hashCode(); } @Override public boolean equals( Object obj) { if ( this == obj) { return true ; } else if (obj == null || !(obj instanceof StorageGroup)) { return false ; } else { final StorageGroup that = (StorageGroup) obj; return this .getStorageType() == that.getStorageType() && this .getDatanodeInfo().equals(that.getDatanodeInfo()); } } For Source, we should simply use the super methods, i.e. @Override public int hashCode() { return super .hashCode(); } @Override public boolean equals( Object obj) { return super .equals(obj); } For the test, why don't you use the same test case described in your description? The current test case takes a long time since Mover has to try multiple times before exiting.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Revised summary and description.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Revised summary and description.
          Hide
          surendrasingh Surendra Singh Lilhore added a comment -

          Tsz Wo Nicholas Sze Thanks for review.
          Fixed review comments and attached new patch, Please review.

          Show
          surendrasingh Surendra Singh Lilhore added a comment - Tsz Wo Nicholas Sze Thanks for review. Fixed review comments and attached new patch, Please review.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 37s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 javac 7m 26s There were no new javac warning messages.
          +1 javadoc 9m 34s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 7m 47s The applied patch generated 1 additional checkstyle issues.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 native 3m 12s Pre-build of native portion
          +1 hdfs tests 186m 38s Tests passed in hadoop-hdfs.
              234m 50s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12727606/HDFS-8147_4.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / baf8bc6
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10358/artifact/patchprocess/checkstyle-result-diff.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10358/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10358/testReport/
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10358/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 37s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 26s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 7m 47s The applied patch generated 1 additional checkstyle issues. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 4s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 native 3m 12s Pre-build of native portion +1 hdfs tests 186m 38s Tests passed in hadoop-hdfs.     234m 50s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727606/HDFS-8147_4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / baf8bc6 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10358/artifact/patchprocess/checkstyle-result-diff.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/10358/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10358/testReport/ Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10358/console This message was automatically generated.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          +1 the new patch looks good.

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - +1 the new patch looks good.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, surendra!

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, surendra!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7652 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7652/)
          HDFS-8147. StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7652 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7652/ ) HDFS-8147 . StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2105 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2105/)
          HDFS-8147. StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2105 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2105/ ) HDFS-8147 . StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #164 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/164/)
          HDFS-8147. StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #164 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/164/ ) HDFS-8147 . StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #173 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/173/)
          HDFS-8147. StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #173 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/173/ ) HDFS-8147 . StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #907 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/907/)
          HDFS-8147. StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #907 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/907/ ) HDFS-8147 . StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #174 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/174/)
          HDFS-8147. StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #174 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/174/ ) HDFS-8147 . StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2123 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2123/)
          HDFS-8147. StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2123 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2123/ ) HDFS-8147 . StorageGroup in Dispatcher should override equals nad hashCode. Contributed by surendra singh lilhore (szetszwo: rev 416b84354ebcc6f6f23598a5a254e62eb606680d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/Dispatcher.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java

            People

            • Assignee:
              surendrasingh Surendra Singh Lilhore
              Reporter:
              surendrasingh Surendra Singh Lilhore
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development