[HDFS-812] FSNamesystem#internalReleaseLease throws NullPointerException on a single-block file's lease recovery

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.21.0, 0.22.0
• Fix Version/s: 0.21.0
• Component/s: namenode
• Hadoop Flags: Reviewed
• Assignee: Konstantin I Boudnik
• Reporter: Konstantin I Boudnik
• Created: 07/Dec/09 18:16
• Updated: 24/Aug/10 20:50
• Resolved: 16/Dec/09 04:11

Description

FSNamesystem.internalReleaseLease() uses the result of iFile#numBlocks(); call to get a number of an under construction file's blocks. numBlock() can return 0 if the file doesn't have any blocks yet. This will cause internalReleaseLease() to throw ArrayIndexOutOfBoundException.

In case of a single block file, the same method will throw NullPointerException because the penultimate block is going to be null according to the logic of INodeFile#getPenultimateBlock().

Issue Links

• blocks: HDFS-804 New unit tests for concurrent lease recovery