Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-8056

Decommissioned dead nodes should continue to be counted as dead after NN restart

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      We had some offline discussion with Andrew Wang and Colin P. McCabe about this. Bring this up for more input and get the patch in place.

      Dead nodes are tracked by DatanodeManager's datanodeMap. However, after NN restarts, those nodes that were dead before NN restart won't be in datanodeMap. DatanodeManager's getDatanodeListForReport will add those dead nodes, but not if they are in the exclude file.

          if (listDeadNodes) {
            for (InetSocketAddress addr : includedNodes) {
              if (foundNodes.matchedBy(addr) || excludedNodes.match(addr)) {
                continue;
              }
              // The remaining nodes are ones that are referenced by the hosts
              // files but that we do not know about, ie that we have never
              // head from. Eg. an entry that is no longer part of the cluster
              // or a bogus entry was given in the hosts files
              //
              // If the host file entry specified the xferPort, we use that.
              // Otherwise, we guess that it is the default xfer port.
              // We can't ask the DataNode what it had configured, because it's
              // dead.
              DatanodeDescriptor dn = new DatanodeDescriptor(new DatanodeID(addr
                      .getAddress().getHostAddress(), addr.getHostName(), "",
                      addr.getPort() == 0 ? defaultXferPort : addr.getPort(),
                      defaultInfoPort, defaultInfoSecurePort, defaultIpcPort));
              setDatanodeDead(dn);
              nodes.add(dn);
            }
          }
      

      The issue here is the decommissioned dead node JMX will be different after NN restart. It might be better to make it consistent across NN restart.

      1. HDFS-8056.patch
        3 kB
        Ming Ma
      2. HDFS-8056-2.patch
        4 kB
        Ming Ma

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #620 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/620/)
        HDFS-8056. Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #620 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/620/ ) HDFS-8056 . Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2558 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2558/)
        HDFS-8056. Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2558 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2558/ ) HDFS-8056 . Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1423 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1423/)
        HDFS-8056. Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1423 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1423/ ) HDFS-8056 . Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2626 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2626/)
        HDFS-8056. Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2626 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2626/ ) HDFS-8056 . Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #697 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/697/)
        HDFS-8056. Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #697 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/697/ ) HDFS-8056 . Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #684 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/684/)
        HDFS-8056. Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #684 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/684/ ) HDFS-8056 . Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8827 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8827/)
        HDFS-8056. Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8827 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8827/ ) HDFS-8056 . Decommissioned dead nodes should continue to be counted as (mingma: rev 1c4951a7a09433fbbcfe26f243d6c2d8043c71bb) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestHostFileManager.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDecommission.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
        Hide
        mingma Ming Ma added a comment -

        Thanks Andrew Wang! I have committed the patch to trunk and branch-2.

        Show
        mingma Ming Ma added a comment - Thanks Andrew Wang ! I have committed the patch to trunk and branch-2.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 8s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 3m 48s trunk passed
        +1 compile 0m 39s trunk passed with JDK v1.8.0_60
        +1 compile 0m 38s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 18s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 findbugs 2m 19s trunk passed
        +1 javadoc 1m 31s trunk passed with JDK v1.8.0_60
        +1 javadoc 2m 13s trunk passed with JDK v1.7.0_79
        +1 mvninstall 0m 47s the patch passed
        +1 compile 0m 40s the patch passed with JDK v1.8.0_60
        +1 javac 0m 40s the patch passed
        +1 compile 0m 36s the patch passed with JDK v1.7.0_79
        +1 javac 0m 36s the patch passed
        +1 checkstyle 0m 20s the patch passed
        +1 mvnsite 0m 48s the patch passed
        +1 mvneclipse 0m 15s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 2m 19s the patch passed
        +1 javadoc 1m 23s the patch passed with JDK v1.8.0_60
        +1 javadoc 2m 11s the patch passed with JDK v1.7.0_79
        -1 unit 63m 25s hadoop-hdfs in the patch failed with JDK v1.8.0_60.
        -1 unit 55m 29s hadoop-hdfs in the patch failed with JDK v1.7.0_79.
        -1 asflicense 0m 21s Patch generated 58 ASF License warnings.
        144m 6s



        Reason Tests
        JDK v1.8.0_60 Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby
          hadoop.hdfs.server.blockmanagement.TestNodeCount
          hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          hadoop.hdfs.server.namenode.TestAddStripedBlocks
          hadoop.hdfs.server.datanode.TestDataNodeMetrics
          hadoop.hdfs.server.namenode.ha.TestDNFencing
        JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-16
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12709302/HDFS-8056-2.patch
        JIRA Issue HDFS-8056
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 7abd21cc1c25 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build@2/patchprocess/apache-yetus-23a1c9a/precommit/personality/hadoop.sh
        git revision trunk / 02653ad
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13528/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/13528/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13528/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13528/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13528/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13528/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Max memory used 228MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13528/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 8s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 3m 48s trunk passed +1 compile 0m 39s trunk passed with JDK v1.8.0_60 +1 compile 0m 38s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 2m 19s trunk passed +1 javadoc 1m 31s trunk passed with JDK v1.8.0_60 +1 javadoc 2m 13s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 47s the patch passed +1 compile 0m 40s the patch passed with JDK v1.8.0_60 +1 javac 0m 40s the patch passed +1 compile 0m 36s the patch passed with JDK v1.7.0_79 +1 javac 0m 36s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 48s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 19s the patch passed +1 javadoc 1m 23s the patch passed with JDK v1.8.0_60 +1 javadoc 2m 11s the patch passed with JDK v1.7.0_79 -1 unit 63m 25s hadoop-hdfs in the patch failed with JDK v1.8.0_60. -1 unit 55m 29s hadoop-hdfs in the patch failed with JDK v1.7.0_79. -1 asflicense 0m 21s Patch generated 58 ASF License warnings. 144m 6s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.hdfs.server.namenode.ha.TestBootstrapStandby   hadoop.hdfs.server.blockmanagement.TestNodeCount   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots   hadoop.hdfs.server.namenode.TestAddStripedBlocks   hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.server.namenode.ha.TestDNFencing JDK v1.7.0_79 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-16 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12709302/HDFS-8056-2.patch JIRA Issue HDFS-8056 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7abd21cc1c25 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build@2/patchprocess/apache-yetus-23a1c9a/precommit/personality/hadoop.sh git revision trunk / 02653ad Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/13528/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/13528/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/13528/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HDFS-Build/13528/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/13528/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/13528/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Max memory used 228MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/13528/console This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks for working on this Ming, +1 LGTM. Seems inline with our earlier work on decommissioning dead DNs at HDFS-7725 and HDFS-7374.

        The patch still applied cleanly, but I started another precommit job since this patch has been sitting for a while. Let's commit when that comes back.

        Show
        andrew.wang Andrew Wang added a comment - Thanks for working on this Ming, +1 LGTM. Seems inline with our earlier work on decommissioning dead DNs at HDFS-7725 and HDFS-7374 . The patch still applied cleanly, but I started another precommit job since this patch has been sitting for a while. Let's commit when that comes back.
        Hide
        mingma Ming Ma added a comment -

        Andrew Wang and others, appreciate any input you might have.

        Show
        mingma Ming Ma added a comment - Andrew Wang and others, appreciate any input you might have.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12709302/HDFS-8056-2.patch
        against trunk revision db80e42.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10175//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10175//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12709302/HDFS-8056-2.patch against trunk revision db80e42. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10175//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10175//console This message is automatically generated.
        Hide
        mingma Ming Ma added a comment -

        Updated patch to fix test failure in TestHostFileManager.

        Show
        mingma Ming Ma added a comment - Updated patch to fix test failure in TestHostFileManager.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12709142/HDFS-8056.patch
        against trunk revision bad070f.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.blockmanagement.TestHostFileManager

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10169//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10169//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12709142/HDFS-8056.patch against trunk revision bad070f. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestHostFileManager Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10169//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10169//console This message is automatically generated.
        Hide
        mingma Ming Ma added a comment -

        Here is the initial patch. It put the dead node under (dead, decommissioned) after NN restart even though we don't know if the node was (dead, decommissioned) or (dead, decommission-in-progress) prior to NN restart. It shouldn't really matter. If the node was in (dead, decommission-in-progress) and becomes alive after NN restart, it will be put to datanodeMap and start the decommission process.

        Show
        mingma Ming Ma added a comment - Here is the initial patch. It put the dead node under (dead, decommissioned) after NN restart even though we don't know if the node was (dead, decommissioned) or (dead, decommission-in-progress) prior to NN restart. It shouldn't really matter. If the node was in (dead, decommission-in-progress) and becomes alive after NN restart, it will be put to datanodeMap and start the decommission process.

          People

          • Assignee:
            mingma Ming Ma
            Reporter:
            mingma Ming Ma
          • Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development