Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      On http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsDesign.html#File_Deletes_and_Undeletes the section on trash refers to files residing in /trash.

      I think this is an error, as files actually go to user specific trash directories like /user/hdfs/.Trash

      Either the site needs to be updated to mention user specific directories, or if this is a change from previous behaviour then maybe that can be mentioned instead.

      1. HDFS-8002.patch
        3 kB
        Brahma Reddy Battula
      2. HDFS-8003-002.patch
        3 kB
        Brahma Reddy Battula

        Issue Links

          Activity

          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Mike DrobThanks for reporting this jira... Attached patch..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Mike Drob Thanks for reporting this jira... Attached patch..
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12707797/HDFS-8002.patch
          against trunk revision 05499b1.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10091//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10091//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707797/HDFS-8002.patch against trunk revision 05499b1. +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10091//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10091//console This message is automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Test case failure are unrelated this jira..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Test case failure are unrelated this jira..
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Mike Drob for the report and thanks Brahma Reddy Battula for the patch.
          One comment: The patch looks redundant for me. Could you document the actual path once and use trash instead of writing the actual path every time? Such as

          HDFS first renames it to a file in the trash directory (`/user/<username>/.Trash`). The file can be restored quickly as long as it remains in trash. ...
          
          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Mike Drob for the report and thanks Brahma Reddy Battula for the patch. One comment: The patch looks redundant for me. Could you document the actual path once and use trash instead of writing the actual path every time? Such as HDFS first renames it to a file in the trash directory (`/user/<username>/.Trash`). The file can be restored quickly as long as it remains in trash. ...
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks a lot for taking look into this issue...Updated patch based on your comment..

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks a lot for taking look into this issue...Updated patch based on your comment..
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Brahma Reddy Battula for updating the patch. +1 pending Jenkins.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Brahma Reddy Battula for updating the patch. +1 pending Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12708110/HDFS-8003-002.patch
          against trunk revision 1ed9fb7.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10108//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10108//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708110/HDFS-8003-002.patch against trunk revision 1ed9fb7. +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10108//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10108//console This message is automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          The test failure looks unrelated to the patch. Committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - The test failure looks unrelated to the patch. Committing this.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Brahma Reddy Battula for contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7460 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7460/)
          HDFS-8002. Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc)

          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7460 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7460/ ) HDFS-8002 . Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Thanks a lot Akira Ajisaka!!!

          Show
          brahmareddy Brahma Reddy Battula added a comment - Thanks a lot Akira Ajisaka !!!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #149 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/149/)
          HDFS-8002. Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc)

          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #149 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/149/ ) HDFS-8002 . Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #883 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/883/)
          HDFS-8002. Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc)

          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #883 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/883/ ) HDFS-8002 . Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2081 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2081/)
          HDFS-8002. Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2081 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2081/ ) HDFS-8002 . Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/140/)
          HDFS-8002. Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc)

          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #140 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/140/ ) HDFS-8002 . Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #149 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/149/)
          HDFS-8002. Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc)

          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #149 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/149/ ) HDFS-8002 . Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2099 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2099/)
          HDFS-8002. Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2099 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2099/ ) HDFS-8002 . Website refers to /trash directory. Contributd by Brahma Reddy Battula. (aajisaka: rev e7ea2a8e8f0a7b428ef10552885757b99b59e4dc) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HdfsDesign.md

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              mdrob Mike Drob
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development