Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      After the conversion to netty, webhdfs requests are not logged on datanodes. The existing jetty log only logs the non-webhdfs requests that come through the internal proxy.

      1. HDFS-7959.1.branch-2.patch
        6 kB
        Kihwal Lee
      2. HDFS-7959.1.trunk.patch
        7 kB
        Kihwal Lee
      3. HDFS-7959.2.branch-2.patch
        6 kB
        Kihwal Lee
      4. HDFS-7959.2.trunk.patch
        7 kB
        Kihwal Lee
      5. HDFS-7959.3.branch-2.patch
        7 kB
        Kihwal Lee
      6. HDFS-7959.3.trunk.patch
        8 kB
        Kihwal Lee
      7. HDFS-7959.branch-2.patch
        6 kB
        Kihwal Lee
      8. HDFS-7959.patch
        6 kB
        Kihwal Lee
      9. HDFS-7959.patch
        7 kB
        Kihwal Lee
      10. HDFS-7959.patch
        4 kB
        Kihwal Lee
      11. HDFS-7959.trunk.patch
        7 kB
        Kihwal Lee

        Issue Links

          Activity

          Hide
          kihwal Kihwal Lee added a comment -

          First shot at adding the logging. The patch comes with a sample log4j config.

          Show
          kihwal Kihwal Lee added a comment - First shot at adding the logging. The patch comes with a sample log4j config.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12705691/HDFS-7959.patch
          against trunk revision 61a4c7f.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.tracing.TestTracing

          The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestLeaseRecovery2

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9985//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9985//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12705691/HDFS-7959.patch against trunk revision 61a4c7f. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.tracing.TestTracing The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestLeaseRecovery2 Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9985//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9985//console This message is automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          Thanks for taking care of this Kihwal Lee. One quick question: jetty server outputs the log in the NCSA format by default, does the code need to do the same thing here?

          Show
          wheat9 Haohui Mai added a comment - Thanks for taking care of this Kihwal Lee . One quick question: jetty server outputs the log in the NCSA format by default, does the code need to do the same thing here?
          Hide
          kihwal Kihwal Lee added a comment -

          I don't think we need to. Besides, not all the components in the current jetty log is actually useful (e.g. response code).

          Show
          kihwal Kihwal Lee added a comment - I don't think we need to. Besides, not all the components in the current jetty log is actually useful (e.g. response code).
          Hide
          kihwal Kihwal Lee added a comment -

          It is probably a good idea to sanitize the tokens in the request URI before logging. I will update the patch.

          Show
          kihwal Kihwal Lee added a comment - It is probably a good idea to sanitize the tokens in the request URI before logging. I will update the patch.
          Hide
          wheat9 Haohui Mai added a comment -

          Besides, not all the components in the current jetty log is actually useful (e.g. response code)

          The response code is useful in terms of debugging authentication issues (401 / 500 / etc.). Maybe it is a good idea to keep them?

          It is probably a good idea to sanitize the tokens in the request URI before logging. I will update the patch.

          I think that the right fix is to move delegation token from the URL to the header. Logging requests seem really general and it might be a bad idea to mix it with the requirements of the application layers.

          Show
          wheat9 Haohui Mai added a comment - Besides, not all the components in the current jetty log is actually useful (e.g. response code) The response code is useful in terms of debugging authentication issues (401 / 500 / etc.). Maybe it is a good idea to keep them? It is probably a good idea to sanitize the tokens in the request URI before logging. I will update the patch. I think that the right fix is to move delegation token from the URL to the header. Logging requests seem really general and it might be a bad idea to mix it with the requirements of the application layers.
          Hide
          kihwal Kihwal Lee added a comment -

          >I think that the right fix is to move delegation token from the URL to the header.
          Agreed. Daryn was looking at making that change, but the rolling upgrade scenario makes it a bit complicated. Right now token in the request is very useful in correlating the requests to a job or to a client. If token is not part of the request URI, there should be something else for tracing and correlating requests. It could be a dummy param derived from client ID, etc.

          Show
          kihwal Kihwal Lee added a comment - >I think that the right fix is to move delegation token from the URL to the header. Agreed. Daryn was looking at making that change, but the rolling upgrade scenario makes it a bit complicated. Right now token in the request is very useful in correlating the requests to a job or to a client. If token is not part of the request URI, there should be something else for tracing and correlating requests. It could be a dummy param derived from client ID, etc.
          Hide
          kihwal Kihwal Lee added a comment -

          Adding the response code in the log. The ordering of columns is similar to that of NCSA log. Here is a sample log line.

          2015-03-26 15:29:49,457 10.74.91.177 GET /webhdfs/v1/tmp/services?op=OPEN&user.name=kihwal&namenoderpcaddress=mymachine.com:9000&buffersize=131072&offset=0 200

          Show
          kihwal Kihwal Lee added a comment - Adding the response code in the log. The ordering of columns is similar to that of NCSA log. Here is a sample log line. 2015-03-26 15:29:49,457 10.74.91.177 GET /webhdfs/v1/tmp/services?op=OPEN&user.name=kihwal&namenoderpcaddress=mymachine.com:9000&buffersize=131072&offset=0 200
          Hide
          kihwal Kihwal Lee added a comment -

          I see a couple of lines of unnecessary code. I will remove them in the next round.

          Show
          kihwal Kihwal Lee added a comment - I see a couple of lines of unnecessary code. I will remove them in the next round.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12707593/HDFS-7959.patch
          against trunk revision 61df1b2.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.ipc.TestRPC

          The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestDFSClientExcludedNodes

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10079//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10079//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707593/HDFS-7959.patch against trunk revision 61df1b2. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.ipc.TestRPC The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDFSClientExcludedNodes Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10079//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10079//console This message is automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          >I think that the right fix is to move delegation token from the URL to the header.
          Related: HADOOP-10880. We will make it happen for HDFS in a separate jira.

          Show
          kihwal Kihwal Lee added a comment - >I think that the right fix is to move delegation token from the URL to the header. Related: HADOOP-10880 . We will make it happen for HDFS in a separate jira.
          Hide
          wheat9 Haohui Mai added a comment -

          Kihwal Lee, is latest patch ready to be committed?

          Show
          wheat9 Haohui Mai added a comment - Kihwal Lee , is latest patch ready to be committed?
          Hide
          kihwal Kihwal Lee added a comment -

          Cleaned up the patch.

          Show
          kihwal Kihwal Lee added a comment - Cleaned up the patch.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726592/HDFS-7959.patch
          against trunk revision c17cd4f.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10317//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10317//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726592/HDFS-7959.patch against trunk revision c17cd4f. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10317//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10317//console This message is automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          The current approach looks okay. A cleaner approach might be to introduce a LoggingHandler which catches all the response in downstream of the netty pipeline.

          Show
          wheat9 Haohui Mai added a comment - The current approach looks okay. A cleaner approach might be to introduce a LoggingHandler which catches all the response in downstream of the netty pipeline.
          Hide
          kihwal Kihwal Lee added a comment -

          I tried LoggingHandler, but it was getting ALL events. We could implement our own and do filtering, but thought this is simpler.

          Show
          kihwal Kihwal Lee added a comment - I tried LoggingHandler, but it was getting ALL events. We could implement our own and do filtering, but thought this is simpler.
          Hide
          sjlee0 Sangjin Lee added a comment -

          Kihwal Lee, would you be able to update the patch for this so it can be reviewed for 2.8.0?

          Show
          sjlee0 Sangjin Lee added a comment - Kihwal Lee , would you be able to update the patch for this so it can be reviewed for 2.8.0?
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Not much going on here for a long time, dropping from 2.8.0.

          Not putting any target-version either anymore, let's target this depending on when there is patch activity.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Not much going on here for a long time, dropping from 2.8.0. Not putting any target-version either anymore, let's target this depending on when there is patch activity.
          Hide
          kihwal Kihwal Lee added a comment -

          Sorry for neglecting it for so long. Attaching updated patches. The branch-2 version applies to branch-2.8 as well.

          Show
          kihwal Kihwal Lee added a comment - Sorry for neglecting it for so long. Attaching updated patches. The branch-2 version applies to branch-2.8 as well.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 30s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 31s Maven dependency ordering for branch
          +1 mvninstall 6m 39s trunk passed
          +1 compile 6m 59s trunk passed
          +1 checkstyle 1m 21s trunk passed
          +1 mvnsite 1m 44s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 3m 2s trunk passed
          +1 javadoc 1m 40s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 23s the patch passed
          +1 compile 6m 20s the patch passed
          -1 javac 6m 20s root generated 3 new + 691 unchanged - 0 fixed = 694 total (was 691)
          -1 checkstyle 1m 18s root: The patch generated 1 new + 13 unchanged - 1 fixed = 14 total (was 14)
          +1 mvnsite 1m 42s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 3m 13s the patch passed
          +1 javadoc 1m 39s the patch passed
          +1 unit 6m 53s hadoop-common in the patch passed.
          -1 unit 56m 45s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          104m 0s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestAsyncHDFSWithHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809865/HDFS-7959.trunk.patch
          JIRA Issue HDFS-7959
          Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle
          uname Linux 81fd6cfd23fb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 28b66ae
          Default Java 1.8.0_91
          findbugs v3.0.0
          javac https://builds.apache.org/job/PreCommit-HDFS-Build/15751/artifact/patchprocess/diff-compile-javac-root.txt
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15751/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15751/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15751/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15751/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15751/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15751/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 30s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 31s Maven dependency ordering for branch +1 mvninstall 6m 39s trunk passed +1 compile 6m 59s trunk passed +1 checkstyle 1m 21s trunk passed +1 mvnsite 1m 44s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 3m 2s trunk passed +1 javadoc 1m 40s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 23s the patch passed +1 compile 6m 20s the patch passed -1 javac 6m 20s root generated 3 new + 691 unchanged - 0 fixed = 694 total (was 691) -1 checkstyle 1m 18s root: The patch generated 1 new + 13 unchanged - 1 fixed = 14 total (was 14) +1 mvnsite 1m 42s the patch passed +1 mvneclipse 0m 25s the patch passed -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 13s the patch passed +1 javadoc 1m 39s the patch passed +1 unit 6m 53s hadoop-common in the patch passed. -1 unit 56m 45s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 104m 0s Reason Tests Failed junit tests hadoop.hdfs.TestAsyncHDFSWithHA Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809865/HDFS-7959.trunk.patch JIRA Issue HDFS-7959 Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle uname Linux 81fd6cfd23fb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 28b66ae Default Java 1.8.0_91 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-HDFS-Build/15751/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/15751/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15751/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15751/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15751/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15751/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15751/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          The new patches calls the new equivalent methods in nettey instead of the deprecated methods. They were file until 4.0.x, but are deprecated in 4.1.x. There is no functional change.

          Show
          kihwal Kihwal Lee added a comment - The new patches calls the new equivalent methods in nettey instead of the deprecated methods. They were file until 4.0.x, but are deprecated in 4.1.x. There is no functional change.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 12s Maven dependency ordering for branch
          +1 mvninstall 7m 40s trunk passed
          +1 compile 7m 54s trunk passed
          +1 checkstyle 1m 27s trunk passed
          +1 mvnsite 2m 0s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 29s trunk passed
          +1 javadoc 1m 50s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 42s the patch passed
          +1 compile 7m 57s the patch passed
          +1 javac 7m 57s the patch passed
          +1 checkstyle 1m 23s root: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)
          +1 mvnsite 1m 54s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 3m 56s the patch passed
          +1 javadoc 1m 47s the patch passed
          -1 unit 7m 57s hadoop-common in the patch failed.
          +1 unit 59m 26s hadoop-hdfs in the patch passed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          113m 4s



          Reason Tests
          Failed junit tests hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809982/HDFS-7959.1.trunk.patch
          JIRA Issue HDFS-7959
          Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle
          uname Linux 4a21625b4a74 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 709a814
          Default Java 1.8.0_91
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15759/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15759/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15759/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15759/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15759/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 12s Maven dependency ordering for branch +1 mvninstall 7m 40s trunk passed +1 compile 7m 54s trunk passed +1 checkstyle 1m 27s trunk passed +1 mvnsite 2m 0s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 29s trunk passed +1 javadoc 1m 50s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 42s the patch passed +1 compile 7m 57s the patch passed +1 javac 7m 57s the patch passed +1 checkstyle 1m 23s root: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14) +1 mvnsite 1m 54s the patch passed +1 mvneclipse 0m 26s the patch passed -1 whitespace 0m 0s The patch has 20 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 3m 56s the patch passed +1 javadoc 1m 47s the patch passed -1 unit 7m 57s hadoop-common in the patch failed. +1 unit 59m 26s hadoop-hdfs in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 113m 4s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12809982/HDFS-7959.1.trunk.patch JIRA Issue HDFS-7959 Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle uname Linux 4a21625b4a74 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 709a814 Default Java 1.8.0_91 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/15759/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15759/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15759/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15759/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15759/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          The test failure is not related to the patch.
          The whitespace warning is from ./hadoop-build-tools/src/main/resources/META-INF/LICENSE.tx

          Show
          kihwal Kihwal Lee added a comment - The test failure is not related to the patch. The whitespace warning is from ./hadoop-build-tools/src/main/resources/META-INF/LICENSE.tx
          Hide
          sjlee0 Sangjin Lee added a comment -

          Thanks Kihwal Lee for updating the patch! It looks good to me for the most part. I only have a couple of minor questions.

          125	        String host = ((InetSocketAddress)ctx.channel().remoteAddress()).
          126	            getAddress().getHostAddress();
          127	        HttpMethod method = req.method();
          

          Could this throw an exception (esp. host) in some situations? I think it might be a good idea to move this into the finally clause itself and make an exception here non-fatal. Thoughts?

          140	    if (resp == null) {
          141	      return "000";
          142	    }
          

          "000" is not a valid HTTP status code. If the response is null for any reason, "500" might be as good a choice as any. Also, if we change it to 500, we can then simply use int as the return type of getResponseCode().

          Show
          sjlee0 Sangjin Lee added a comment - Thanks Kihwal Lee for updating the patch! It looks good to me for the most part. I only have a couple of minor questions. 125 String host = ((InetSocketAddress)ctx.channel().remoteAddress()). 126 getAddress().getHostAddress(); 127 HttpMethod method = req.method(); Could this throw an exception (esp. host) in some situations? I think it might be a good idea to move this into the finally clause itself and make an exception here non-fatal. Thoughts? 140 if (resp == null ) { 141 return "000" ; 142 } "000" is not a valid HTTP status code. If the response is null for any reason, "500" might be as good a choice as any. Also, if we change it to 500, we can then simply use int as the return type of getResponseCode() .
          Hide
          kihwal Kihwal Lee added a comment -

          The new patches address the review comments.

          Show
          kihwal Kihwal Lee added a comment - The new patches address the review comments.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 12s Maven dependency ordering for branch
          +1 mvninstall 6m 17s trunk passed
          +1 compile 6m 31s trunk passed
          +1 checkstyle 1m 19s trunk passed
          +1 mvnsite 1m 43s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 3m 2s trunk passed
          +1 javadoc 1m 40s trunk passed
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 1m 21s the patch passed
          +1 compile 6m 26s the patch passed
          +1 javac 6m 26s the patch passed
          +1 checkstyle 1m 19s root: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)
          +1 mvnsite 1m 43s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 17s the patch passed
          +1 javadoc 1m 39s the patch passed
          -1 unit 6m 51s hadoop-common in the patch failed.
          -1 unit 59m 8s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          105m 4s



          Reason Tests
          Failed junit tests hadoop.net.TestDNS
            hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
            hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
            hadoop.hdfs.server.namenode.TestCacheDirectives
            hadoop.hdfs.server.namenode.TestNamenodeRetryCache



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:e2f6409
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812210/HDFS-7959.2.trunk.patch
          JIRA Issue HDFS-7959
          Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle
          uname Linux 1e5c2e9133b2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / e15cd43
          Default Java 1.8.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15847/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15847/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15847/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15847/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15847/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15847/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 12s Maven dependency ordering for branch +1 mvninstall 6m 17s trunk passed +1 compile 6m 31s trunk passed +1 checkstyle 1m 19s trunk passed +1 mvnsite 1m 43s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 3m 2s trunk passed +1 javadoc 1m 40s trunk passed 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 21s the patch passed +1 compile 6m 26s the patch passed +1 javac 6m 26s the patch passed +1 checkstyle 1m 19s root: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14) +1 mvnsite 1m 43s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 17s the patch passed +1 javadoc 1m 39s the patch passed -1 unit 6m 51s hadoop-common in the patch failed. -1 unit 59m 8s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 105m 4s Reason Tests Failed junit tests hadoop.net.TestDNS   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   hadoop.hdfs.server.namenode.TestCacheDirectives   hadoop.hdfs.server.namenode.TestNamenodeRetryCache Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812210/HDFS-7959.2.trunk.patch JIRA Issue HDFS-7959 Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle uname Linux 1e5c2e9133b2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e15cd43 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15847/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15847/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/15847/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt https://builds.apache.org/job/PreCommit-HDFS-Build/15847/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15847/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15847/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          sjlee0 Sangjin Lee added a comment -

          Thanks for updating the patch Kihwal Lee! Just one more nit: can we use INTERNAL_SERVER_ERROR instead of hard-coded numeral 500?

          Show
          sjlee0 Sangjin Lee added a comment - Thanks for updating the patch Kihwal Lee ! Just one more nit: can we use INTERNAL_SERVER_ERROR instead of hard-coded numeral 500?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 26s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 42s Maven dependency ordering for branch
          +1 mvninstall 8m 38s trunk passed
          +1 compile 8m 49s trunk passed
          +1 checkstyle 1m 33s trunk passed
          +1 mvnsite 2m 16s trunk passed
          +1 mvneclipse 0m 32s trunk passed
          +1 findbugs 3m 47s trunk passed
          +1 javadoc 1m 53s trunk passed
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 1m 48s the patch passed
          +1 compile 8m 12s the patch passed
          +1 javac 8m 12s the patch passed
          +1 checkstyle 1m 27s root: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14)
          +1 mvnsite 2m 7s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 13s the patch passed
          +1 javadoc 1m 52s the patch passed
          -1 unit 19m 24s hadoop-common in the patch failed.
          -1 unit 57m 49s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          127m 38s



          Reason Tests
          Failed junit tests hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
          Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:85209cc
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12813094/HDFS-7959.3.trunk.patch
          JIRA Issue HDFS-7959
          Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle
          uname Linux eb1a2860a75c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6314843
          Default Java 1.8.0_91
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15904/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/15904/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15904/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15904/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 42s Maven dependency ordering for branch +1 mvninstall 8m 38s trunk passed +1 compile 8m 49s trunk passed +1 checkstyle 1m 33s trunk passed +1 mvnsite 2m 16s trunk passed +1 mvneclipse 0m 32s trunk passed +1 findbugs 3m 47s trunk passed +1 javadoc 1m 53s trunk passed 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 48s the patch passed +1 compile 8m 12s the patch passed +1 javac 8m 12s the patch passed +1 checkstyle 1m 27s root: The patch generated 0 new + 13 unchanged - 1 fixed = 13 total (was 14) +1 mvnsite 2m 7s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 13s the patch passed +1 javadoc 1m 52s the patch passed -1 unit 19m 24s hadoop-common in the patch failed. -1 unit 57m 49s hadoop-hdfs in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 127m 38s Reason Tests Failed junit tests hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12813094/HDFS-7959.3.trunk.patch JIRA Issue HDFS-7959 Optional Tests asflicense mvnsite unit compile javac javadoc mvninstall findbugs checkstyle uname Linux eb1a2860a75c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6314843 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/15904/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/15904/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/15904/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/15904/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kihwal Kihwal Lee added a comment -

          TestHttpServerLifecycle works fine. Ran multiple times.

          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.http.TestHttpServerLifecycle
          Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.307 sec - in org.apache.hadoop.http.TestHttpServerLifecycle
          
          Results :
          
          Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
          

          TestOfflineEditsViewer HDFS-10572

          Show
          kihwal Kihwal Lee added a comment - TestHttpServerLifecycle works fine. Ran multiple times. ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.http.TestHttpServerLifecycle Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.307 sec - in org.apache.hadoop.http.TestHttpServerLifecycle Results : Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 TestOfflineEditsViewer HDFS-10572
          Hide
          sjlee0 Sangjin Lee added a comment -

          Thanks for updating the patch Kihwal! I'll take a look at it as soon as I
          can access the JIRA (it's not responding atm).

          Show
          sjlee0 Sangjin Lee added a comment - Thanks for updating the patch Kihwal! I'll take a look at it as soon as I can access the JIRA (it's not responding atm).
          Hide
          sjlee0 Sangjin Lee added a comment -

          Committed patch v.3 to trunk and branch-2. Thanks Kihwal Lee for your contribution!

          Show
          sjlee0 Sangjin Lee added a comment - Committed patch v.3 to trunk and branch-2. Thanks Kihwal Lee for your contribution!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #10018 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10018/)
          HDFS-7959. WebHdfs logging is missing on Datanode (Kihwal Lee via sjlee) (sjlee: rev bf74dbf80dc9379d669779a598950908adffb8a7)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/webhdfs/WebHdfsHandler.java
          • hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10018 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10018/ ) HDFS-7959 . WebHdfs logging is missing on Datanode (Kihwal Lee via sjlee) (sjlee: rev bf74dbf80dc9379d669779a598950908adffb8a7) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/web/webhdfs/WebHdfsHandler.java hadoop-common-project/hadoop-common/src/main/conf/log4j.properties
          Hide
          shahrs87 Rushabh S Shah added a comment -

          Kihwal Lee,Sangjin Lee: any reason why this change shouldn't go in branch-2.8 ?
          If it should then I can prepare a branch-2.8 patch.

          Show
          shahrs87 Rushabh S Shah added a comment - Kihwal Lee , Sangjin Lee : any reason why this change shouldn't go in branch-2.8 ? If it should then I can prepare a branch-2.8 patch.
          Hide
          kihwal Kihwal Lee added a comment -

          Cherry-picked to 2.8.

          Show
          kihwal Kihwal Lee added a comment - Cherry-picked to 2.8.
          Hide
          shahrs87 Rushabh S Shah added a comment -

          Thank you !!

          Show
          shahrs87 Rushabh S Shah added a comment - Thank you !!

            People

            • Assignee:
              kihwal Kihwal Lee
              Reporter:
              kihwal Kihwal Lee
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development