Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7931

DistributedFIleSystem should not look for keyProvider in cache if Encryption is disabled

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 2.7.1, 3.0.0-alpha1
    • Component/s: hdfs-client
    • Labels:
      None

      Description

      The addDelegationTokens method in DistributedFileSystem calls DFSClient#getKeyProvider() which attempts to get a provider from the KeyProvderCache but since the required key, dfs.encryption.key.provider.uri is not present (due to encryption being dissabled), it throws an exception.

      2015-03-11 23:55:47,849 [JobControl] ER ROR org.apache.hadoop.hdfs.KeyProviderCache - Could not find uri with key [dfs.encryption.key.provider.uri] to create a keyProvider !!
      
      1. HDFS-7931.1.patch
        2 kB
        Arun Suresh
      2. HDFS-7931.2.patch
        2 kB
        Arun Suresh
      3. HDFS-7931.2.patch
        2 kB
        Arun Suresh
      4. HDFS-7931.3.patch
        2 kB
        Arun Suresh

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2110 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2110/)
          HDFS-7931. DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2110 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2110/ ) HDFS-7931 . DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #161 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/161/)
          HDFS-7931. DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #161 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/161/ ) HDFS-7931 . DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #894 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/894/)
          HDFS-7931. DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #894 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/894/ ) HDFS-7931 . DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #151 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/151/)
          HDFS-7931. DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #151 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/151/ ) HDFS-7931 . DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2092 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2092/)
          HDFS-7931. DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2092 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2092/ ) HDFS-7931 . DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #160 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/160/)
          HDFS-7931. DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #160 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/160/ ) HDFS-7931 . DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7565 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7565/)
          HDFS-7931. DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7565 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7565/ ) HDFS-7931 . DistributedFileSystem should not look for keyProvider in cache if Encryption is disabled (asuresh) (Arun Suresh: rev 7660da95cb67cbfe034aa8fa2a5bf0f8c9fdf41a) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DistributedFileSystem.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          asuresh Arun Suresh added a comment -

          Committed to trunk, branch-2 and branch-2.7

          Show
          asuresh Arun Suresh added a comment - Committed to trunk, branch-2 and branch-2.7
          Hide
          asuresh Arun Suresh added a comment -

          No tests cases are updated since the patch itself is trivial. Verified on a local cluster that the error message is not logged when encryption is disabled.

          Show
          asuresh Arun Suresh added a comment - No tests cases are updated since the patch itself is trivial. Verified on a local cluster that the error message is not logged when encryption is disabled.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12724343/HDFS-7931.3.patch
          against trunk revision 623fd46.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10238//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10238//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12724343/HDFS-7931.3.patch against trunk revision 623fd46. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10238//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10238//console This message is automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Thanks Xiaoyu Yao for the review..
          re-uploading trunk-rebased patch and kicking off Jenkins again..
          Will be committing after that..

          Show
          asuresh Arun Suresh added a comment - Thanks Xiaoyu Yao for the review.. re-uploading trunk-rebased patch and kicking off Jenkins again.. Will be committing after that..
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12706744/HDFS-7931.2.patch
          against trunk revision 972f1f1.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.tracing.TestTracing

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10039//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10039//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706744/HDFS-7931.2.patch against trunk revision 972f1f1. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.tracing.TestTracing Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10039//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10039//console This message is automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Re-uploading patch to kick jenkins

          Show
          asuresh Arun Suresh added a comment - Re-uploading patch to kick jenkins
          Hide
          xyao Xiaoyu Yao added a comment -

          The V2 patch looks good to me. +1 (non-binding)

          Show
          xyao Xiaoyu Yao added a comment - The V2 patch looks good to me. +1 (non-binding)
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12706459/HDFS-7931.2.patch
          against trunk revision 0b9f12c.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.tracing.TestTracing
          org.apache.hadoop.hdfs.web.TestWebHDFSXAttr

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10029//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10029//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706459/HDFS-7931.2.patch against trunk revision 0b9f12c. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.tracing.TestTracing org.apache.hadoop.hdfs.web.TestWebHDFSXAttr Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10029//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10029//console This message is automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Fixing patch (had mistakenly inverted a boolean check in previous patch)

          Show
          asuresh Arun Suresh added a comment - Fixing patch (had mistakenly inverted a boolean check in previous patch)
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12706379/HDFS-7931.1.patch
          against trunk revision 4cd54d9.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.tracing.TestTracing
          org.apache.hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA
          org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
          org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser
          org.apache.hadoop.hdfs.TestEncryptionZones
          org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS
          org.apache.hadoop.hdfs.security.TestDelegationToken

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10023//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10023//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706379/HDFS-7931.1.patch against trunk revision 4cd54d9. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.tracing.TestTracing org.apache.hadoop.hdfs.server.namenode.ha.TestDelegationTokensWithHA org.apache.hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer org.apache.hadoop.hdfs.security.TestDelegationTokenForProxyUser org.apache.hadoop.hdfs.TestEncryptionZones org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS org.apache.hadoop.hdfs.security.TestDelegationToken Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10023//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10023//console This message is automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Attaching trivial patch..

          Show
          asuresh Arun Suresh added a comment - Attaching trivial patch..

            People

            • Assignee:
              asuresh Arun Suresh
              Reporter:
              asuresh Arun Suresh
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development