Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7890

Improve information on Top users for metrics in RollingWindowsManager and lower log level

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Information on Top users for metrics in RollingWindowsManager should be improved and can be moved to DEBUG.

      Currently it is INFO logs at namenode side and does not provide much information.

      15/03/04 13:21:02 INFO window.RollingWindowManager: topN size for command finalizeRollingUpgrade is: 1
      15/03/04 13:21:02 INFO window.RollingWindowManager: topN size for command startRollingUpgrade is: 0
      15/03/04 13:21:02 INFO window.RollingWindowManager: topN size for command * is: 1
      15/03/04 13:21:02 INFO window.RollingWindowManager: topN size for command finalizeRollingUpgrade is: 1
      15/03/04 13:21:02 INFO window.RollingWindowManager: topN size for command startRollingUpgrade is: 1
      15/03/04 13:21:02 INFO window.RollingWindowManager: topN size for command * is: 1
      15/03/04 13:21:02 INFO window.RollingWindowManager: topN size for command finalizeRollingUpgrade is: 1
      15/03/04 13:21:02 INFO window.RollingWindowManager: topN size for command startRollingUpgrade is: 0
      15/03/04 13:21:02 INFO window.RollingWindowManager: topN size for command * is: 1
      
      1. HDFS-7890.1.patch
        1 kB
        J.Andreina
      2. HDFS-7890.2.patch
        1 kB
        J.Andreina

        Issue Links

          Activity

          Hide
          andreina J.Andreina added a comment -

          Attached a patch as per the description.

          Please review and provide feedback on this issue.

          Show
          andreina J.Andreina added a comment - Attached a patch as per the description. Please review and provide feedback on this issue.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12702790/HDFS-7890.1.patch
          against trunk revision 1b67209.

          -1 patch. Trunk compilation may be broken.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9749//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12702790/HDFS-7890.1.patch against trunk revision 1b67209. -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9749//console This message is automatically generated.
          Hide
          andreina J.Andreina added a comment -

          Failure is not because of this patch .
          Please review the patch

          Show
          andreina J.Andreina added a comment - Failure is not because of this patch . Please review the patch
          Hide
          vinayrpet Vinayakumar B added a comment -

          Hi J.Andreina,
          I think the message better message could be like "topN users size for command {} is: {}".
          IMO it will be in sync with the javadoc description

           /**
             * Calculates the top N users over a time interval.
             * 
          Show
          vinayrpet Vinayakumar B added a comment - Hi J.Andreina , I think the message better message could be like "topN users size for command {} is: {}". IMO it will be in sync with the javadoc description /** * Calculates the top N users over a time interval. *
          Hide
          andreina J.Andreina added a comment -

          Thanks Vinayakumar for reviewing the patch.
          I agree with you. Will update the patch soon.

          Show
          andreina J.Andreina added a comment - Thanks Vinayakumar for reviewing the patch. I agree with you. Will update the patch soon.
          Hide
          andreina J.Andreina added a comment -

          Hi Vinayakumar , Uploaded the patch with changes.
          Please review.

          Show
          andreina J.Andreina added a comment - Hi Vinayakumar , Uploaded the patch with changes. Please review.
          Hide
          vinayrpet Vinayakumar B added a comment -

          +1 for latest patch.
          Committed to trunk and branch-2.
          Thanks J.Andreina.

          Show
          vinayrpet Vinayakumar B added a comment - +1 for latest patch. Committed to trunk and branch-2. Thanks J.Andreina .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7457 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7457/)
          HDFS-7890. Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7457 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7457/ ) HDFS-7890 . Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12708082/HDFS-7890.2.patch
          against trunk revision 232eca9.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10106//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10106//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12708082/HDFS-7890.2.patch against trunk revision 232eca9. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10106//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10106//console This message is automatically generated.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #148 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/148/)
          HDFS-7890. Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #148 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/148/ ) HDFS-7890 . Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #882 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/882/)
          HDFS-7890. Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #882 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/882/ ) HDFS-7890 . Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #148 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/148/)
          HDFS-7890. Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #148 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/148/ ) HDFS-7890 . Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2098 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2098/)
          HDFS-7890. Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2098 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2098/ ) HDFS-7890 . Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #139 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/139/)
          HDFS-7890. Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #139 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/139/ ) HDFS-7890 . Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2080 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2080/)
          HDFS-7890. Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2080 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2080/ ) HDFS-7890 . Improve information on Top users for metrics in RollingWindowsManager and lower log level (Contributed by J.Andreina) (vinayakumarb: rev 1ed9fb76645ecd195afe0067497dca10a3fb997d) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/top/window/RollingWindowManager.java

            People

            • Assignee:
              andreina J.Andreina
              Reporter:
              andreina J.Andreina
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development