Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ui
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This JIRA is for include X-editable (https://vitalets.github.io/x-editable/) in the Hadoop UI. It is released under the MIT license so its fine. We need it to make the owner / group / replication and possibly other fields in the UI editable easily

        Issue Links

          Activity

          Hide
          raviprak Ravi Prakash added a comment -

          From https://vitalets.github.io/x-editable/assets/zip/bootstrap3-editable-1.5.1.zip I would like to include these new files under hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2 :

          .
          |-- css
          |   |-- bootstrap-editable.css  # <- this is new
          |   `-- bootstrap.min.css
          |-- fonts
          |   |-- glyphicons-halflings-regular.eot
          |   |-- glyphicons-halflings-regular.svg
          |   |-- glyphicons-halflings-regular.ttf
          |   `-- glyphicons-halflings-regular.woff
          |-- img  # <- this is new
          |   |-- clear.png  # <- this is new
          |   `-- loading.gif  # <- this is new
          `-- js
              |-- bootstrap-editable.min.js  # <- this is new
              `-- bootstrap.min.js
          
          Show
          raviprak Ravi Prakash added a comment - From https://vitalets.github.io/x-editable/assets/zip/bootstrap3-editable-1.5.1.zip I would like to include these new files under hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2 : . |-- css | |-- bootstrap-editable.css # <- this is new | `-- bootstrap.min.css |-- fonts | |-- glyphicons-halflings-regular.eot | |-- glyphicons-halflings-regular.svg | |-- glyphicons-halflings-regular.ttf | `-- glyphicons-halflings-regular.woff |-- img # <- this is new | |-- clear.png # <- this is new | `-- loading.gif # <- this is new `-- js |-- bootstrap-editable.min.js # <- this is new `-- bootstrap.min.js
          Hide
          raviprak Ravi Prakash added a comment -

          Here's a binary patch which adds these new files. I've filed and patched HADOOP-11596 to improve smart-apply-patch to add files in binary patches too. I'll need to click submit patch after that one goes in

          Show
          raviprak Ravi Prakash added a comment - Here's a binary patch which adds these new files. I've filed and patched HADOOP-11596 to improve smart-apply-patch to add files in binary patches too. I'll need to click submit patch after that one goes in
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12698922/HDFS-7796.01.patch
          against trunk revision a16bfff.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.tracing.TestTracing

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10057//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10057//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698922/HDFS-7796.01.patch against trunk revision a16bfff. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.tracing.TestTracing Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/10057//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10057//console This message is automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          +1. Committing.

          Show
          wheat9 Haohui Mai added a comment - +1. Committing.
          Hide
          wheat9 Haohui Mai added a comment -

          I've committed the patch to trunk and branch-2. Thanks Ravi Prakash for the contribution.

          Show
          wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Ravi Prakash for the contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8844 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8844/)
          HDFS-7796. Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8844 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8844/ ) HDFS-7796 . Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2637 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2637/)
          HDFS-7796. Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2637 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2637/ ) HDFS-7796 . Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #697 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/697/)
          HDFS-7796. Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #697 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/697/ ) HDFS-7796 . Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #708 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/708/)
          HDFS-7796. Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #708 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/708/ ) HDFS-7796 . Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1433 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1433/)
          HDFS-7796. Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1433 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1433/ ) HDFS-7796 . Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2567 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2567/)
          HDFS-7796. Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2567 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2567/ ) HDFS-7796 . Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #629 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/629/)
          HDFS-7796. Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js
          • hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #629 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/629/ ) HDFS-7796 . Include X-editable for slick contenteditable fields in the (wheat9: rev 38146a6cdbd3788d247f77dfc3248cd7f76d01f4) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/clear.png hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/img/loading.gif hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/js/bootstrap-editable.min.js hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/static/bootstrap-3.0.2/css/bootstrap-editable.css
          Hide
          raviprak Ravi Prakash added a comment -

          Thanks a lot for the review and commit Haohui!

          Show
          raviprak Ravi Prakash added a comment - Thanks a lot for the review and commit Haohui!

            People

            • Assignee:
              raviprak Ravi Prakash
              Reporter:
              raviprak Ravi Prakash
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development