Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.2
    • Component/s: balancer & mover
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The Balancer's AccessKeyUpdater handles exceptions badly. In particular:

      1. Catching Exception too low. The wrapper around setKeys should only catch IOException.
      2. InterruptedException is ignored. It should be caught at the top level and exit run.
      3. Throwable is not caught. It should be caught at the top level and kill the Balancer server process.

        class AccessKeyUpdater implements Runnable {
      
          public void run() {
            while (shouldRun) {
              try {
                accessTokenHandler.setKeys(namenode.getAccessKeys());
              } catch (Exception e) {
                LOG.error(StringUtils.stringifyException(e));
              }
              try {
                Thread.sleep(keyUpdaterInterval);
              } catch (InterruptedException ie) {
              }
            }
          }
        }
      

        Attachments

        1. HDFS-776.0.patch
          1 kB
          Brock Noland
        2. HDFS-776.patch
          3 kB
          Uma Maheswara Rao G
        3. HDFS-776.patch
          3 kB
          Uma Maheswara Rao G
        4. HDFS-776.patch
          2 kB
          Uma Maheswara Rao G
        5. HDFS-776.patch
          1 kB
          Uma Maheswara Rao G

          Activity

            People

            • Assignee:
              umamaheswararao Uma Maheswara Rao G
              Reporter:
              owen.omalley Owen O'Malley
            • Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: