Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.2
    • Component/s: balancer & mover
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The Balancer's AccessKeyUpdater handles exceptions badly. In particular:

      1. Catching Exception too low. The wrapper around setKeys should only catch IOException.
      2. InterruptedException is ignored. It should be caught at the top level and exit run.
      3. Throwable is not caught. It should be caught at the top level and kill the Balancer server process.

        class AccessKeyUpdater implements Runnable {
      
          public void run() {
            while (shouldRun) {
              try {
                accessTokenHandler.setKeys(namenode.getAccessKeys());
              } catch (Exception e) {
                LOG.error(StringUtils.stringifyException(e));
              }
              try {
                Thread.sleep(keyUpdaterInterval);
              } catch (InterruptedException ie) {
              }
            }
          }
        }
      
      1. HDFS-776.0.patch
        1 kB
        Brock Noland
      2. HDFS-776.patch
        3 kB
        Uma Maheswara Rao G
      3. HDFS-776.patch
        3 kB
        Uma Maheswara Rao G
      4. HDFS-776.patch
        2 kB
        Uma Maheswara Rao G
      5. HDFS-776.patch
        1 kB
        Uma Maheswara Rao G

        Activity

        Owen O'Malley created issue -
        Owen O'Malley made changes -
        Field Original Value New Value
        Description The Balancer's AccessKeyUpdater handles exceptions badly. In particular:

        1. Catching Exception too low. The wrapper around setKeys should only catch IOException.
        2. InterruptedException is ignored. It should be caught at the top level and exit run.
        3. Throwable is not caught. It should be caught at the top level and kill the Balancer server process.

        {quote}
          class AccessKeyUpdater implements Runnable {

            public void run() {
              while (shouldRun) {
                try {
                  accessTokenHandler.setKeys(namenode.getAccessKeys());
                } catch (Exception e) {
                  LOG.error(StringUtils.stringifyException(e));
                }
                try {
                  Thread.sleep(keyUpdaterInterval);
                } catch (InterruptedException ie) {
                }
              }
            }
          }
        {quote}
        The Balancer's AccessKeyUpdater handles exceptions badly. In particular:

        1. Catching Exception too low. The wrapper around setKeys should only catch IOException.
        2. InterruptedException is ignored. It should be caught at the top level and exit run.
        3. Throwable is not caught. It should be caught at the top level and kill the Balancer server process.

        {code}
          class AccessKeyUpdater implements Runnable {

            public void run() {
              while (shouldRun) {
                try {
                  accessTokenHandler.setKeys(namenode.getAccessKeys());
                } catch (Exception e) {
                  LOG.error(StringUtils.stringifyException(e));
                }
                try {
                  Thread.sleep(keyUpdaterInterval);
                } catch (InterruptedException ie) {
                }
              }
            }
          }
        {code}
        Component/s Balancer [ 12313153 ]
        Robert Chansler made changes -
        Priority Critical [ 2 ] Blocker [ 1 ]
        Hide
        Tom White added a comment -

        This shouldn't necessarily be considered a blocker for 0.21 - it could be fixed in a point release for example.

        Show
        Tom White added a comment - This shouldn't necessarily be considered a blocker for 0.21 - it could be fixed in a point release for example.
        Tom White made changes -
        Priority Blocker [ 1 ] Critical [ 2 ]
        Tom White made changes -
        Fix Version/s 0.21.0 [ 12314046 ]
        Hide
        Brock Noland added a comment -

        1. Fixed
        2. Loop is exited on interrupt.
        3. Caught, printed, logged, and System.exit.

        Show
        Brock Noland added a comment - 1. Fixed 2. Loop is exited on interrupt. 3. Caught, printed, logged, and System.exit.
        Brock Noland made changes -
        Attachment HDFS-776.0.patch [ 12484459 ]
        Uma Maheswara Rao G made changes -
        Attachment HDFS-776.patch [ 12505799 ]
        Hide
        Uma Maheswara Rao G added a comment -

        Patch looks good.
        Updated patch removes the unnecessary stacktraces and updated the messages.

        Show
        Uma Maheswara Rao G added a comment - Patch looks good. Updated patch removes the unnecessary stacktraces and updated the messages.
        Uma Maheswara Rao G made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Uma Maheswara Rao G [ umamaheswararao ]
        Hide
        Brock Noland added a comment -

        +1 patch looks good

        Show
        Brock Noland added a comment - +1 patch looks good
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12505799/HDFS-776.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hdfs.server.datanode.TestMulitipleNNDataBlockScanner

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1625//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1625//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1625//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12505799/HDFS-776.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.server.datanode.TestMulitipleNNDataBlockScanner +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1625//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1625//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1625//console This message is automatically generated.
        Uma Maheswara Rao G made changes -
        Attachment HDFS-776.patch [ 12505987 ]
        Hide
        Uma Maheswara Rao G added a comment -

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hdfs.server.datanode.TestMulitipleNNDataBlockScanner

        This test failure seems to be unrelated. I ran this test several times. It is passing always.

        -------------------------------------------------------
        T E S T S
        -------------------------------------------------------
        Running org.apache.hadoop.hdfs.server.datanode.TestMulitipleNNDataBlockScanner
        Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 163.079 sec

        Results :

        Tests run: 3, Failures: 0, Errors: 0, Skipped: 0

        [INFO]
        [INFO] ------------------------------------------------------------------------
        [INFO] Building Apache Hadoop HDFS Project 0.24.0-SNAPSHOT
        [INFO] ------------------------------------------------------------------------
        [INFO]

        added the findbug comment to excludes list.

        Show
        Uma Maheswara Rao G added a comment - -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.server.datanode.TestMulitipleNNDataBlockScanner This test failure seems to be unrelated. I ran this test several times. It is passing always. ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.hdfs.server.datanode.TestMulitipleNNDataBlockScanner Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 163.079 sec Results : Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building Apache Hadoop HDFS Project 0.24.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] added the findbug comment to excludes list.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12505987/HDFS-776.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hdfs.TestDatanodeDeath
        org.apache.hadoop.hdfs.TestFileAppend2
        org.apache.hadoop.hdfs.TestDFSClientRetries
        org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage
        org.apache.hadoop.hdfs.TestSetrepIncreasing

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1631//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1631//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12505987/HDFS-776.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hdfs.TestDatanodeDeath org.apache.hadoop.hdfs.TestFileAppend2 org.apache.hadoop.hdfs.TestDFSClientRetries org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage org.apache.hadoop.hdfs.TestSetrepIncreasing +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1631//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1631//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > 3. Throwable is not caught. It should be caught at the top level and kill the Balancer server process.

        I disagree since balancer supports multiple namenodes. If a balancer is working with NN1, then failing updating the keys with NN2 should not stop NN1's work.

        How about throwing an exception in getAccessToken(..) when it is called? We may set shouldRun to false in run() and the check shouldRun in getAccessToken(..).

        Show
        Tsz Wo Nicholas Sze added a comment - > 3. Throwable is not caught. It should be caught at the top level and kill the Balancer server process. I disagree since balancer supports multiple namenodes. If a balancer is working with NN1, then failing updating the keys with NN2 should not stop NN1's work. How about throwing an exception in getAccessToken(..) when it is called? We may set shouldRun to false in run() and the check shouldRun in getAccessToken(..).
        Hide
        Uma Maheswara Rao G added a comment -

        Yep, considering multiple Namenodes support in Balancer today, your points make sense to me.

        How about throwing an exception in getAccessToken(..) when it is called? We may set shouldRun to false in run() and the check shouldRun in getAccessToken(..).

        this proposal sounds good. Let me take a look.

        Show
        Uma Maheswara Rao G added a comment - Yep, considering multiple Namenodes support in Balancer today, your points make sense to me. How about throwing an exception in getAccessToken(..) when it is called? We may set shouldRun to false in run() and the check shouldRun in getAccessToken(..). this proposal sounds good. Let me take a look.
        Hide
        Uma Maheswara Rao G added a comment -

        Attached the patch. getAccessToken will check about shouldRun flag and handle throwable outside and sets the shouldRun flag to false instead of shutdown.
        Test: ran the all balancer tests to check this is not effecting.

        Show
        Uma Maheswara Rao G added a comment - Attached the patch. getAccessToken will check about shouldRun flag and handle throwable outside and sets the shouldRun flag to false instead of shutdown. Test: ran the all balancer tests to check this is not effecting.
        Uma Maheswara Rao G made changes -
        Attachment HDFS-776.patch [ 12514120 ]
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12514120/HDFS-776.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1862//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1862//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12514120/HDFS-776.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1862//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1862//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -
        • The first one should be IOException, not Exception.
        • For InterruptedException, it is better to use LOG.info(..) since interrupting a thread is a normal behavior.
        Show
        Tsz Wo Nicholas Sze added a comment - The first one should be IOException, not Exception. For InterruptedException, it is better to use LOG.info(..) since interrupting a thread is a normal behavior.
        Uma Maheswara Rao G made changes -
        Attachment HDFS-776.patch [ 12514178 ]
        Hide
        Uma Maheswara Rao G added a comment -

        The first one should be IOException, not Exception.

        Oops. its my mistake. sorry, In previous patch i made that as IOException. In current one only forgot to change . Thanks a lot for noticing.I have updated it.

        For InterruptedException, it is better to use LOG.info(..) since interrupting a thread is a normal behavior.

        done.

        Thanks a lot for review.

        Show
        Uma Maheswara Rao G added a comment - The first one should be IOException, not Exception. Oops. its my mistake. sorry, In previous patch i made that as IOException. In current one only forgot to change . Thanks a lot for noticing.I have updated it. For InterruptedException, it is better to use LOG.info(..) since interrupting a thread is a normal behavior. done. Thanks a lot for review.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12514178/HDFS-776.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1863//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1863//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12514178/HDFS-776.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1863//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1863//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > ... In previous patch i made that as IOException. ...

        Yes, I saw that.

        +1 the new patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - > ... In previous patch i made that as IOException. ... Yes, I saw that. +1 the new patch looks good.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Uma!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Uma!
        Tsz Wo Nicholas Sze made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.24.0 [ 12317653 ]
        Fix Version/s 0.23.2 [ 12319852 ]
        Resolution Unresolved [ 9 ]
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks a lot Nicholas, for the reviews!

        Show
        Uma Maheswara Rao G added a comment - Thanks a lot Nicholas, for the reviews!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Commit #532 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/532/)
        svn merge -c 1243654 from trunk for HDFS-776. (Revision 1243657)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243657
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Commit #532 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/532/ ) svn merge -c 1243654 from trunk for HDFS-776 . (Revision 1243657) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243657 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1794 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1794/)
        HDFS-776. Fix exception handling in Balancer. Contributed by Uma Maheswara Rao G (Revision 1243654)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243654
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1794 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1794/ ) HDFS-776 . Fix exception handling in Balancer. Contributed by Uma Maheswara Rao G (Revision 1243654) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243654 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-0.23-Commit #544 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/544/)
        svn merge -c 1243654 from trunk for HDFS-776. (Revision 1243657)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243657
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-0.23-Commit #544 (See https://builds.apache.org/job/Hadoop-Common-0.23-Commit/544/ ) svn merge -c 1243654 from trunk for HDFS-776 . (Revision 1243657) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243657 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #1720 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1720/)
        HDFS-776. Fix exception handling in Balancer. Contributed by Uma Maheswara Rao G (Revision 1243654)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243654
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #1720 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1720/ ) HDFS-776 . Fix exception handling in Balancer. Contributed by Uma Maheswara Rao G (Revision 1243654) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243654 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Commit #548 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/548/)
        svn merge -c 1243654 from trunk for HDFS-776. (Revision 1243657)

        Result = ABORTED
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243657
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Commit #548 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/548/ ) svn merge -c 1243654 from trunk for HDFS-776 . (Revision 1243657) Result = ABORTED szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243657 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #1731 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1731/)
        HDFS-776. Fix exception handling in Balancer. Contributed by Uma Maheswara Rao G (Revision 1243654)

        Result = ABORTED
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243654
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #1731 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1731/ ) HDFS-776 . Fix exception handling in Balancer. Contributed by Uma Maheswara Rao G (Revision 1243654) Result = ABORTED szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243654 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I somehow set the resolution to "Unresolved". Reopen to fix it.

        Show
        Tsz Wo Nicholas Sze added a comment - I somehow set the resolution to "Unresolved". Reopen to fix it.
        Tsz Wo Nicholas Sze made changes -
        Resolution Unresolved [ 9 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Tsz Wo Nicholas Sze made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #195 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/195/)
        svn merge -c 1243654 from trunk for HDFS-776. (Revision 1243657)

        Result = FAILURE
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243657
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #195 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/195/ ) svn merge -c 1243654 from trunk for HDFS-776 . (Revision 1243657) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243657 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #955 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/955/)
        HDFS-776. Fix exception handling in Balancer. Contributed by Uma Maheswara Rao G (Revision 1243654)

        Result = FAILURE
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243654
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #955 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/955/ ) HDFS-776 . Fix exception handling in Balancer. Contributed by Uma Maheswara Rao G (Revision 1243654) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243654 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #168 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/168/)
        svn merge -c 1243654 from trunk for HDFS-776. (Revision 1243657)

        Result = FAILURE
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243657
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
        • /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #168 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/168/ ) svn merge -c 1243654 from trunk for HDFS-776 . (Revision 1243657) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243657 Files : /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #990 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/990/)
        HDFS-776. Fix exception handling in Balancer. Contributed by Uma Maheswara Rao G (Revision 1243654)

        Result = SUCCESS
        szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243654
        Files :

        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java
        • /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #990 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/990/ ) HDFS-776 . Fix exception handling in Balancer. Contributed by Uma Maheswara Rao G (Revision 1243654) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1243654 Files : /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/balancer/TestBalancerWithMultipleNameNodes.java
        Arun C Murthy made changes -
        Fix Version/s 0.24.0 [ 12317653 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        744d 3h 33m 1 Uma Maheswara Rao G 01/Dec/11 20:14
        Patch Available Patch Available Resolved Resolved
        73d 22h 56m 1 Tsz Wo Nicholas Sze 13/Feb/12 19:11
        Resolved Resolved Reopened Reopened
        47m 50s 1 Tsz Wo Nicholas Sze 13/Feb/12 19:59
        Reopened Reopened Resolved Resolved
        10s 1 Tsz Wo Nicholas Sze 13/Feb/12 19:59

          People

          • Assignee:
            Uma Maheswara Rao G
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            13 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development