Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7758

Retire FsDatasetSpi#getVolumes() and use FsDatasetSpi#getVolumeRefs() instead

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.6.0
    • 2.8.0, 3.0.0-alpha1
    • datanode
    • None

    Description

      HDFS-7496 introduced reference-counting the volume instances being used to prevent race condition when hot swapping a volume.

      However, FsDatasetSpi#getVolumes() can still leak the volume instance without increasing its reference count. In this JIRA, we retire the FsDatasetSpi#getVolumes() and propose FsDatasetSpi#getVolumeRefs() and etc. method to access FsVolume. Thus it makes sure that the consumer of FsVolume always has correct reference count.

      Attachments

        1. HDFS-7758.000.patch
          58 kB
          Lei (Eddy) Xu
        2. HDFS-7758.001.patch
          57 kB
          Lei (Eddy) Xu
        3. HDFS-7758.002.patch
          59 kB
          Lei (Eddy) Xu
        4. HDFS-7758.003.patch
          62 kB
          Lei (Eddy) Xu
        5. HDFS-7758.004.patch
          69 kB
          Lei (Eddy) Xu
        6. HDFS-7758.005.patch
          70 kB
          Lei (Eddy) Xu
        7. HDFS-7758.006.patch
          68 kB
          Lei (Eddy) Xu
        8. HDFS-7758.007.patch
          72 kB
          Lei (Eddy) Xu
        9. HDFS-7758.008.patch
          74 kB
          Lei (Eddy) Xu
        10. HDFS-7758.010.patch
          74 kB
          Lei (Eddy) Xu

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            eddyxu Lei (Eddy) Xu
            eddyxu Lei (Eddy) Xu
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment