[HDFS-7757] Misleading error messages in FSImage.java

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.7.0
• Component/s: namenode
• Target Version/s: 2.7.0
• Hadoop Flags: Reviewed
• Assignee: Brahma Reddy Battula
• Reporter: Arpit Agarwal
• Created: 09/Feb/15 22:40
• Updated: 10/Apr/15 20:29
• Resolved: 03/Mar/15 18:57

Description

If a quota violation is detected while loading an image, the NameNode logs scary error messages indicating a bug. However the quota violation state is very easy to get into e.g.

1. Copy a 2MB file to a directory.
2. Set a disk space quota of 1MB on the directory. We are in quota violation state now.

We should reword the error messages, ideally making them warnings and suggesting the administrator needs to fix the quotas:

Relevant code:

        LOG.error("BUG: Diskspace quota violation in image for "
            + dir.getFullPathName()
            + " quota = " + dsQuota + " < consumed = " + diskspace);
...
          LOG.error("BUG Disk quota by storage type violation in image for "
              + dir.getFullPathName()
              + " type = " + t.toString() + " quota = "
              + typeQuota + " < consumed " + typeSpace);