Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-775

FSDataset calls getCapacity() twice -bug?

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.22.0
    • 0.21.0
    • datanode
    • None

    Description

      I'm not sure this is a bug or "as intended", but I thought I'd mention it.

      FSDataset.getCapacity() calls DF.getCapacity() twice, when evaluating its capacity. Although there is caching to stop the shell being exec'd twice in a row, there is a risk that the first call doesn't run the shell, and the second does -so the value changes during the method.

      If that is not intended, it is better to cache the first value for the whole method

      Attachments

        1. HDFS-775-1.patch
          0.9 kB
          Steve Loughran
        2. HDFS-775-2.patch
          0.9 kB
          Steve Loughran

        Activity

          People

            stevel@apache.org Steve Loughran
            stevel@apache.org Steve Loughran
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: