Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.7.0
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This is to fix testTruncateEditLogLoad(), which is failing due to the bug described in HDFS-7611.

      1. HDFS-7676.patch
        0.9 kB
        Konstantin Shvachko

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          About to make an RC for 2.6.1. Dropping the 2.6.1 label as truncate wasn't there in 2.6.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - About to make an RC for 2.6.1. Dropping the 2.6.1 label as truncate wasn't there in 2.6.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Konstantin Shvachko, are this JIRA and HDFS-7654 duplicates? Should we close HDFS-7654?

          Show
          cmccabe Colin P. McCabe added a comment - Konstantin Shvachko , are this JIRA and HDFS-7654 duplicates? Should we close HDFS-7654 ?
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2035 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2035/)
          HDFS-7676. Fix TestFileTruncate to avoid bug of HDFS-7611. Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2035 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2035/ ) HDFS-7676 . Fix TestFileTruncate to avoid bug of HDFS-7611 . Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #85 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/85/)
          HDFS-7676. Fix TestFileTruncate to avoid bug of HDFS-7611. Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #85 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/85/ ) HDFS-7676 . Fix TestFileTruncate to avoid bug of HDFS-7611 . Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #81 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/81/)
          HDFS-7676. Fix TestFileTruncate to avoid bug of HDFS-7611. Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #81 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/81/ ) HDFS-7676 . Fix TestFileTruncate to avoid bug of HDFS-7611 . Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2016 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2016/)
          HDFS-7676. Fix TestFileTruncate to avoid bug of HDFS-7611. Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2016 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2016/ ) HDFS-7676 . Fix TestFileTruncate to avoid bug of HDFS-7611 . Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #818 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/818/)
          HDFS-7676. Fix TestFileTruncate to avoid bug of HDFS-7611. Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #818 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/818/ ) HDFS-7676 . Fix TestFileTruncate to avoid bug of HDFS-7611 . Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #84 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/84/)
          HDFS-7676. Fix TestFileTruncate to avoid bug of HDFS-7611. Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #84 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/84/ ) HDFS-7676 . Fix TestFileTruncate to avoid bug of HDFS-7611 . Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6926 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6926/)
          HDFS-7676. Fix TestFileTruncate to avoid bug of HDFS-7611. Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6926 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6926/ ) HDFS-7676 . Fix TestFileTruncate to avoid bug of HDFS-7611 . Contributed by Konstantin Shvachko. (shv: rev 370396509deb5c9319c5db880f3e4058b20a7514) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileTruncate.java
          Hide
          shv Konstantin Shvachko added a comment -

          I just committed this to trunk and branch-2.

          Show
          shv Konstantin Shvachko added a comment - I just committed this to trunk and branch-2.
          Hide
          shv Konstantin Shvachko added a comment -

          Test failures are clearly unrelated.

          Show
          shv Konstantin Shvachko added a comment - Test failures are clearly unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12694390/HDFS-7676.patch
          against trunk revision 8f26d5a.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
          org.apache.hadoop.hdfs.server.datanode.TestBlockScanner
          org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9324//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9324//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12694390/HDFS-7676.patch against trunk revision 8f26d5a. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestCheckpoint org.apache.hadoop.hdfs.server.datanode.TestBlockScanner org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9324//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9324//console This message is automatically generated.
          Hide
          cos Konstantin Boudnik added a comment -

          +1 - good catch!

          Show
          cos Konstantin Boudnik added a comment - +1 - good catch!
          Hide
          shv Konstantin Shvachko added a comment -

          The fix is to shrink edits so that it does not include transactions from previous runs. That way restarts in testTruncateEditLogLoad will not replay unrelated edits.
          Ran TestFileTruncate with this patch many times - no failures.

          Show
          shv Konstantin Shvachko added a comment - The fix is to shrink edits so that it does not include transactions from previous runs. That way restarts in testTruncateEditLogLoad will not replay unrelated edits. Ran TestFileTruncate with this patch many times - no failures.

            People

            • Assignee:
              shv Konstantin Shvachko
              Reporter:
              shv Konstantin Shvachko
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development