Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7495

Remove updatePosition argument from DFSInputStream#getBlockAt()

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.7.0
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      There're two locks: one on DFSInputStream.this , one on DFSInputStream.infoLock
      Normally lock is obtained on infoLock, then on DFSInputStream.infoLock

      However, such order is not observed in DFSInputStream#getBlockAt() :

          synchronized(infoLock) {
      ...
            if (updatePosition) {
              // synchronized not strictly needed, since we only get here
              // from synchronized caller methods
              synchronized(this) {
      

        Attachments

        1. HDFS-7495.002.patch
          4 kB
          Colin McCabe
        2. hdfs-7495-001.patch
          0.9 kB
          Ted Yu

          Issue Links

            Activity

              People

              • Assignee:
                cmccabe Colin McCabe
                Reporter:
                yuzhihong@gmail.com Ted Yu
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: