[HDFS-7494] Checking of closed in DFSInputStream#pread() should be protected by synchronization

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.7.0
• Target Version/s: 2.7.0
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 08/Dec/14 22:25
• Updated: 10/Apr/15 20:30
• Resolved: 16/Dec/14 19:08

Description

  private int pread(long position, byte[] buffer, int offset, int length)
      throws IOException {
    // sanity checks
    dfsClient.checkOpen();
    if (closed) {

Checking of closed should be protected by holding lock on "DFSInputStream.this"

Issue Links

• is related to: HDFS-6735 A minor optimization to avoid pread() be blocked by read() inside the same DFSInputStream