Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 2.7.0
    • Component/s: nfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This JIRA is to track the effort to add web UI for NFS gateway to show some metrics and configuration related information.

      1. HDFS-7424.001.patch
        13 kB
        Brandon Li
      2. HDFS-7424.002.patch
        13 kB
        Brandon Li
      3. HDFS-7424.003.patch
        12 kB
        Brandon Li
      4. HDFS-7424.004.patch
        12 kB
        Brandon Li
      5. HDFS-7424.005.patch
        13 kB
        Brandon Li
      6. HDFS-7424.006.patch
        13 kB
        Brandon Li
      7. HDFS-7424.007.patch
        13 kB
        Brandon Li
      8. HDFS-7424.008.patch
        12 kB
        Brandon Li

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12682940/HDFS-7424.001.patch
          against trunk revision 23dacb3.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          -1 javac. The patch appears to cause the build to fail.

          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8805//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12682940/HDFS-7424.001.patch against trunk revision 23dacb3. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8805//console This message is automatically generated.
          Hide
          brandonli Brandon Li added a comment -

          Rebased the patch.

          Show
          brandonli Brandon Li added a comment - Rebased the patch.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12683693/HDFS-7424.002.patch
          against trunk revision f43a20c.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.
          -1 core tests. Failed to build the native portion of hadoop-common prior to running the unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8838//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8838//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12683693/HDFS-7424.002.patch against trunk revision f43a20c. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . Failed to build the native portion of hadoop-common prior to running the unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8838//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8838//console This message is automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -

          Good work. Some comments:

          +/**
          + * Encapsulates the HTTP server started by the NFS3 gateway.
          + */
          +@InterfaceAudience.Private
          +public class Nfs3HttpServer {
          

          You can simply mark the class as package-local.

          +  void start() throws IOException {
          +    HttpServer2.Builder builder = new HttpServer2.Builder().setName("nfs3")
          +        .setConf(conf).setACL(new AccessControlList(conf.get(DFS_ADMIN, " ")));
          

          Please see DFSUtil.httpServerTemplateForNNAndJN.

          +  public int getSecurePort() {
          +    return this.infoSecurePort;
          +  }
          +
          

          This is unused.

          +      URL url = new URL(scheme + "://" + NetUtils.getHostPortString(addr)
          +          + "/jmx");
          +      URLConnection conn = connectionFactory.openConnection(url);
          +      conn.connect();
          +
          +      InputStream is = conn.getInputStream();
          +      InputStreamReader isr = new InputStreamReader(is);
          +
          +      int numCharsRead;
          +      char[] charArray = new char[1024];
          +      StringBuffer sb = new StringBuffer();
          +      while ((numCharsRead = isr.read(charArray)) > 0) {
          +        sb.append(charArray, 0, numCharsRead);
          +      }
          +      result = sb.toString();
          +
          +    } catch (Exception e) {
          +      e.printStackTrace();
          +      return null;
          +    }
          +    return result;
          

          See DFSTestUtil.urlGet().

          Show
          wheat9 Haohui Mai added a comment - Good work. Some comments: +/** + * Encapsulates the HTTP server started by the NFS3 gateway. + */ +@InterfaceAudience.Private + public class Nfs3HttpServer { You can simply mark the class as package-local. + void start() throws IOException { + HttpServer2.Builder builder = new HttpServer2.Builder().setName( "nfs3" ) + .setConf(conf).setACL( new AccessControlList(conf.get(DFS_ADMIN, " " ))); Please see DFSUtil.httpServerTemplateForNNAndJN . + public int getSecurePort() { + return this .infoSecurePort; + } + This is unused. + URL url = new URL(scheme + ": //" + NetUtils.getHostPortString(addr) + + "/jmx" ); + URLConnection conn = connectionFactory.openConnection(url); + conn.connect(); + + InputStream is = conn.getInputStream(); + InputStreamReader isr = new InputStreamReader(is); + + int numCharsRead; + char [] charArray = new char [1024]; + StringBuffer sb = new StringBuffer (); + while ((numCharsRead = isr.read(charArray)) > 0) { + sb.append(charArray, 0, numCharsRead); + } + result = sb.toString(); + + } catch (Exception e) { + e.printStackTrace(); + return null ; + } + return result; See DFSTestUtil.urlGet() .
          Hide
          brandonli Brandon Li added a comment -

          Uploaded a patch to address Haohui's comments.

          Show
          brandonli Brandon Li added a comment - Uploaded a patch to address Haohui's comments.
          Hide
          wheat9 Haohui Mai added a comment -
          +@InterfaceAudience.Private
          

          This line can be removed since the class is a package-local class now. +1 after addressing it.

          Show
          wheat9 Haohui Mai added a comment - +@InterfaceAudience.Private This line can be removed since the class is a package-local class now. +1 after addressing it.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12683937/HDFS-7424.003.patch
          against trunk revision c1f2bb2.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs:

          org.apache.hadoop.hdfs.server.namenode.TestBackupNode
          org.apache.hadoop.hdfs.nfs.nfs3.TestNfs3HttpServer

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8854//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8854//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12683937/HDFS-7424.003.patch against trunk revision c1f2bb2. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs: org.apache.hadoop.hdfs.server.namenode.TestBackupNode org.apache.hadoop.hdfs.nfs.nfs3.TestNfs3HttpServer +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8854//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8854//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12683955/HDFS-7424.004.patch
          against trunk revision c1f2bb2.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs:

          org.apache.hadoop.hdfs.nfs.nfs3.TestNfs3HttpServer

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8859//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8859//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12683955/HDFS-7424.004.patch against trunk revision c1f2bb2. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs: org.apache.hadoop.hdfs.nfs.nfs3.TestNfs3HttpServer +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8859//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8859//console This message is automatically generated.
          Hide
          brandonli Brandon Li added a comment -

          Uploaded a new patch to fix the unit test failure.

          Show
          brandonli Brandon Li added a comment - Uploaded a new patch to fix the unit test failure.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12684455/HDFS-7424.005.patch
          against trunk revision c732ed7.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 9 warning messages.
          See https://builds.apache.org/job/PreCommit-HDFS-Build/8880//artifact/patchprocess/diffJavadocWarnings.txt for details.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.server.balancer.TestBalancer

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8880//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8880//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684455/HDFS-7424.005.patch against trunk revision c732ed7. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 9 warning messages. See https://builds.apache.org/job/PreCommit-HDFS-Build/8880//artifact/patchprocess/diffJavadocWarnings.txt for details. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.balancer.TestBalancer +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8880//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8880//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12684455/HDFS-7424.005.patch
          against trunk revision 0c58890.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs:

          org.apache.hadoop.hdfs.nfs.nfs3.TestNfs3HttpServer

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8886//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8886//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684455/HDFS-7424.005.patch against trunk revision 0c58890. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs: org.apache.hadoop.hdfs.nfs.nfs3.TestNfs3HttpServer +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8886//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8886//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12684504/HDFS-7424.006.patch
          against trunk revision 0c58890.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs:

          org.apache.hadoop.hdfs.nfs.nfs3.TestNfs3HttpServer

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8888//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8888//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684504/HDFS-7424.006.patch against trunk revision 0c58890. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs: org.apache.hadoop.hdfs.nfs.nfs3.TestNfs3HttpServer +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8888//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8888//console This message is automatically generated.
          Hide
          brandonli Brandon Li added a comment -

          The unit test had jvm dependency. New patch removed it.

          Show
          brandonli Brandon Li added a comment - The unit test had jvm dependency. New patch removed it.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12684560/HDFS-7424.007.patch
          against trunk revision 51af8d3.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8891//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8891//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684560/HDFS-7424.007.patch against trunk revision 51af8d3. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8891//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8891//console This message is automatically generated.
          Hide
          wheat9 Haohui Mai added a comment -
          +    this.httpServer.setAttribute("nfs3", this);
          +    this.httpServer.setAttribute(JspHelper.CURRENT_CONF, conf);
          

          Are they necessary? It doesn't seem like that there are servlets using the attributes.

          Show
          wheat9 Haohui Mai added a comment - + this .httpServer.setAttribute( "nfs3" , this ); + this .httpServer.setAttribute(JspHelper.CURRENT_CONF, conf); Are they necessary? It doesn't seem like that there are servlets using the attributes.
          Hide
          brandonli Brandon Li added a comment -

          They are removed in the new patch. Thanks!

          Show
          brandonli Brandon Li added a comment - They are removed in the new patch. Thanks!
          Hide
          wheat9 Haohui Mai added a comment -

          +1 pending jenkins.

          Show
          wheat9 Haohui Mai added a comment - +1 pending jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12684750/HDFS-7424.008.patch
          against trunk revision 52bcefc.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The test build failed in hadoop-hdfs-project/hadoop-hdfs-nfs

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8901//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8901//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684750/HDFS-7424.008.patch against trunk revision 52bcefc. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The test build failed in hadoop-hdfs-project/hadoop-hdfs-nfs +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8901//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8901//console This message is automatically generated.
          Hide
          brandonli Brandon Li added a comment -

          According to the console output, the tests all passed and the build error seems to be related with some infrastructure problem.

          Show
          brandonli Brandon Li added a comment - According to the console output, the tests all passed and the build error seems to be related with some infrastructure problem.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12684750/HDFS-7424.008.patch
          against trunk revision a31e016.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8913//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8913//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684750/HDFS-7424.008.patch against trunk revision a31e016. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-nfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8913//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8913//console This message is automatically generated.
          Hide
          brandonli Brandon Li added a comment -

          I've committed the patch. Thank you, Haohui, for the review!

          Show
          brandonli Brandon Li added a comment - I've committed the patch. Thank you, Haohui, for the review!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6648 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6648/)
          HDFS-7424. Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c)

          • hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6648 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6648/ ) HDFS-7424 . Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c) hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #765 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/765/)
          HDFS-7424. Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c)

          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #765 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/765/ ) HDFS-7424 . Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c) hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #26 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/26/)
          HDFS-7424. Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c)

          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #26 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/26/ ) HDFS-7424 . Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #26 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/26/)
          HDFS-7424. Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #26 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/26/ ) HDFS-7424 . Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1958 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1958/)
          HDFS-7424. Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c)

          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1958 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1958/ ) HDFS-7424 . Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java hadoop-hdfs-project/hadoop-hdfs/pom.xml
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1980 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1980/)
          HDFS-7424. Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c)

          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1980 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1980/ ) HDFS-7424 . Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c) hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #26 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/26/)
          HDFS-7424. Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c)

          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java
          • hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java
          • hadoop-hdfs-project/hadoop-hdfs/pom.xml
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #26 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/26/ ) HDFS-7424 . Add web UI for NFS gateway. Contributed by Brandon Li (brandonli: rev 1bbcc3d0320b9435317bfeaa078af22d4de8d00c) hadoop-hdfs-project/hadoop-hdfs-nfs/src/test/java/org/apache/hadoop/hdfs/nfs/nfs3/TestNfs3HttpServer.java hadoop-hdfs-project/hadoop-hdfs-nfs/pom.xml hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfigKeys.java hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/Nfs3HttpServer.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/nfs3/RpcProgramNfs3.java

            People

            • Assignee:
              brandonli Brandon Li
              Reporter:
              brandonli Brandon Li
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development