-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12679694/HDFS-7336.patch
against trunk revision 8549fa5.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. There were no new javadoc warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8672//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8672//console
This message is automatically generated.
This means that even though we pass buffersize as a parameter into the contructors of DFSInputStream it does not determine the size of the buffer.
I think we can live with the default buffer, so I just propose to remove the member.
Another way is to incorporate buffersize into block reader. Not sure if it helps anything though.