Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The HDFS-related sbin commands (except for *-dfs.sh) should be marked as deprecated in trunk so that they may be removed from a future release.

      1. HDFS-7322-00.patch
        0.6 kB
        Allen Wittenauer

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #97 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/97/)
          HDFS-7322. deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #97 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/97/ ) HDFS-7322 . deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2054 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2054/)
          HDFS-7322. deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2054 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2054/ ) HDFS-7322 . deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #104 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/104/)
          HDFS-7322. deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #104 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/104/ ) HDFS-7322 . deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2035 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2035/)
          HDFS-7322. deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2035 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2035/ ) HDFS-7322 . deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #837 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/837/)
          HDFS-7322. deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215)

          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #837 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/837/ ) HDFS-7322 . deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215) hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #103 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/103/)
          HDFS-7322. deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #103 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/103/ ) HDFS-7322 . deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7093 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7093/)
          HDFS-7322. deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215)

          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7093 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7093/ ) HDFS-7322 . deprecate sbin/hadoop-daemon.sh (aw) (aw: rev 58cb9f529381c420952eb307eabdfbca6c68a215) hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemon.sh hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          aw Allen Wittenauer added a comment -

          Thanks for the review!

          Committed to trunk.

          Show
          aw Allen Wittenauer added a comment - Thanks for the review! Committed to trunk.
          Hide
          cnauroth Chris Nauroth added a comment -

          +1 for the patch. Thank you, Allen.

          The javac warnings can't possibly be related, because this patch doesn't touch the Java codebase.

          Show
          cnauroth Chris Nauroth added a comment - +1 for the patch. Thank you, Allen. The javac warnings can't possibly be related, because this patch doesn't touch the Java codebase.
          Hide
          cmccabe Colin P. McCabe added a comment -

          fair enough

          Show
          cmccabe Colin P. McCabe added a comment - fair enough
          Hide
          aw Allen Wittenauer added a comment -
          • They aren't really 'hadoop' commands but 'hdfs' commands. They should have gotten deprecated in the 1.x to 2.x conversion with replacement hdfs-daemon* commands instead.
          • The functionality has been moved, which makes this code vestigial. There is precedence for removing dead code.
          • Maintaining excess code is a burden on the project. Traditionally, the shell code is some of the worst maintain code in the code base, so removing any of it is a great benefit.
          Show
          aw Allen Wittenauer added a comment - They aren't really 'hadoop' commands but 'hdfs' commands. They should have gotten deprecated in the 1.x to 2.x conversion with replacement hdfs-daemon* commands instead. The functionality has been moved, which makes this code vestigial. There is precedence for removing dead code. Maintaining excess code is a burden on the project. Traditionally, the shell code is some of the worst maintain code in the code base, so removing any of it is a great benefit.
          Hide
          cmccabe Colin P. McCabe added a comment -

          What's the rationale for deprecating these?

          Show
          cmccabe Colin P. McCabe added a comment - What's the rationale for deprecating these?
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12697158/HDFS-7322-00.patch
          against trunk revision da2fb2b.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          -1 javac. The applied patch generated 1163 javac compiler warnings (more than the trunk's current 1151 warnings).

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9471//testReport/
          Javac warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/9471//artifact/patchprocess/diffJavacWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9471//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12697158/HDFS-7322-00.patch against trunk revision da2fb2b. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The applied patch generated 1163 javac compiler warnings (more than the trunk's current 1151 warnings). +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9471//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/9471//artifact/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9471//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          -00:

          • initial version
          Show
          aw Allen Wittenauer added a comment - -00: initial version

            People

            • Assignee:
              aw Allen Wittenauer
              Reporter:
              aw Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development