Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-7263

Snapshot read can reveal future bytes for appended files.

    Details

    • Target Version/s:

      Description

      The following sequence of steps will produce extra bytes, that should not be visible, because they are not in the snapshot.

      • Create a file of size L, where L % blockSize != 0.
      • Create a snapshot
      • Append bytes to the file
      • Read file in the snapshot (not the current file)
      • You will see the bytes are read beoynd the original file size L
      1. HDFS-7263.patch
        5 kB
        Tao Luo
      2. HDFS-7263.patch
        5 kB
        Tao Luo
      3. HDFS-7263.patch
        4 kB
        Tao Luo
      4. TestSnapshotRead.java
        3 kB
        Konstantin Shvachko

        Issue Links

          Activity

          Hide
          shv Konstantin Shvachko added a comment -

          Here is the test that fails with current implementation.
          DFSInputStream should be fixed to take into account the actual file length and not try to read beyond it.

          - realLen = (int) Math.min(realLen, locatedBlocks.getFileLength());
          + realLen = (int) Math.min(realLen, locatedBlocks.getFileLength() - pos);
          
          Show
          shv Konstantin Shvachko added a comment - Here is the test that fails with current implementation. DFSInputStream should be fixed to take into account the actual file length and not try to read beyond it. - realLen = ( int ) Math .min(realLen, locatedBlocks.getFileLength()); + realLen = ( int ) Math .min(realLen, locatedBlocks.getFileLength() - pos);
          Hide
          taoluo Tao Luo added a comment -

          The LocatedBlocks returned from getLocatedBlocks(..) has a blocksize of the current block,
          while the file length is the length at the time of the snapshot.

          Current tests use the pread(..) path which uses the file length and position, however readWithStrategy(..) incorrectly allows reads
          beyond the file length of the snapshotted file.

          Show
          taoluo Tao Luo added a comment - The LocatedBlocks returned from getLocatedBlocks(..) has a blocksize of the current block, while the file length is the length at the time of the snapshot. Current tests use the pread(..) path which uses the file length and position, however readWithStrategy(..) incorrectly allows reads beyond the file length of the snapshotted file.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12676718/HDFS-7263.patch
          against trunk revision 7ab7545.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          -1 javac. The applied patch generated 1265 javac compiler warnings (more than the trunk's current 1264 warnings).

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestFileCreation

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8507//testReport/
          Javac warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8507//artifact/patchprocess/diffJavacWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8507//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12676718/HDFS-7263.patch against trunk revision 7ab7545. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The applied patch generated 1265 javac compiler warnings (more than the trunk's current 1264 warnings). +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestFileCreation +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8507//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8507//artifact/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8507//console This message is automatically generated.
          Hide
          shv Konstantin Shvachko added a comment -

          Tao, looks good. Seems like TestFileCreation actually succeeded, something went wrong with reporting.
          Could you check on the Java warnings. I couldn't find new warnings, but I may missed it.

          Show
          shv Konstantin Shvachko added a comment - Tao, looks good. Seems like TestFileCreation actually succeeded, something went wrong with reporting. Could you check on the Java warnings. I couldn't find new warnings, but I may missed it.
          Hide
          szetszwo Tsz Wo Nicholas Sze added a comment -

          Good catch and thanks for fixing it! I wonder what if the file remains open for append. Would reading from the snapshot file be able to read the extra bytes?

          Show
          szetszwo Tsz Wo Nicholas Sze added a comment - Good catch and thanks for fixing it! I wonder what if the file remains open for append. Would reading from the snapshot file be able to read the extra bytes?
          Hide
          taoluo Tao Luo added a comment -

          I think you may be right Nicholas. I'll add a test to verify this. Thanks

          Show
          taoluo Tao Luo added a comment - I think you may be right Nicholas. I'll add a test to verify this. Thanks
          Hide
          taoluo Tao Luo added a comment -

          Actually, BlockManager.createLocatedBlocks(..) always sets isLastBlockComplete to true,
          so reading from the snapshot won't read the extra bytes.

          Show
          taoluo Tao Luo added a comment - Actually, BlockManager.createLocatedBlocks(..) always sets isLastBlockComplete to true, so reading from the snapshot won't read the extra bytes.
          Hide
          taoluo Tao Luo added a comment -

          The newer patch includes a test for reading from a snapshot while the underlying file is still being appended.

          Show
          taoluo Tao Luo added a comment - The newer patch includes a test for reading from a snapshot while the underlying file is still being appended.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12677433/HDFS-7263.patch
          against trunk revision a16d022.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          -1 javac. The applied patch generated 1265 javac compiler warnings (more than the trunk's current 1264 warnings).

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestClientReportBadBlock
          org.apache.hadoop.hdfs.TestLeaseRecovery2

          The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestEncryptionZonesWithHA

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8556//testReport/
          Javac warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8556//artifact/patchprocess/diffJavacWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8556//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12677433/HDFS-7263.patch against trunk revision a16d022. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The applied patch generated 1265 javac compiler warnings (more than the trunk's current 1264 warnings). +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestClientReportBadBlock org.apache.hadoop.hdfs.TestLeaseRecovery2 The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestEncryptionZonesWithHA +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8556//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/8556//artifact/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8556//console This message is automatically generated.
          Hide
          taoluo Tao Luo added a comment -

          I can't reproduce these unit test failures locally. I don't think they are related to the patch.

          Chris Nauroth is seeing a similar occurrence of phantom javac warnings and test failures:
          https://issues.apache.org/jira/browse/HDFS-7291?focusedCommentId=14187457&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14187457

          Show
          taoluo Tao Luo added a comment - I can't reproduce these unit test failures locally. I don't think they are related to the patch. Chris Nauroth is seeing a similar occurrence of phantom javac warnings and test failures: https://issues.apache.org/jira/browse/HDFS-7291?focusedCommentId=14187457&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14187457
          Hide
          shv Konstantin Shvachko added a comment -

          I coudn't see the test failures or patch related java warnings locally with or without the patch.
          I have one nit. In the test you added for append you create a new snapshot2. This is not necessary for this particulare test case.
          Could you also add a comment that you are testing snapshot read of a file opened for append.

          Show
          shv Konstantin Shvachko added a comment - I coudn't see the test failures or patch related java warnings locally with or without the patch. I have one nit. In the test you added for append you create a new snapshot2. This is not necessary for this particulare test case. Could you also add a comment that you are testing snapshot read of a file opened for append.
          Hide
          taoluo Tao Luo added a comment -

          Simplified the test per Konstantin's review.

          Show
          taoluo Tao Luo added a comment - Simplified the test per Konstantin's review.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12678051/HDFS-7263.patch
          against trunk revision 3ae84e1.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8592//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8592//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12678051/HDFS-7263.patch against trunk revision 3ae84e1. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/8592//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8592//console This message is automatically generated.
          Hide
          shv Konstantin Shvachko added a comment -

          +1

          Show
          shv Konstantin Shvachko added a comment - +1
          Hide
          shv Konstantin Shvachko added a comment - - edited

          I just committed this. Thank you Tao.

          Show
          shv Konstantin Shvachko added a comment - - edited I just committed this. Thank you Tao.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6391 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6391/)
          HDFS-7263. Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (shv: rev 0126cf16b73843da2e504b6a03fee8bd93a404d5)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotFileLength.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6391 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6391/ ) HDFS-7263 . Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (shv: rev 0126cf16b73843da2e504b6a03fee8bd93a404d5) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotFileLength.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #728 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/728/)
          HDFS-7263. Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (shv: rev 0126cf16b73843da2e504b6a03fee8bd93a404d5)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotFileLength.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #728 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/728/ ) HDFS-7263 . Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (shv: rev 0126cf16b73843da2e504b6a03fee8bd93a404d5) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotFileLength.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1917 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1917/)
          HDFS-7263. Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (shv: rev 0126cf16b73843da2e504b6a03fee8bd93a404d5)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotFileLength.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1917 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1917/ ) HDFS-7263 . Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (shv: rev 0126cf16b73843da2e504b6a03fee8bd93a404d5) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotFileLength.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1942 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1942/)
          HDFS-7263. Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (shv: rev 0126cf16b73843da2e504b6a03fee8bd93a404d5)

          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotFileLength.java
          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1942 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1942/ ) HDFS-7263 . Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (shv: rev 0126cf16b73843da2e504b6a03fee8bd93a404d5) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestSnapshotFileLength.java hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java
          Hide
          taoluo Tao Luo added a comment -

          Thanks Nicholas and Konstantin for reviewing.

          Show
          taoluo Tao Luo added a comment - Thanks Nicholas and Konstantin for reviewing.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Cherry-picked to 2.6.1

          Show
          vinayrpet Vinayakumar B added a comment - Cherry-picked to 2.6.1
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8299 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8299/)
          HDFS-7263. Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8299 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8299/ ) HDFS-7263 . Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #287 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/287/)
          HDFS-7263. Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #287 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/287/ ) HDFS-7263 . Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1017 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1017/)
          HDFS-7263. Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1017 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1017/ ) HDFS-7263 . Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #284 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/284/)
          HDFS-7263. Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #284 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/284/ ) HDFS-7263 . Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2233 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2233/)
          HDFS-7263. Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2233 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2233/ ) HDFS-7263 . Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2214 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2214/)
          HDFS-7263. Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2214 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2214/ ) HDFS-7263 . Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #276 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/276/)
          HDFS-7263. Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #276 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/276/ ) HDFS-7263 . Snapshot read can reveal future bytes for appended files. Contributed by Tao Luo. (vinayakumarb: rev fa2641143c0d74c4fef122d79f27791e15d3b43f) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          This wasn't originally in 2.6.1, must have been committed to 2.6, which was already 2.6.2. I just committed this to 2.6.1 taking Sangjin Lee cherry-pick, which must have come from branch-2.6.

          Ran compilation and TestSnapshotFileLength before the push.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - This wasn't originally in 2.6.1, must have been committed to 2.6, which was already 2.6.2. I just committed this to 2.6.1 taking Sangjin Lee cherry-pick, which must have come from branch-2.6. Ran compilation and TestSnapshotFileLength before the push.

            People

            • Assignee:
              taoluo Tao Luo
              Reporter:
              shv Konstantin Shvachko
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development