[HDFS-7261] storageMap is accessed without synchronization in DatanodeDescriptor#updateHeartbeatState()

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Target Version/s: 2.8.0
• Assignee: Brahma Reddy Battula
• Reporter: Ted Yu
• Created: 17/Oct/14 21:08
• Updated: 30/Aug/16 01:40
• Resolved: 30/Mar/15 18:37

Description

Here is the code:

      failedStorageInfos = new HashSet<DatanodeStorageInfo>(
          storageMap.values());

In other places, the lock on "DatanodeDescriptor.storageMap" is held:

    synchronized (storageMap) {
      final Collection<DatanodeStorageInfo> storages = storageMap.values();
      return storages.toArray(new DatanodeStorageInfo[storages.size()]);
    }