Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-6581 Write to single replica in memory
  3. HDFS-7144

Fix findbugs warnings in RamDiskReplicaTracker

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.6.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Two more findbugs warnings:

      • Bad practice Warnings
        org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica.deleteSavedFiles() ignores exceptional return value of java.io.File.delete()
        Bug type RV_RETURN_VALUE_IGNORED_BAD_PRACTICE (click for details)
        In class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica
        In method org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica.deleteSavedFiles()
        Called method java.io.File.delete()
        At RamDiskReplicaTracker.java:[line 122]
        Another occurrence at RamDiskReplicaTracker.java:[line 127]
      • Dodgy Warnings
        org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaLruTracker$RamDiskReplicaLru doesn't override RamDiskReplicaTracker$RamDiskReplica.equals(Object)
        Bug type EQ_DOESNT_OVERRIDE_EQUALS (click for details)
        In class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaLruTracker$RamDiskReplicaLru
        Did you intend to override org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica.equals(Object)
        At RamDiskReplicaLruTracker.java:[lines 37-42]

        Attachments

        1. h7144_20140925.patch
          3 kB
          Tsz-wo Sze

          Activity

            People

            • Assignee:
              szetszwo Tsz-wo Sze
              Reporter:
              szetszwo Tsz-wo Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: