[HDFS-7144] Fix findbugs warnings in RamDiskReplicaTracker

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.6.0
• Component/s: datanode
• Hadoop Flags: Reviewed
• Assignee: Tsz-wo Sze
• Reporter: Tsz-wo Sze
• Created: 25/Sep/14 08:09
• Updated: 01/Dec/14 03:07
• Resolved: 25/Sep/14 18:16

Description

Two more findbugs warnings:

• Bad practice Warnings
  org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica.deleteSavedFiles() ignores exceptional return value of java.io.File.delete()
  Bug type RV_RETURN_VALUE_IGNORED_BAD_PRACTICE (click for details)
  In class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica
  In method org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica.deleteSavedFiles()
  Called method java.io.File.delete()
  At RamDiskReplicaTracker.java:[line 122]
  Another occurrence at RamDiskReplicaTracker.java:[line 127]

• Dodgy Warnings
  org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaLruTracker$RamDiskReplicaLru doesn't override RamDiskReplicaTracker$RamDiskReplica.equals(Object)
  Bug type EQ_DOESNT_OVERRIDE_EQUALS (click for details)
  In class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaLruTracker$RamDiskReplicaLru
  Did you intend to override org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.RamDiskReplicaTracker$RamDiskReplica.equals(Object)
  At RamDiskReplicaLruTracker.java:[lines 37-42]