Details

    • Test
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.22.0
    • 0.21.0
    • None
    • None

    Description

      While the number of test cases using injection is constantly increasing it brings in more and more new test classes. In the current pipeline testing infrastructure inheritance of the classes becomes more complicated as well.

      The aspect for hflush() fault injection tests need to be more careful about casting of a test object and make sure that it is of a proper type beforehand.

      Attachments

        1. HDFS-713.patch
          1 kB
          Konstantin I Boudnik
        2. HDFS-713.patch
          1 kB
          Konstantin I Boudnik
        3. HDFS-713.patch
          1 kB
          Konstantin I Boudnik

        Issue Links

        Activity

          Patch forces a type validation in advance

          cos Konstantin I Boudnik added a comment - Patch forces a type validation in advance

          One liner trivial fix

          cos Konstantin I Boudnik added a comment - One liner trivial fix

          Slightly better version of the same patch

          cos Konstantin I Boudnik added a comment - Slightly better version of the same patch

          Here's the result of test-patch run:

          There appear to be 104 release audit warnings before the patch and 104 release audit warnings after applying the patch.
          
          +1 overall.  
              +1 @author.  The patch does not contain any @author tags.
              +1 tests included.  The patch appears to include 3 new or modified tests.
              +1 javadoc.  The javadoc tool did not generate any warning messages.
              +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
              +1 findbugs.  The patch does not introduce any new Findbugs warnings.
              +1 release audit.  The applied patch does not increase the total number of release audit warnings.
          
          cos Konstantin I Boudnik added a comment - Here's the result of test-patch run: There appear to be 104 release audit warnings before the patch and 104 release audit warnings after applying the patch. +1 overall. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings.

          Also, have ran fault injection tests - everything works as expected:

              [junit] Running org.apache.hadoop.hdfs.TestFiHFlush
              [junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 19.173 sec
              [junit] Running org.apache.hadoop.hdfs.server.datanode.TestFiDataTransferProtocol
              [junit] Tests run: 16, Failures: 0, Errors: 0, Time elapsed: 207.648 sec
          
          cos Konstantin I Boudnik added a comment - Also, have ran fault injection tests - everything works as expected: [junit] Running org.apache.hadoop.hdfs.TestFiHFlush [junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 19.173 sec [junit] Running org.apache.hadoop.hdfs.server.datanode.TestFiDataTransferProtocol [junit] Tests run: 16, Failures: 0, Errors: 0, Time elapsed: 207.648 sec
          szetszwo Tsz-wo Sze added a comment -

          +1 patch looks good.

          Some thought: since hft may not be an instanceof HFlushTest, the variable name (hft, acronym of HFlushTest) may be misleading.

          szetszwo Tsz-wo Sze added a comment - +1 patch looks good. Some thought: since hft may not be an instanceof HFlushTest, the variable name (hft, acronym of HFlushTest) may be misleading.

          Thanks, Nicholas. I've renamed the variable - it makes sense.

          cos Konstantin I Boudnik added a comment - Thanks, Nicholas. I've renamed the variable - it makes sense.

          I have just committed it.

          cos Konstantin I Boudnik added a comment - I have just committed it.
          hudson Hudson added a comment -

          Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #47 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/47/)

          hudson Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #47 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/47/ )
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #79 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/79/)

          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #79 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/79/ )
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #120 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/120/)

          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #120 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/120/ )
          hudson Hudson added a comment -

          Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #78 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/78/)

          hudson Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #78 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/78/ )

          People

            cos Konstantin I Boudnik
            cos Konstantin I Boudnik
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment