Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: libhdfs
    • Labels:
      None
    • Release Note:
      Moved the libhdfs package to the HDFS subproject.

      Description

      Here's an hdfs jira for MAPREDUCE-665. During the project split libhdfs was put in the mapreduce repo instead of hdfs, lets move it to hdfs.

      1. addlibhdfs.patch
        1.32 MB
        Eli Collins

        Issue Links

          Activity

          Hide
          Eli Collins added a comment -

          This got fixed when Tom renamed the old 21 branch and created the new one from trunk.

          Show
          Eli Collins added a comment - This got fixed when Tom renamed the old 21 branch and created the new one from trunk.
          Hide
          Eli Collins added a comment -

          I think so, will make backports easier.

          Show
          Eli Collins added a comment - I think so, will make backports easier.
          Hide
          Chris Douglas added a comment -

          libhdfs is still in the 0.21 branch of MAPREDUCE. Shouldn't it also be moved in 0.21?

          Show
          Chris Douglas added a comment - libhdfs is still in the 0.21 branch of MAPREDUCE. Shouldn't it also be moved in 0.21?
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #72 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/72/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #72 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/72/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #136 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/136/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #136 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/136/ )
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #100 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/100/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #100 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/100/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #101 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/101/)
          . Move libhdfs from mapreduce subproject to hdfs subproject.
          (Eli Collins via dhruba)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #101 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/101/ ) . Move libhdfs from mapreduce subproject to hdfs subproject. (Eli Collins via dhruba)
          Hide
          dhruba borthakur added a comment -

          I did not use the patch file attached to this JIRA because I wanted to preserve the svn history of these files. Instead, I moved the libhdfs code by doing a "svn move". The libhdfs code i now part of the HDFS subproject. I can build it for a 64 bit rel

          Show
          dhruba borthakur added a comment - I did not use the patch file attached to this JIRA because I wanted to preserve the svn history of these files. Instead, I moved the libhdfs code by doing a "svn move". The libhdfs code i now part of the HDFS subproject. I can build it for a 64 bit rel
          Hide
          dhruba borthakur added a comment -

          I think this is ready to be committed. I will do this in a day unless anybody has any objections.

          Show
          dhruba borthakur added a comment - I think this is ready to be committed. I will do this in a day unless anybody has any objections.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12422408/addlibhdfs.patch
          against trunk revision 832585.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 25 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          -1 release audit. The applied patch generated 125 release audit warnings (more than the trunk's current 108 warnings).

          -1 core tests. The patch failed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/96/testReport/
          Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/96/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/96/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/96/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/96/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12422408/addlibhdfs.patch against trunk revision 832585. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 25 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 125 release audit warnings (more than the trunk's current 108 warnings). -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/96/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/96/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/96/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/96/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/96/console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          Looks like the generated files were checked in on purpose for HADOOP-3344, the build fails without them. How about we go ahead and move from mr to hdfs and address additional build changes in another jira?

          Show
          Eli Collins added a comment - Looks like the generated files were checked in on purpose for HADOOP-3344 , the build fails without them. How about we go ahead and move from mr to hdfs and address additional build changes in another jira?
          Hide
          Jakob Homan added a comment -

          Canceling patch for Eli to upload the new one without auto-generated content.

          Show
          Jakob Homan added a comment - Canceling patch for Eli to upload the new one without auto-generated content.
          Hide
          Eli Collins added a comment -

          This diff just moves what's in mr to hdfs – looks like some autogenerated build files were checked into mr during the project split, I'll update the patch to remove them.

          Show
          Eli Collins added a comment - This diff just moves what's in mr to hdfs – looks like some autogenerated build files were checked into mr during the project split, I'll update the patch to remove them.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12422408/addlibhdfs.patch
          against trunk revision 826121.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 25 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          -1 release audit. The applied patch generated 125 release audit warnings (more than the trunk's current 108 warnings).

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/29/testReport/
          Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/29/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/29/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/29/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/29/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12422408/addlibhdfs.patch against trunk revision 826121. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 25 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 125 release audit warnings (more than the trunk's current 108 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/29/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/29/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/29/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/29/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/29/console This message is automatically generated.
          Hide
          Eli Collins added a comment -

          Should also mention that no revision history is preserved. It looks like revision history wasn't imported to hdfs during the project split anyway.

          Show
          Eli Collins added a comment - Should also mention that no revision history is preserved. It looks like revision history wasn't imported to hdfs during the project split anyway.
          Hide
          Eli Collins added a comment -

          Note, I built libhdfs with ant compile -Dcompile.c++=true -Dlibhdfs=true

          Show
          Eli Collins added a comment - Note, I built libhdfs with ant compile -Dcompile.c++=true -Dlibhdfs=true
          Hide
          Eli Collins added a comment -

          Uploaded a patch that adds libhdfs and gets it building.

          Show
          Eli Collins added a comment - Uploaded a patch that adds libhdfs and gets it building.

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development