[HDFS-7049] TestByteRangeInputStream.testPropagatedClose fails and throw NPE on branch-2

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5.0
• Fix Version/s: 2.6.0
• Component/s: test
• Target Version/s: 2.6.0
• Hadoop Flags: Reviewed
• Assignee: Juan Yu Assign to me
• Reporter: Juan Yu
• Created: 11/Sep/14 18:12
• Updated: 01/Dec/14 03:09
• Resolved: 24/Sep/14 19:06

Description

On branch-2, TestByteRangeInputStream.testPropagatedClose throw NPE when HftpFileSystem$RangeHeaderUrlOpener.connect
This is due to fix of HDFS-6143 "WebHdfsFileSystem open should throw FileNotFoundException for non-existing paths"
public ByteRangeInputStream(URLOpener o, URLOpener r) throws IOException

{ this.originalURL = o; this.resolvedURL = r; getInputStream(); }

the getInputStream() will be called in constructor now to verify if file exists.
Since we just try to test if ByteRangeInputStream#close is called at proper time, we could mock(ByteRangeInputStream.class, CALLS_REAL_METHODS) for testing to avoid the NPE issue.
I believe the trunk version already does this, we just need to merge the test from trunk.

Issue Links

• is broken by: HDFS-6143 WebHdfsFileSystem open should throw FileNotFoundException for non-existing paths
• is related to: HDFS-6194 Create new tests for ByteRangeInputStream