Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-6905

fs-encryption merge triggered release audit failures

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 2.6.0
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Release audit is failing on three files since the merge of fs-encryption code due to missing Apache license:

      • hdfs/protocol/EncryptionZoneWithId.java
      • hdfs/server/namenode/EncryptionFaultInjector.java
      • hdfs/server/namenode/EncryptionZoneManager.java

        Issue Links

          Activity

          Hide
          Charles Lamb added a comment -

          Attached is a patch which adds the required headers.

          Show
          Charles Lamb added a comment - Attached is a patch which adds the required headers.
          Hide
          Yi Liu added a comment -

          Right, there files miss Apache license.
          From the Jenkins result of the merged patch in HDFS-6134, we have not seen these, seems Jenkins sometime can't report all issues if the patch gets too large?

          Show
          Yi Liu added a comment - Right, there files miss Apache license. From the Jenkins result of the merged patch in HDFS-6134 , we have not seen these, seems Jenkins sometime can't report all issues if the patch gets too large?
          Hide
          Allen Wittenauer added a comment -

          I'm not sure what's going on with Jenkins lately. It was stable after the move for a bit, then it started throwing weird errors again. Saw these failures in another jenkins run through. So there's that I guess? I'm really curious as to what it will say with this patch.

          Show
          Allen Wittenauer added a comment - I'm not sure what's going on with Jenkins lately. It was stable after the move for a bit, then it started throwing weird errors again. Saw these failures in another jenkins run through. So there's that I guess? I'm really curious as to what it will say with this patch.
          Hide
          Chen He added a comment -

          +1, lgtm

          Show
          Chen He added a comment - +1, lgtm
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12663416/HDFS-6905.001.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestEncryptionZones
          org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits

          The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestParallelShortCircuitReadUnCached

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7708//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7708//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12663416/HDFS-6905.001.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestEncryptionZones org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover org.apache.hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestParallelShortCircuitReadUnCached +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7708//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7708//console This message is automatically generated.
          Hide
          Alejandro Abdelnur added a comment -

          +1

          Show
          Alejandro Abdelnur added a comment - +1
          Hide
          Alejandro Abdelnur added a comment -

          thanks Charles. Committed to trunk.

          Show
          Alejandro Abdelnur added a comment - thanks Charles. Committed to trunk.
          Hide
          Alejandro Abdelnur added a comment -

          committed to branch-2.

          Show
          Alejandro Abdelnur added a comment - committed to branch-2.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #671 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/671/)
          Fixing HDFS CHANGES.txt, missing HDFS-6905 entry (tucu: rev 1a095361414ba660c139f33ae1eee430a3c3446c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #671 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/671/ ) Fixing HDFS CHANGES.txt, missing HDFS-6905 entry (tucu: rev 1a095361414ba660c139f33ae1eee430a3c3446c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1862 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1862/)
          Fixing HDFS CHANGES.txt, missing HDFS-6905 entry (tucu: rev 1a095361414ba660c139f33ae1eee430a3c3446c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1862 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1862/ ) Fixing HDFS CHANGES.txt, missing HDFS-6905 entry (tucu: rev 1a095361414ba660c139f33ae1eee430a3c3446c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1887 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1887/)
          Fixing HDFS CHANGES.txt, missing HDFS-6905 entry (tucu: rev 1a095361414ba660c139f33ae1eee430a3c3446c)

          • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1887 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1887/ ) Fixing HDFS CHANGES.txt, missing HDFS-6905 entry (tucu: rev 1a095361414ba660c139f33ae1eee430a3c3446c) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt

            People

            • Assignee:
              Charles Lamb
              Reporter:
              Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development