[HDFS-6870] Blocks and INodes could leak for Rename with overwrite flag

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.6.0
• Component/s: namenode
• Target Version/s: 2.6.0
• Hadoop Flags: Reviewed
• Assignee: Yi Liu
• Reporter: Yi Liu
• Created: 19/Aug/14 07:50
• Updated: 25/May/20 17:00
• Resolved: 20/Aug/14 18:15

Description

Following code in FSDirectory#unprotectedRenameTo doesn't collect blocks and INodes for non snapshot path.

        if (removedDst != null) {
          undoRemoveDst = false;
          if (removedNum > 0) {
            BlocksMapUpdateInfo collectedBlocks = new BlocksMapUpdateInfo();
            List<INode> removedINodes = new ChunkedArrayList<INode>();
            filesDeleted = removedDst.cleanSubtree(Snapshot.CURRENT_STATE_ID,
                dstIIP.getLatestSnapshotId(), collectedBlocks, removedINodes,
                true).get(Quota.NAMESPACE);
            getFSNamesystem().removePathAndBlocks(src, collectedBlocks,
                removedINodes, false);
          }
        }