Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Block blk_8364044872193449415_1001 isComplete = true expected to be true expected:<true> but was:<false>
      

      See build #57 for more details.

      1. h682_20091009.patch
        0.7 kB
        Tsz Wo Nicholas Sze
      2. h682_20091013.patch
        1 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        h682_20091009.patch: fix a bug on the test.

        Show
        Tsz Wo Nicholas Sze added a comment - h682_20091009.patch: fix a bug on the test.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12421772/h682_20091009.patch
        against trunk revision 822153.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/21/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/21/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/21/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/21/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12421772/h682_20091009.patch against trunk revision 822153. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/21/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/21/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/21/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/21/console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        okay, the problem in TestBlockUnderConstruction is not that simple.

        Show
        Tsz Wo Nicholas Sze added a comment - okay, the problem in TestBlockUnderConstruction is not that simple.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        The main problem is that TestBlockUnderConstruction expects the last block of a being-written file to be not complete. This dependents on whether the NameNode has received a block receipt from one or more datanodes. If a block receipt comes first, the block becomes complete. Otherwise, the NameNode has not yet received any block receipt and then the block remains not complete.

        The second problem is that the error message in the following is incorrect. This is the reason that h682_20091009.patch did not work.

        //TestBlockUnderConstruction.verifyFileBlocks(..)
            assertEquals("Block " + curBlock +
                " isComplete = " + curBlock.isComplete() +
                " expected to be " + isFileOpen,
                isFileOpen, !curBlock.isComplete());
        
        Show
        Tsz Wo Nicholas Sze added a comment - The main problem is that TestBlockUnderConstruction expects the last block of a being-written file to be not complete. This dependents on whether the NameNode has received a block receipt from one or more datanodes. If a block receipt comes first, the block becomes complete. Otherwise, the NameNode has not yet received any block receipt and then the block remains not complete. The second problem is that the error message in the following is incorrect. This is the reason that h682_20091009.patch did not work. //TestBlockUnderConstruction.verifyFileBlocks(..) assertEquals( "Block " + curBlock + " isComplete = " + curBlock.isComplete() + " expected to be " + isFileOpen, isFileOpen, !curBlock.isComplete());
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h682_20091013.patch: fixed the bugs in TestBlockUnderConstruction.

        Show
        Tsz Wo Nicholas Sze added a comment - h682_20091013.patch: fixed the bugs in TestBlockUnderConstruction.
        Hide
        Tsz Wo Nicholas Sze added a comment -
             [exec] +1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        

        Ran TestBlockUnderConstruction a few times. All of them passed in my machine.

        Show
        Tsz Wo Nicholas Sze added a comment - [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. Ran TestBlockUnderConstruction a few times. All of them passed in my machine.
        Hide
        Konstantin Boudnik added a comment -

        +1 patch looks good

        Show
        Konstantin Boudnik added a comment - +1 patch looks good
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Thanks, Cos for the reviewing.

        I have committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - Thanks, Cos for the reviewing. I have committed this.
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #47 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/47/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #47 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/47/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #79 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/79/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #79 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/79/ )
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #78 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/78/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #78 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/78/ )

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development