Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-6682

Add a metric to expose the timestamp of the oldest under-replicated block

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Target Version/s:

      Description

      In the following case, the data in the HDFS is lost and a client needs to put the same file again.

      1. A Client puts a file to HDFS
      2. A DataNode crashes before replicating a block of the file to other DataNodes

      I propose a metric to expose the timestamp of the oldest under-replicated/corrupt block. That way client can know what file to retain for the re-try.

      1. HDFS-6682.003.patch
        11 kB
        Akira AJISAKA
      2. HDFS-6682.002.patch
        10 kB
        Akira AJISAKA
      3. HDFS-6682.patch
        9 kB
        Akira AJISAKA

        Activity

        Hide
        Akira AJISAKA added a comment -

        Attached a patch to expose 'TimeOfTheOldestBlockToBeReplicated' metric. The metric shows timestamp of the oldest under-replicated/corrupt block.
        I built with the patch and verified the metric was obtained via JMX and FileSink.

        Show
        Akira AJISAKA added a comment - Attached a patch to expose 'TimeOfTheOldestBlockToBeReplicated' metric. The metric shows timestamp of the oldest under-replicated/corrupt block. I built with the patch and verified the metric was obtained via JMX and FileSink.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12656472/HDFS-6682.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.ipc.TestIPC
        org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
        org.apache.hadoop.fs.TestSymlinkLocalFSFileContext

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7383//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7383//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12656472/HDFS-6682.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.ipc.TestIPC org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem org.apache.hadoop.fs.TestSymlinkLocalFSFileContext +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7383//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7383//console This message is automatically generated.
        Hide
        Akira AJISAKA added a comment -

        These failed tests are not related to the patch. They were fixed by INFRA-8097 and HADOOP-10866.

        Show
        Akira AJISAKA added a comment - These failed tests are not related to the patch. They were fixed by INFRA-8097 and HADOOP-10866 .
        Hide
        Akira AJISAKA added a comment -

        Aaron T. Myers, would you please review this patch?

        Show
        Akira AJISAKA added a comment - Aaron T. Myers , would you please review this patch?
        Hide
        Akira AJISAKA added a comment -

        Attaching v2 patch:

        • Modified HashMap to keep the oldest timestamp for getting it without sorting
        • Use block_id(long) instead of block(Block) for the key of the HashMap
        Show
        Akira AJISAKA added a comment - Attaching v2 patch: Modified HashMap to keep the oldest timestamp for getting it without sorting Use block_id(long) instead of block(Block) for the key of the HashMap
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12691106/HDFS-6682.002.patch
        against trunk revision ae91b13.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9164//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/9164//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9164//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12691106/HDFS-6682.002.patch against trunk revision ae91b13. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9164//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/9164//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9164//console This message is automatically generated.
        Hide
        Akira AJISAKA added a comment -

        Fixed a findbugs warning.

        Show
        Akira AJISAKA added a comment - Fixed a findbugs warning.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12691345/HDFS-6682.003.patch
        against trunk revision ae91b13.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9165//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9165//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12691345/HDFS-6682.003.patch against trunk revision ae91b13. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/9165//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/9165//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12691345/HDFS-6682.003.patch
        against trunk revision af9d4fe.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10240//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12691345/HDFS-6682.003.patch against trunk revision af9d4fe. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/10240//console This message is automatically generated.

          People

          • Assignee:
            Akira AJISAKA
            Reporter:
            Akira AJISAKA
          • Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:

              Development