Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-6664

HDFS permissions guide documentation states incorrect default group mapping class.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.0, 2.5.0
    • Fix Version/s: 2.6.0
    • Component/s: documentation
    • Labels:

      Description

      The HDFS permissions guide states that our default group mapping class is org.apache.hadoop.security.ShellBasedUnixGroupsMapping. This is no longer true. The default has been changed to org.apache.hadoop.security.JniBasedUnixGroupsMappingWithFallback.

      1. HDFS6664-03.patch
        1 kB
        Ray Chiang
      2. HDFS6664-02.patch
        1 kB
        Ray Chiang
      3. HDFS6664-01.patch
        1 kB
        Ray Chiang

        Activity

        Show
        Chris Nauroth added a comment - http://hadoop.apache.org/docs/r2.4.1/hadoop-project-dist/hadoop-hdfs/HdfsPermissionsGuide.html#Group_Mapping
        Hide
        Ray Chiang added a comment -

        Mostly a cut-and-paste from core-default.xml, which has some very good descriptive text for the org.apache.hadoop.security.JniBasedUnixGroupsMappingWithFallback implementation behavior.

        Let me know how it looks to you.

        Show
        Ray Chiang added a comment - Mostly a cut-and-paste from core-default.xml, which has some very good descriptive text for the org.apache.hadoop.security.JniBasedUnixGroupsMappingWithFallback implementation behavior. Let me know how it looks to you.
        Hide
        Akira AJISAKA added a comment -

        Thanks Ray Chiang for the patch! Some comments:
        1.

        +   the <code>bash -c groups</code> command to resolve a list of
        

        <code> and </code> should be <<< and >>>. Most of Hadoop documents are now written in APT format (*.apt.vm). The format is described in http://maven.apache.org/doxia/references/apt-format.html

        2.

        +   This implementation shells out to the Linux/Unix environment with
        

        ShellBasedUnixGroupsMappings now supports Windows also.

        3 (minor).

        +   JNI is available the implementation will use the API within hadoop
        

        I think it's better to add a comma(,) between 'available' and 'the'.

        Show
        Akira AJISAKA added a comment - Thanks Ray Chiang for the patch! Some comments: 1. + the <code>bash -c groups</code> command to resolve a list of <code> and </code> should be <<< and >>> . Most of Hadoop documents are now written in APT format (*.apt.vm). The format is described in http://maven.apache.org/doxia/references/apt-format.html 2. + This implementation shells out to the Linux/Unix environment with ShellBasedUnixGroupsMappings now supports Windows also. 3 (minor). + JNI is available the implementation will use the API within hadoop I think it's better to add a comma(,) between 'available' and 'the'.
        Hide
        Ray Chiang added a comment -

        Akira AJISAKA, thanks for the quick feedback. I've incorporated your suggestions.

        Show
        Ray Chiang added a comment - Akira AJISAKA , thanks for the quick feedback. I've incorporated your suggestions.
        Hide
        Akira AJISAKA added a comment -

        Thanks for the update!

        +   This implementation shells out with the the <<<bash -c groups>>>
        

        Would you please remove duplicated 'the'? Other than that, the patch looks good to me.

        Show
        Akira AJISAKA added a comment - Thanks for the update! + This implementation shells out with the the <<<bash -c groups>>> Would you please remove duplicated 'the'? Other than that, the patch looks good to me.
        Hide
        Ray Chiang added a comment -

        Last fix.

        Show
        Ray Chiang added a comment - Last fix.
        Hide
        Ray Chiang added a comment -

        Submit for testing.

        Show
        Ray Chiang added a comment - Submit for testing.
        Hide
        Akira AJISAKA added a comment -

        +1 (non-binding), pending Jenkins.

        Show
        Akira AJISAKA added a comment - +1 (non-binding), pending Jenkins.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12660925/HDFS6664-03.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7606//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7606//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12660925/HDFS6664-03.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7606//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7606//console This message is automatically generated.
        Hide
        Allen Wittenauer added a comment -

        +1 lgtm.

        Committing to trunk and branch-2.

        Thanks!

        Show
        Allen Wittenauer added a comment - +1 lgtm. Committing to trunk and branch-2. Thanks!
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #6124 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6124/)
        HDFS-6664. HDFS permissions guide documentation states incorrect default group mapping class. (Ray Chiang via aw) (aw: rev 3a1f981686835f64df4498f93dae73fde3f2c7a8)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsPermissionsGuide.apt.vm
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #6124 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6124/ ) HDFS-6664 . HDFS permissions guide documentation states incorrect default group mapping class. (Ray Chiang via aw) (aw: rev 3a1f981686835f64df4498f93dae73fde3f2c7a8) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsPermissionsGuide.apt.vm
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #693 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/693/)
        HDFS-6664. HDFS permissions guide documentation states incorrect default group mapping class. (Ray Chiang via aw) (aw: rev 3a1f981686835f64df4498f93dae73fde3f2c7a8)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsPermissionsGuide.apt.vm
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #693 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/693/ ) HDFS-6664 . HDFS permissions guide documentation states incorrect default group mapping class. (Ray Chiang via aw) (aw: rev 3a1f981686835f64df4498f93dae73fde3f2c7a8) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsPermissionsGuide.apt.vm
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1884 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1884/)
        HDFS-6664. HDFS permissions guide documentation states incorrect default group mapping class. (Ray Chiang via aw) (aw: rev 3a1f981686835f64df4498f93dae73fde3f2c7a8)

        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsPermissionsGuide.apt.vm
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1884 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1884/ ) HDFS-6664 . HDFS permissions guide documentation states incorrect default group mapping class. (Ray Chiang via aw) (aw: rev 3a1f981686835f64df4498f93dae73fde3f2c7a8) hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsPermissionsGuide.apt.vm
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1909 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1909/)
        HDFS-6664. HDFS permissions guide documentation states incorrect default group mapping class. (Ray Chiang via aw) (aw: rev 3a1f981686835f64df4498f93dae73fde3f2c7a8)

        • hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsPermissionsGuide.apt.vm
        • hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1909 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1909/ ) HDFS-6664 . HDFS permissions guide documentation states incorrect default group mapping class. (Ray Chiang via aw) (aw: rev 3a1f981686835f64df4498f93dae73fde3f2c7a8) hadoop-hdfs-project/hadoop-hdfs/src/site/apt/HdfsPermissionsGuide.apt.vm hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
        Hide
        Ray Chiang added a comment -

        Thanks for committing!

        Show
        Ray Chiang added a comment - Thanks for committing!

          People

          • Assignee:
            Ray Chiang
            Reporter:
            Chris Nauroth
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development