[HDFS-6618] FSNamesystem#delete drops the FSN lock between removing INodes from the tree and deleting them from the inode map

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 2.5.0
• Fix Version/s: 2.5.0
• Target Version/s: 2.5.0
• Assignee: Kihwal Lee
• Reporter: Kihwal Lee
• Created: 01/Jul/14 16:59
• Updated: 15/Aug/14 05:41
• Resolved: 10/Jul/14 03:59

Description

After HDFS-6527, we have not seen the edit log corruption for weeks on multiple clusters until yesterday. Previously, we would see it within 30 minutes on a cluster.

But the same condition was reproduced even with HDFS-6527. The only explanation is that the RPC handler thread serving addBlock() was accessing stale parent value. Although nulling out parent is done inside the FSNamesystem and FSDirectory write lock, there is no memory barrier because there is no "synchronized" block involved in the process.

I suggest making parent volatile.

Issue Links

• is depended upon by: HDFS-6647 Edit log corruption when pipeline recovery occurs for deleted file present in snapshot