Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed

      Description

      Need to remove InterDatanodeProtocol.updateBlock() and getBlockMetaDataInfo() along with their implementations in DataNode and BlockMetaDataInfo class.

      1. deprecated.patch
        13 kB
        Konstantin Shvachko

        Activity

        Hide
        shv Konstantin Shvachko added a comment -

        Here is the patch that removes the methods. Let me know if this is too aggressive.
        I am also not sure when we should apply it. Probably after the merge?

        Show
        shv Konstantin Shvachko added a comment - Here is the patch that removes the methods. Let me know if this is too aggressive. I am also not sure when we should apply it. Probably after the merge?
        Hide
        shv Konstantin Shvachko added a comment -

        test-core: BUILD SUCCESSFUL
        test-patch:

        .    [exec] There appear to be 104 release audit warnings before the patch and 104 release audit warnings after applying the patch.
             [exec] +1 overall.  
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec]     +1 tests included.  The patch appears to include 6 new or modified tests.
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec] ======================================================================
             [exec] ======================================================================
             [exec]     Finished build.
             [exec] ======================================================================
             [exec] ======================================================================
        BUILD SUCCESSFUL
        Total time: 14 minutes 8 seconds
        
        Show
        shv Konstantin Shvachko added a comment - test-core: BUILD SUCCESSFUL test-patch: . [exec] There appear to be 104 release audit warnings before the patch and 104 release audit warnings after applying the patch. [exec] +1 overall. [exec] +1 @author. The patch does not contain any @author tags. [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== BUILD SUCCESSFUL Total time: 14 minutes 8 seconds
        Hide
        sureshms Suresh Srinivas added a comment -

        +1 for the patch.

        Show
        sureshms Suresh Srinivas added a comment - +1 for the patch.
        Hide
        shv Konstantin Shvachko added a comment -

        I just committed this.

        Show
        shv Konstantin Shvachko added a comment - I just committed this.
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #60 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/60/)
        . Remove deprecated methods from InterDatanodeProtocol. Contributed by Konstantin Shvachko.

        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #60 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/60/ ) . Remove deprecated methods from InterDatanodeProtocol. Contributed by Konstantin Shvachko.
        Hide
        hudson Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #106 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/106/)

        Show
        hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #106 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/106/ )
        Hide
        hudson Hudson added a comment -

        Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #20 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/20/)

        Show
        hudson Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #20 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/20/ )

          People

          • Assignee:
            shv Konstantin Shvachko
            Reporter:
            shv Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development