Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-265 Revisit append
  3. HDFS-660

Remove deprecated methods from InterDatanodeProtocol.

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed

      Description

      Need to remove InterDatanodeProtocol.updateBlock() and getBlockMetaDataInfo() along with their implementations in DataNode and BlockMetaDataInfo class.

      1. deprecated.patch
        13 kB
        Konstantin Shvachko

        Activity

        Konstantin Shvachko created issue -
        Hide
        Konstantin Shvachko added a comment -

        Here is the patch that removes the methods. Let me know if this is too aggressive.
        I am also not sure when we should apply it. Probably after the merge?

        Show
        Konstantin Shvachko added a comment - Here is the patch that removes the methods. Let me know if this is too aggressive. I am also not sure when we should apply it. Probably after the merge?
        Konstantin Shvachko made changes -
        Field Original Value New Value
        Attachment deprecated.patch [ 12420754 ]
        Konstantin Shvachko made changes -
        Fix Version/s 0.21.0 [ 12314046 ]
        Fix Version/s Append Branch [ 12314142 ]
        Affects Version/s 0.21.0 [ 12314046 ]
        Affects Version/s Append Branch [ 12314142 ]
        Konstantin Shvachko made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Konstantin Shvachko added a comment -

        test-core: BUILD SUCCESSFUL
        test-patch:

        .    [exec] There appear to be 104 release audit warnings before the patch and 104 release audit warnings after applying the patch.
             [exec] +1 overall.  
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec]     +1 tests included.  The patch appears to include 6 new or modified tests.
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec] ======================================================================
             [exec] ======================================================================
             [exec]     Finished build.
             [exec] ======================================================================
             [exec] ======================================================================
        BUILD SUCCESSFUL
        Total time: 14 minutes 8 seconds
        
        Show
        Konstantin Shvachko added a comment - test-core: BUILD SUCCESSFUL test-patch: . [exec] There appear to be 104 release audit warnings before the patch and 104 release audit warnings after applying the patch. [exec] +1 overall. [exec] +1 @author. The patch does not contain any @author tags. [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== BUILD SUCCESSFUL Total time: 14 minutes 8 seconds
        Hide
        Suresh Srinivas added a comment -

        +1 for the patch.

        Show
        Suresh Srinivas added a comment - +1 for the patch.
        Hide
        Konstantin Shvachko added a comment -

        I just committed this.

        Show
        Konstantin Shvachko added a comment - I just committed this.
        Konstantin Shvachko made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Incompatible change] [Incompatible change, Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #60 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/60/)
        . Remove deprecated methods from InterDatanodeProtocol. Contributed by Konstantin Shvachko.

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #60 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/60/ ) . Remove deprecated methods from InterDatanodeProtocol. Contributed by Konstantin Shvachko.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #106 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/106/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #106 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/106/ )
        Hide
        Hudson added a comment -

        Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #20 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/20/)

        Show
        Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #20 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/20/ )
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        6d 17h 56m 1 Konstantin Shvachko 05/Oct/09 20:19
        Patch Available Patch Available Resolved Resolved
        3h 56m 1 Konstantin Shvachko 06/Oct/09 00:16
        Resolved Resolved Closed Closed
        322d 21h 33m 1 Tom White 24/Aug/10 21:49

          People

          • Assignee:
            Konstantin Shvachko
            Reporter:
            Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development