[HDFS-6587] Bug in TestBPOfferService can cause test failure

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.0
• Fix Version/s: 2.5.0
• Component/s: test
• Target Version/s: 2.5.0
• Hadoop Flags: Reviewed
• Assignee: Zhilei Xu
• Reporter: Zhilei Xu
• Created: 22/Jun/14 19:42
• Updated: 03/Sep/14 20:34
• Resolved: 23/Jun/14 18:23

Description

need to fix a bug in TestBPOfferService#waitForBlockReceived that fails the trunk, e.g. in Build #1781.
Details: in this test, the utility function waitForBlockReceived() has a bug:
parameter mockNN is never used but hard-coded mockNN1 is used.
This bug introduces undeterministic test failure when testBasicFunctionality() calls
ret = waitForBlockReceived(FAKE_BLOCK, mockNN2);
and the call finishes before the actual interaction with mockNN2 happens.